Dev

dev@lists.roundcube.net

1 participants
4289 discussions

Re: [RCD] [RCU] Message thread view (again) in roundcube without server support
by Miguel Telleria de Esteban 23 Sep '11

23 Sep '11

[ Cross list reply from users list, here is my original post if somebody is interested http://lists.roundcube.net/mail-archive/users/2011-09/0000050.html ] Hello again, On Wed, 21 Sep 2011 12:18:31 +0200 A.L.E.C wrote: > On 21.09.2011 12:08, Miguel Telleria de Esteban wrote: > > > OPEN QUESTIONS: > > Is there a way in roundcube to trace the IMAP traffic? > > imap_debug option. > > > Although I guess that if I don't have the threading options > > displayed in folder settings is because roundcube has already > > parsed the capabilities from the server correctly. > > Right. Ok, I can confirm that my IMAP server does not have the THREAD capability. * CAPABILITY IMAP4 IMAP4rev1 AUTH=NTLM AUTH=GSSAPI AUTH=PLAIN UIDPLUS CHILDREN IDLE NAMESPACE > > * Figuring out how to recover client-side thread sorting in > > roundcube as a Fallback when the server does not implement it. > > You could try to write the code, but it would be slow. > Ok, I am going to give it a try :). So, if I understand correctly the indications here: http://lists.roundcube.net/mail-archive/users/2011-08/0000028.html THE FOLLOWING THINGS APPLY 1. Each time a threading sort is needed, the method: rcube_imap_generic :: thread() is called. function thread($mailbox, $algorithm='REFERENCES', $criteria='', $encoding='US-ASCII') 2. This thread() method must perform the following actions: 1. Invoke the THREAD command on the IMAP server using the function arguments ordering algorithm, search criteria and encoding as their directly correspondants in the IMAP THREAD command (RFC 5256). 2. Treat the response, and parse it returning the following values: - A "tree" - A "depthmap" (which is an array) - A "haschildren" (which is also an array) 3. These (tree, depthmap and haschildren) values are generated from the IMAP THREAD response by the recursive parseThread() private method. The IMAP THREAD response is specified in RFC 5256, and here I paste an illustrative example Server response: * THREAD (2)(3 6 (4 23)(44 7 96)) means -- 2 -- 3 \-- 6 |-- 4 | \-- 23 | \-- 44 \-- 7 \-- 96 4. RFC 5256 defines two sorting/threading algorithms: - ORDEREDSUBJECT: Poor man's threading algo based on heuristincs in the subject content. - REFERENCES: Uses "References" (preferably) or "In-Reply-To" (alternatively) header to match "Message-Id" values and establish parent-->child relationships. Besides than the RFC 5256, the references method is also described here: http://www.jwz.org/doc/threading.html 5. There is an additional sorting/threading algorithm recognised by roundcube: - REFS: Slight variation of REFERENCES in which the Subject field is completely ignored. - So far it seems to be defined in IETF Drafts, it has not reached RFC status yet. http://tools.ietf.org/html/draft-ietf-morg-inthread-01 http://tools.ietf.org/html/draft-gulbrandsen-imap-inthread-03 6. The selected threading algorithm is stored in $RCMAIL->imap->threading having as values: "REFS", "REFERENCES", "ORDEREDSUBJECT" or NULL (to signal no threading support) 7. The Iloha IMAP library (former file /program/lib/imap.inc) from which rcube_imap_generic.php evolves has the following functions related to threading: iil_SortThreadHeaders() iil_C_FetchThreadHeaders() iil_C_BuildThreads2() iil_SortThreads() iil_IndexThreads() the thread structure is implemented as: class iilThreadHeader { var $id; var $sbj; var $irt; var $mid; } MY PROPOSED APPROACH (see also open questions below) Inside the rcube_imap_generic::thread() function bypass the this->execute(THREAD) command and call a function of my own: client_side_thread_command($mailbox, $criteria, $encoding) This function should perform the following actions: * Obtain the message-id (or UID?) of files with the SEARCH criteria * FETCH the headers REFERENCES, IN-REPLY-TO and MESSAGE-ID of the searched messages. * Perform the REFS algorithm on them following RFC 5256 or jmz.org's article (I hope that this is already done in iil library). * Return a parenthesised list with the thread ordering similar to the IMAP THREAD reply so that it can be fed to parseThread(), or alternatively generate the tree, depthmap and haschildren data structure directly. CODING RESOURCES http://trac.roundcube.net/wiki/Dev_Docs http://trac.roundcube.net/wiki/Dev_PHPCommons http://roundcube.net/doc/phpdoc/Mail/rcube_imap.html http://roundcube.net/doc/phpdoc/Mail/rcube_imap_generic.html OPEN QUESTIONS: * Is this thread() function, the only entry point for thread ordering in roundcube?. If it is true then I guess that paging, sorting, etc are solved elsewhere. * Is there a per-mailbox indication for threading? * Is there a combined search+fetch-headers function in rcube_imap_generic() or rcube_imap() * Should I work with UID's or message sequences? * Should I code based on 0.6-rc base or in a more modern svn checkout? Any more comments will be welcome. I plan to start the work next week. Regards, Miguel -- (O-O) ---oOO-(_)-OOo----------------------------------------------------- Miguel TELLERIA DE ESTEBAN http://www.mtelleria.com Email: miguel at mtelleria.com Tel GSM: +34 650 801098 Tel Fix: +34 942 280174 Miembro de http://www.linuca.org Membre du http://www.bxlug.be ¿Usuario captivo o libre? http://www.obtengalinux.org/windows/ Free or captive user? http://www.getgnulinux.org/windows/ ------------------------------------------------------------------- [signature.asc application/pgp-signature (198 bytes)] [signature.asc application/pgp-signature (198 bytes)] --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/1Y/KLR7Eub4/signature.asc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

minimum version requirements for plugins
by Phil Weir 22 Sep '11

22 Sep '11

Hi, As both the plugin API and the RC core evolve newer plugins might not work with older versions of RC. Putting this information in the readme or on the website with the plugin is the obvious answer but some people just ignore that and install the wrong version any way. Agreed that is their own fault and they should read the instructions but adding some kind of check into the API for compatible versions seems to be quite easy, using the version_compare function in PHP. I had a little play with it and the idea basically works. There are 2 considerations that I can see: 1) It's only a very basic check: "this plugin works with 0.5.2 and later" 2) The RC version string needs to be written in the "PHP-standardized" way. That means it has to be x-dev rather than x-svn and no x-stable just x.0 I'm not sure if this is a waste of time and people should just read instructions, may be it is. If anyone thinks it's a good idea I can make a patch. Phil _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

4 5

moving/copying contacts between address books
by Thomas Bruederli 22 Sep '11

22 Sep '11

Hi all There has been some discussion coming up which I'd like to continue over here. Roundcube can have any number of address books (sources), mostly provided by plugins and LDAP configuration, which are all listed in the address book view. It's already possible to drag & drop one or more contacts from one source onto another which will result in a copy operation. Compared to the mail view this is not consistent because in mail context, dragging & dropping a message onto another folder will result in a move operation. Do you think the address book should behave the same as mail, meaning that the dropped contacts will be deleted in the source after copying to the new location succeeded? Of course this would only apply if the source is writeable. Your feedback is welcome! Regards, Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

3 2

Compose button and drafts
by Thomas Bruederli 22 Sep '11

22 Sep '11

And here's another topic to discuss. Imagine the following situation: 1. Create a message and save it as a draft 2. Go and see it in Drafts folder 3. Then remember you have to write an important message to somebody else 4. Hit on "Create a new message" button 5. Oops - the draft you're currently viewing is in the "compose new message" screen. This is the current behavior of Roundcube: in drafts folder, the compose button will open the currently selected draft instead of starting a new message. So far nobody complained but we have reports from testers who suggested to change this. An existing draft can be opened again with a double-click and in addition to that we could add a button "Edit" to the content area of the draft message. What do you think? Regards, Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

3 2

tab not selecting address
by S c o t t K r a m e r 21 Sep '11

21 Sep '11

Hi, This change is a little weird, tab not longer selects the contact-- it just goes to subject leaving the first few chars you typed in the To field. http://trac.roundcube.net/changeset/5252 [1] --Scott Links: ------ [1] http://trac.roundcube.net/changeset/5252 _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

2 1

Translation to Spanish
by José M. Ciordia 20 Sep '11

20 Sep '11

Hello. In the attachment are the last strings translated to Spanish. Have a nice day. José M. Ciordia --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/wy/U+6buvB5/labels.inc http://detached.gigo.com/rc/wy/U+6buvB5/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

Italian translation updated
by Luca Ferrario 20 Sep '11

20 Sep '11

Please find attached to this message the updated Italian translation. Many thanks for the excellent job to all the developers! Have a nice day! Luca --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/er/yNOMkmyK/messages.inc.txt http://detached.gigo.com/rc/er/yNOMkmyK/labels.inc.txt Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

session cookie path
by Phil Weir 17 Sep '11

17 Sep '11

Hi, At the moment it is possible to set the cookie domain from the config file. Would the devs consider also adding a similar option for the session cookie path? Thanks, Phil _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

2 2

Client side modification of messagelist columns content
by Roland Liebl 16 Sep '11

16 Sep '11

Hi all, I need some help to modify the html content of messagelist columns. Basically it is easy by using jquery: $('#messagelist tbody tr td').each(function(){ var elem = $(this); elem.html('modified content'); }); Unfortunately I loose event bindings when doing that. I think there are modifications in app.js necessary (using jquery .live() for event binding?). When looking into app.js(.src) I'm lost due to my limited javascript skills. Any hints? Regards, _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

2 1

Norwegian (nynorsk) translation
by Linda Petterdotter Løvik 16 Sep '11

16 Sep '11

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/DY/8jN1QQyi/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev