Roland Liebl wrote:

do you plan to implement the following (IMO standard) features during v0.3 development or should they better be implemented as a plugin?

#1 - Forward message as attachment #2 - Copy message to folder (currently only "move" is available) #3 - Attach vCard according to identity #4 - Select Range/Invert Selection in message list (I like it and am used to that feature from Squirrel) #5 - Expand/Collapse all folders in folder list

Currently I don't plan to implement these features, but I think they are good propositions for core. So, create patches not plugins, and we'll commit them. They shouldn't come serious changes to the code, so could be added in 0.3.

On May 30, 2009, at 9:23 AM, Roland Liebl wrote:

I have coded #4 (Invert Selection and Select Range) as plugin (see
attachment). Perhaps not all will like this features. Any criticism
is welcome. I'm not the most skilled programmer!

Looks fine to me. One minor thing. You dont need to code your own load
function. The API now has a load_config call that you can use.

Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

Hi Alec,

thanks for comments.

I can't contribute with patches due lack of knowledge (Windows fuzzy). I will make it to disable links if mailbox is empty. As soon as 'invert' is part of core I'll strip 'invert' of the plugin code.

One question ... Is there any reason not to provide a default command case in app.js? Such like ...

  case 'delete-folder':
    this.delete_folder(props);
    break;

  // Find me: API: Javascript command,
  default:
    if(typeof eval(command) == 'function'){
      return eval(command)();
    }

... would make it easier to jump in - at least for me.

Regards, Roland

----- Original Message ----- From: "A.L.E.C" alec@alec.pl To: dev@lists.roundcube.net Sent: Saturday, May 30, 2009 7:31 PM Subject: Re: [RCD] Feature Discussion

Roland Liebl wrote:

...

I have coded #4 (Invert Selection and Select Range) as plugin (see attachment). Perhaps not all will like this features. Any criticism is welcome. I'm not the most skilled programmer!

As I said previously, this should be added into core. Two points from me:

1. Create a patch not a plugin. Since 'range' is targeted for IE users,

maybe we should split this: 'invert' as core feature and 'range' as plugin. 3. If mailbox is empty links should be disabled.

-- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

List info: http://lists.roundcube.net/dev/

I have updated it disable links if mailbox is empty. I will update it again if there is a "container" in listcontrols such like in settingstabs.html (<roundcube:container name="tabs" id="tabsbar" />) in the default skin,

Regards, Roland

PS: @ Cor Brosman I kept my _load_config, because I like to include config.inc.php.dist by default. ----- Original Message ----- From: "A.L.E.C" alec@alec.pl To: dev@lists.roundcube.net Sent: Saturday, May 30, 2009 7:31 PM Subject: Re: [RCD] Feature Discussion

Roland Liebl wrote:

...

I have coded #4 (Invert Selection and Select Range) as plugin (see attachment). Perhaps not all will like this features. Any criticism is welcome. I'm not the most skilled programmer!

As I said previously, this should be added into core. Two points from me:

1. Create a patch not a plugin. Since 'range' is targeted for IE users,

maybe we should split this: 'invert' as core feature and 'range' as plugin. 3. If mailbox is empty links should be disabled.

-- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/2s/9Fb1q48U/listcontrols.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/

Cor Bosman wrote:

...

PS: @ Cor Brosman I kept my _load_config, because I like to include config.inc.php.dist by default.

You still can. load_config in the api returns false if it cant load the file, and allows for you to give your own filename. So you can try to $this->load_config() first, and if that returns false, do $this-

...

load_config('config.php.inc.dist');

I'd rather change that into

$this->load_config('config.php.inc.dist'); $this->load_config('config.php.inc');

This way the "default" config is loaded first and config.php.inc can only contain a subset of config parameters that are finally merged over the defaults.

~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

I removed "Invert" now as it is in core meanwhile. Thanks Alec! Also I remove the plugin config as it is not necessary anymore. In addition I updated german localization (de_DE / added "invert" label).

----- Original Message ----- From: "A.L.E.C" alec@alec.pl Cc: dev@lists.roundcube.net Sent: Sunday, May 31, 2009 1:14 PM Subject: Re: [RCD] Feature Discussion

Roland Liebl wrote:

...

I have updated it disable links if mailbox is empty. I will update it again if there is a "container" in listcontrols such like in settingstabs.html (<roundcube:container name="tabs" id="tabsbar" />) in the default skin,

In r2581 I've added 'invert' into core. Also you can use 'listcontrols' container now.

-- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Ub/d20CyZRa/listcontrols.zip http://detached.gigo.com/rc/Ub/d20CyZRa/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/