Hi,
I use (and develop) the skin Groupvice4. I've just upgraded to v0.5.2 and noticed that the buttons for the plugins Archive and MarkAsJunk have code in the plugin which is skin unaware:
'width' => 32,
'height' => 32,
The cause of the problem are these width and the height values. why are they added? Can this be fixed?
For now I've removed these values and the buttons show fine.
Kees de Keizer kees@de-keizer.net http://www.de-keizer.net/ _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80
W dniu 2011-05-02 10:14, Kees de Keizer (RC) pisze:
I use (and develop) the skin Groupvice4. I've just upgraded to v0.5.2 and noticed that the buttons for the plugins Archive and MarkAsJunk have code in the plugin which is skin unaware:
'width' => 32, 'height' => 32,The cause of the problem are these width and the height values. why are they added? Can this be fixed?
http://trac.roundcube.net/changeset/4458
On Mon, 02 May 2011 10:24:40 +0200, A.L.E.C wrote:
I use (and develop) the skin Groupvice4. I've just upgraded to v0.5.2 and noticed that the buttons for the plugins Archive and MarkAsJunk have code in the plugin which is skin unaware:
'width' => 32, 'height' => 32,The cause of the problem are these width and the height values. why are they added? Can this be fixed?
Hardcoded heights and widths in the code are not a nice workaround to support an ancient browser. This breaks the skin-awareness for these plugins.
On Mon, 02 May 2011 08:14:31 +0000, Kees de Keizer (RC) wrote:
Hi,
I use (and develop) the skin Groupvice4. I've just upgraded to v0.5.2 and noticed that the buttons for the plugins Archive and MarkAsJunk have code in the plugin which is skin unaware:
'width' => 32, 'height' => 32,The cause of the problem are these width and the height values. why are they added? Can this be fixed?
For now I've removed these values and the buttons show fine.
IMO, it is good for rendering performance to set image dimensions. But it should be done dynamically:
$temparr = getimagesize(INSTALL_PATH . $icon); $temparr['width'] ... $temparr['height']
List info: http://lists.roundcube.net/dev/ BT/aba52c80
W dniu 2011-05-02 11:19, Kees de Keizer (RC) pisze:
Hardcoded heights and widths in the code are not a nice workaround to support an ancient browser. This breaks the skin-awareness for these plugins.
I think we could create some css class with width and height definition and use it instead. I think this should work for IE6 too.
-
A.L.E.C -
Kees de Keizer (RC) -
Roland Liebl