I feel like I remember reading or even actually writing something about this some time ago. But I wanted to bring it up again because to me personally it seems like a bug. I'm running the latest devel-threads branch, and if a thread is collapsed and I drag it to another folder only the top-level message is moved, the remaining messages of the thread don't get moved. This seems unintuitive to me. In my mind it makes more sense to move the entire part of the collapsed thread from the point that thread was grabbed down. Some months ago I had implemented this in my own testing install. I can't recall now if it worked 100%, but I think it mostly worked:
http://code.nkinka.de/gitweb?p=roundcube.git;a=commitdiff;h=f3bb47d0e30a2e58...
There is a side of me that feels like if any message in a thread is grabbed and dragged to another folder that the whole thread should probably be moved to, but I can see how some people might find that shocking and disagreeable. Really, the path forward should be the Gmail approach of one giant bucket and using tags. The folder paradigm is sort of broken by nature, but that's another story.
Nathan _______________________________________________ List info: http://lists.roundcube.net/dev/
Nathan Kinkade wrote:
I feel like I remember reading or even actually writing something about this some time ago. But I wanted to bring it up again because to me personally it seems like a bug. I'm running the latest devel-threads branch, and if a thread is collapsed and I drag it to another folder only the top-level message is moved, the remaining messages of the thread don't get moved. This seems unintuitive to me. In my mind it makes more sense to move the entire part of the collapsed thread from the point that thread was grabbed down.
I compared the behavior of other mail clients and most of them also select childs when dragging a message. Thunderbird only does it when the thread is collapsed. In svn trunk (rev. 3372) this is now implemented. We can still discuss whether this automatic selection should only take place when the thread is collapsed.
~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/
17.03.2010 18:54, Thomas Bruederli пишет:
Nathan Kinkade wrote:
I feel like I remember reading or even actually writing something about this some time ago. But I wanted to bring it up again because to me personally it seems like a bug. I'm running the latest devel-threads branch, and if a thread is collapsed and I drag it to another folder only the top-level message is moved, the remaining messages of the thread don't get moved. This seems unintuitive to me. In my mind it makes more sense to move the entire part of the collapsed thread from the point that thread was grabbed down.
I compared the behavior of other mail clients and most of them also select childs when dragging a message. Thunderbird only does it when the thread is collapsed. In svn trunk (rev. 3372) this is now implemented. We can still discuss whether this automatic selection should only take place when the thread is collapsed.
I think that yes, only collapsed thread should be selected. I already implemented it and this was included in my last patches.
Vladislav. _______________________________________________ List info: http://lists.roundcube.net/dev/
Thomas Bruederli wrote:
Nathan Kinkade wrote:
I feel like I remember reading or even actually writing something about this some time ago. But I wanted to bring it up again because to me personally it seems like a bug. I'm running the latest devel-threads branch, and if a thread is collapsed and I drag it to another folder only the top-level message is moved, the remaining messages of the thread don't get moved. This seems unintuitive to me. In my mind it makes more sense to move the entire part of the collapsed thread from the point that thread was grabbed down.
I compared the behavior of other mail clients and most of them also select childs when dragging a message. Thunderbird only does it when the thread is collapsed.
Thunderbird2 does not.
In svn trunk (rev. 3372) this is now implemented. We can still
I see a bug here. Steps to reproduce:
- expand thread
- select a root message
- collapse thread
- do delete
Result: only root is deleted
discuss whether this automatic selection should only take place when the thread is collapsed.
I think automatic thread selection may happen only when root is selected and thread is collapsed. I mean we should mark children on collapse, and unmark them on expand. Also this must work with all listcontrols (eg. Select all, Select unread, Invert).
A.L.E.C wrote:
I think automatic thread selection may happen only when root is selected and thread is collapsed. I mean we should mark children on collapse, and unmark them on expand. Also this must work with all listcontrols (eg. Select all, Select unread, Invert).
However, I still think that before r3372 it was working better, ie. child-messages have to be selected directly.
A.L.E.C wrote:
However, I still think that before r3372 it was working better, ie. child-messages have to be selected directly.
For me, with additional "select all in thread" button this would be sufficient, complete and intuitive.
17.03.2010 19:13, A.L.E.C wrote:
discuss whether this automatic selection should only take place when the thread is collapsed.
I think automatic thread selection may happen only when root is selected and thread is collapsed. I mean we should mark children on collapse, and unmark them on expand. Also this must work with all listcontrols (eg. Select all, Select unread, Invert).
That was as I implemented it. It worked perfectly.
Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/
I think automatic thread selection may happen only when root is selected and thread is collapsed. I mean we should mark children on collapse, and unmark them on expand. Also this must work with all listcontrols (eg. Select all, Select unread, Invert).
That was as I implemented it. It worked perfectly.
But I also leave children marked on expand if they were previously marked. I think this is the most intuitive behavior. Think of it: mark everything visible and its children and leave it marked on expand.
Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
-
A.L.E.C -
Nathan Kinkade -
Thomas Bruederli -
Vladislav Bogdanov