Due to reasons not related to Roundcube, I needed to install FF today.
After just a few minutes of usage, I realized that the keyboard zoom function Ctrl-+/- is partially broken in the Roundcube window/tab: It's working in the first place, but right after clicking on a message in the message list, it doesn't work at all anymore.
At least here: Win7/64, FF 26.0
Ah: When creating a new message in a new window (!), and returning with <Alt-Tab> to the main Roundcube window, the (keyboard) zoom function is working again.
Hmmm...? Replicable?
I thought I'd finally get rid of all problems when moving away from IE, but this experience with FF after just a few minutes (although it may be a Roundcube issue) doesn't make me really happy.
And BTW: The sizes of fonts are being displayed totally different to IE. But that's clearly NOT a Roundcube issue, of course.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 12/29/2013 01:43 AM, Michael Heydekamp wrote:
After just a few minutes of usage, I realized that the keyboard zoom function Ctrl-+/- is partially broken in the Roundcube window/tab: It's working in the first place, but right after clicking on a message in the message list, it doesn't work at all anymore.
Works for me with Roundcube 1.0-beta. There was a lot of keyboard related changes.
Am 29.12.2013 09:37, schrieb A.L.E.C:
On 12/29/2013 01:43 AM, Michael Heydekamp wrote:
After just a few minutes of usage, I realized that the keyboard zoom function Ctrl-+/- is partially broken in the Roundcube window/tab: It's working in the first place, but right after clicking on a message in the message list, it doesn't work at all anymore.
Works for me with Roundcube 1.0-beta. There was a lot of keyboard related changes.
And what about 1.0-git (that's the version I'm talking about)? And which keyboard changes ever 1.0-beta may have, they will be in 1.0-git then anyway, right?
The scenario I described is 100% replicable here.
More observations that I did in the meantime:
- The only zoom key that works right after clicking on a message, is
Ctrl+0, while Ctrl+- und Ctrl++ do not work.
- Nonetheless, the zoom keys do work in all other tabs that may be open at
the same time.
- Another possibility to make the keys working again in the Roundcube
tab/window is to switch between HTML and text view on a multipart/alternative message.
- The problem does not appear in IE.
HTH and cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 12/29/2013 08:02 PM, Michael Heydekamp wrote:
And what about 1.0-git (that's the version I'm talking about)? And which keyboard changes ever 1.0-beta may have, they will be in 1.0-git then anyway, right?
Right, the same with git-master. Works for me with Firefox 26 on Linux. Skin independent.
Am 30.12.2013 08:15, schrieb A.L.E.C:
On 12/29/2013 08:02 PM, Michael Heydekamp wrote:
And what about 1.0-git (that's the version I'm talking about)? And which keyboard changes ever 1.0-beta may have, they will be in 1.0-git then anyway, right?
Right, the same with git-master. Works for me with Firefox 26 on Linux. Skin independent.
Ah - on Linux! That may of course very well make a difference (same applies to the splitter issue I mentioned). Different OS, different browser platform.
Can you try to reproduce on Win7 (32/64)?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 12/30/2013 08:13 PM, Michael Heydekamp wrote:
Can you try to reproduce on Win7 (32/64)?
Works for me on Win7. There's however one explanation. Are you using numeric keypad? I don't have it on my laptop.
That would explain the issue, because key codes 107 and 109 are still used for thread collapse/expand action. I suppose this is for backward compat., but because we support left/right arrow keys for the same function, I think we could remove Ctrl + +/- handling.
See line 1174-1175 of program/js/list.js file.
Am 01.01.2014 10:56, schrieb A.L.E.C:
On 12/30/2013 08:13 PM, Michael Heydekamp wrote:
Can you try to reproduce on Win7 (32/64)?
Works for me on Win7. There's however one explanation. Are you using numeric keypad? I don't have it on my laptop.
That's it! I did of course try with the num keys only, as I have them. Ctrl+- and Ctrl++ on the "normal" keyboard do indeed work all the time.
That would explain the issue, because key codes 107 and 109 are still used for thread collapse/expand action. I suppose this is for backward compat., but because we support left/right arrow keys for the same function, I think we could remove Ctrl + +/- handling.
That will indeed be the explanation. But it does still not explain why it does work in the first place then (even WITH the num keys). And it also doesn't explain why the problem doesn't appear in IE(10) at all.
So there seems to be some inconsistency anyway... Probably collapsing/expanding "action" (which action, BTW?) wouldn't work with IE then at all...?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 01/02/2014 10:07 PM, Michael Heydekamp wrote:
That will indeed be the explanation. But it does still not explain why it does work in the first place then (even WITH the num keys). And it also doesn't explain why the problem doesn't appear in IE(10) at all.
Keyboard is catched when the messages list has focus. I didn't check with IE, but does it use Ctrl +/- for zoom?
Am 03.01.2014 09:12, schrieb A.L.E.C:
On 01/02/2014 10:07 PM, Michael Heydekamp wrote:
That will indeed be the explanation. But it does still not explain why it does work in the first place then (even WITH the num keys). And it also doesn't explain why the problem doesn't appear in IE(10) at all.
Keyboard is catched when the messages list has focus. I didn't check with IE, but does it use Ctrl +/- for zoom?
Sure, it does.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
I just wanted to mention that this issue does still persist (and to make sure that it doesn't get forgotten). ;)
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 03.01.2014 18:01, schrieb Michael Heydekamp:
Am 03.01.2014 09:12, schrieb A.L.E.C:
On 01/02/2014 10:07 PM, Michael Heydekamp wrote:
That will indeed be the explanation. But it does still not explain why it does work in the first place then (even WITH the num keys). And it also doesn't explain why the problem doesn't appear in IE(10) at all.
Keyboard is catched when the messages list has focus. I didn't check with IE, but does it use Ctrl +/- for zoom?
Sure, it does.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
Thanks for silent fix! ;)
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 14.01.2014 00:45, schrieb Michael Heydekamp:
I just wanted to mention that this issue does still persist (and to make sure that it doesn't get forgotten). ;)
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 03.01.2014 18:01, schrieb Michael Heydekamp:
Am 03.01.2014 09:12, schrieb A.L.E.C:
On 01/02/2014 10:07 PM, Michael Heydekamp wrote:
That will indeed be the explanation. But it does still not explain why it does work in the first place then (even WITH the num keys). And it also doesn't explain why the problem doesn't appear in IE(10) at all.
Keyboard is catched when the messages list has focus. I didn't check with IE, but does it use Ctrl +/- for zoom?
Sure, it does.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
-
A.L.E.C -
Michael Heydekamp