Hi everybody
Those of you who keep track of the changesets may have notices that I created a branch to re-write the addressbook interface. I also made some code cleanup and moved some functions around. I'm sure that you gonna hate me for that but I think it's worth it :-)
The changeset is quite big so here's an overview what changed:
local address book. Another class with the same interface is on the way to handle the LDAP access.
which extends the rcube_html_page class. The global object $OUTPUT is now an instance of rcmail_template.
'$bar');"); with the more elegant $OUTPUT->set_env('foo', $bar); Now also conditional template objects can access the env vars.
been replaced by constans because they actually are constant values.
request process and created simple scripts in /bin/. These do not nead any user authentication or session values.
data. Changing application states with GET is against RFC and allows for CSRF vulnerabilities. e.g. if someone were to email an RC user with: <img src="?_task=addressbook&_action=delete&_cid=1&_from=&_remote=1"> Then a contact would be deleted.
Please check out the new branch from https://svn.roundcube.net/branches/devel-addressbook and test it. Don't replace an existing (productive) installation with it.
Comments about the changes and the new classes are welcome.
Regards, Thomas
Robin Elfrink wrote:
On 11-jan-2007, at 20:51, Thomas Bruederli wrote:
The changeset is quite big so here's an overview what changed:
Okay, these changes only apply to devel-addressbook, right?
Right but once you approved the changes and the new concept they are subject to be merged into the trunk.
~Thomas