Hi, all.
I use RC 0.1.1-stable, but the filename after download attachment with Chinese characters is incorrect, so i created this patch to fix this issue. (I submitted another patch to fix incorrect attachment filename display before, and was fixed in svn version in another way.)
Note: I havn't test this issue in RC svn version, but i will do it later.
Zhang Huangbin wrote:
Hi, all.
I use RC 0.1.1-stable, but the filename after download attachment with Chinese characters is incorrect, so i created this patch to fix this issue. (I submitted another patch to fix incorrect attachment filename display before, and was fixed in svn version in another way.)
Note: I havn't test this issue in RC svn version, but i will do it later.
In my previous tests, IE 7 worked without abbreviate_string() just fine. If abbreviate_string() is used, long filenames become truncated in the middle. Is it possible to not use abbreviate_string() for IE 7? I do not known if IE 6 works without using abbreviate_string().
Where does 55 char limit goes from? I have found some obscure ticket in the trac, but could not grasp the explanation for that change. Google did not help with magic number of 55, either. -- Dennis _______________________________________________ List info: http://lists.roundcube.net/dev/
On Wed, Dec 17, 2008 at 16:04, Zhang Huangbin zhbmaillistonly@gmail.com wrote:
Hi, all.
I use RC 0.1.1-stable, but the filename after download attachment with Chinese characters is incorrect, so i created this patch to fix this issue. (I submitted another patch to fix incorrect attachment filename display before, and was fixed in svn version in another way.)
Well, your patch does (almost) the same as we already have in http://trac.roundcube.net/browser/trunk/roundcubemail/program/steps/mail/get... (Line 92)
Note: I havn't test this issue in RC svn version, but i will do it later.
You should :-)
~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/
On Wed, Dec 17, 2008 at 17:38, Dennis P. Nikolaenko dennis@nikolaenko.ru wrote:
In my previous tests, IE 7 worked without abbreviate_string() just fine. If abbreviate_string() is used, long filenames become truncated in the middle. Is it possible to not use abbreviate_string() for IE 7? I do not known if IE 6 works without using abbreviate_string().
Sure, this should be possible. Can you confirm that long file names correctly work with IE 7?
Where does 55 char limit goes from? I have found some obscure ticket in the trac, but could not grasp the explanation for that change. Google did not help with magic number of 55, either.
See http://trac.roundcube.net/ticket/1484757
~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/
-
Dennis P. Nikolaenko -
Thomas Bruederli -
Zhang Huangbin