---------- Forwarded message ---------- From: Marcelo Salhab Brogliato msbrogli@gmail.com Date: Oct 27, 2007 1:32 PM Subject: Re: [RCD] Patch for new features To: till klimpong@gmail.com
Hello till,
I don't have svn installed in the shell that I'm working on.. but I already sent an email asking for instalation! Soon I'll send my first patch :))
About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this?
Thanks for your help Salhab
On 10/27/07, till <klimpong@gmail.com > wrote:
Hi Salhab,
no problem, but please CC the list, so others learn from this. :)
Basically the best way is the following:
- Get latest code from SVN (trunk)
- Migrate all your changes in there, test
- Create patches using "svn diff > feature.patch"
Till
On 10/27/07, Marcelo Salhab Brogliato msbrogli@gmail.com wrote:
Hi Till,
that's my first contribution to open source projects... I'm completelly
a
newbie! :)) How can I create a patch? I have no idea... I think it isn't just attaching the files that I changed.. Maybe a CHANGELIST? Or a little tutorial with the codes and where they should be inserted?
What do you mean by "configurable"? The name of the folders are fixed by now.. but a little change in the source make it user-defined :)
Thanks for your answer. Salhab
On 10/27/07, till klimpong@gmail.com wrote:
Hi Salhab,
On 10/27/07, Marcelo Salhab Brogliato < msbrogli@gmail.com> wrote:
Hi to everyone, I'm new to the list and working on RoundCube.. but I changed him a
little to
satisfy my needs. I implemented 3 features that you can check at: http://www.vialink.com.br/webmail4/ email: msbrogli2@vialink.com.br password: 123456
Essentially, it is:
- a checkbox at the left... to make the life of the ones who aren't
familiarized with AJAX (in my case, my customers) easier... so, they can easily select more than a message..
I thought there were discussions already and I don't think this will make its way into the source. The reason is - we aim to provide a desktop-like look and feel.I don't see checkboxes in Outlook, Eudora, Thunderbird or kMail.
- a droplist to move selected messages between the folders
- 2 buttons called SPAM and NO-SPAM.. they move the message to the
folders
Spam and No-Spam... but why? because I developed a script to periodically check that folders
and
train
spamassassin to work better...
Not a bad idea. Are the folders configurable? (I obviously haven't check your patch yet, because there was none attached. ;-)).
now I'm working on a preview window in the list page... like
Outlook..
just
click the message and see the content.. a double click maximize the message...
I think a preview pane is already included.
and my last modification (for now) will be a way to throw the
compose
page
add emails from contact list..
Not sure I understand.
In general, if you want to provide a patch, make sure to open tickets on our trac (0) and make sure to provide one patch per issue/feature -
not a giant patch.
sorry about my english... if i'm not clear, please ask!
Thanks for your work! Looking forward to your thoughts!
Till
List info: http://lists.roundcube.net/dev/
Marcelo Salhab Brogliato wrote:
About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this?
Ideally the address book shows up in a Thickbox as a layer above the mail, so there is no need to save the mail.
Mike
On 10/29/07, Michael Baierl mail@mbaierl.com wrote:
Marcelo Salhab Brogliato wrote:
About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this?
Ideally the address book shows up in a Thickbox as a layer above the mail, so there is no need to save the mail.
Good idea, though I am not sure if I want thickbox because this would add another dependency and thickbox is (apart from some CSS) not very customizable and we technically would need to re-customize it when we update it.
Not sure if it's hard to implement that yourself with jQuery (since that is what we'll be using in the future).
Till _______________________________________________ List info: http://lists.roundcube.net/dev/
It's probably easier to implement yourself, tailoring it to your needs than it is to try to hack thickbox to your will.
I had just such an instance on a project at work. There are a few issues to work around that may or may not even apply for RoundCube.
Scrolling: I'm sure this won't apply, but the site I implemented it on had very long pages. I had to make it appear on screen no matter the scroll position.
Backing Fade: In thickbox etc, there is a translucent grey covering over the rest of the page to make the popup modal. This can be tricky to position in all browsers. If you're just wanting to throw a popup without blacking the background out, no problem!
I think you could probably get away with a basic positioned div, using js to load in the address book for this app, but I'm no UI designer. :)
(Apologies to till if you receive this twice, first reply didn't go to list.)
On Mon, 29 Oct 2007 14:27:35 +0100, till klimpong@gmail.com wrote:
On 10/29/07, Michael Baierl mail@mbaierl.com wrote:
Marcelo Salhab Brogliato wrote:
About the last feature that I sad: Let's get a situation: you are on the compose page writing some
email..
so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in
the
draft)... Does you guys have a patch to solve this?
Ideally the address book shows up in a Thickbox as a layer above the mail, so there is no need to save the mail.
Good idea, though I am not sure if I want thickbox because this would add another dependency and thickbox is (apart from some CSS) not very customizable and we technically would need to re-customize it when we update it.
Not sure if it's hard to implement that yourself with jQuery (since that is what we'll be using in the future).
Till _______________________________________________ List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
till wrote:
Good idea, though I am not sure if I want thickbox because this would add another dependency and thickbox is (apart from some CSS) not very customizable and we technically would need to re-customize it when we update it.
Not sure if it's hard to implement that yourself with jQuery (since that is what we'll be using in the future).
Till
http://jquery.com/demo/thickbox/ is a jQuery extension, so if you start using jQuery you can also use all plugins availabe (i.e. dimensions, UI etc.). And on advice - never ever patch any upstream library, as you already said, any update is going to be hell. Fear it. :)
Mike
On 10/29/07, Michael Baierl mail@mbaierl.com wrote:
till wrote:
Good idea, though I am not sure if I want thickbox because this would add another dependency and thickbox is (apart from some CSS) not very customizable and we technically would need to re-customize it when we update it.
Not sure if it's hard to implement that yourself with jQuery (since that is what we'll be using in the future).
Till
http://jquery.com/demo/thickbox/ is a jQuery extension, so if you start using jQuery you can also use all plugins availabe (i.e. dimensions, UI etc.). And on advice - never ever patch any upstream library, as you already said, any update is going to be hell. Fear it. :)
Yeah, I know what Thickbox is. As I said, I don't think it's suitable because e.g. it lacks localization features and so on. So unless we try to adapt Thickbox and create a Thickbox-Roundcube from it, I'd say, start from scratch. ;-)
Till _______________________________________________ List info: http://lists.roundcube.net/dev/
Not sure if it's hard to implement that yourself with jQuery (since that is what we'll be using in the future).
Do you have an 'official' announcement of this, or something on a roadmap somewhere? _______________________________________________ List info: http://lists.roundcube.net/dev/
There are a number of thickbox type add-ons already written in jQuery which might be useful:
blockUI: http://jquery.com/plugins/project/blockUI jqModal: http://jquery.com/plugins/project/jqModal thickBox: http://jquery.com/demo/thickbox/
~ ~ David
till wrote:
On 10/29/07, Michael Baierl mail@mbaierl.com wrote:
Marcelo Salhab Brogliato wrote:
About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this?
Ideally the address book shows up in a Thickbox as a layer above the mail, so there is no need to save the mail.
Good idea, though I am not sure if I want thickbox because this would add another dependency and thickbox is (apart from some CSS) not very customizable and we technically would need to re-customize it when we update it.
Not sure if it's hard to implement that yourself with jQuery (since that is what we'll be using in the future).
Till _______________________________________________ List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
On 10/29/07, DaveG roundcube@solidgone.com wrote:
Not sure if it's hard to implement that yourself with jQuery (since that is what we'll be using in the future).
Do you have an 'official' announcement of this, or something on a roadmap somewhere?
An announcement that we'll use jQuery? Parts of devel-vnext already contain jQ-based code and in the next weeks we'll also revamp the rest to use jQuery.
We pretty much made this decision when we drafted out the first spec for the plugin API. http://trac.roundcube.net/wiki/Plugin_API_Draft
Till _______________________________________________ List info: http://lists.roundcube.net/dev/
On 10/29/07, DaveG roundcube@solidgone.com wrote:
There are a number of thickbox type add-ons already written in jQuery which might be useful:
blockUI: http://jquery.com/plugins/project/blockUI jqModal: http://jquery.com/plugins/project/jqModal thickBox: http://jquery.com/demo/thickbox/
For all reasons I already stated I am not in favour of adding another "project" to our pool of dependencies. But for example I haven't looked into blockUI or jqModal and can not comment on their implementation in terms of easy to read code, customizability, localization and so on, but the comments I made in regard to Thickbox apply I vote -1. ;-)
Till _______________________________________________ List info: http://lists.roundcube.net/dev/
-
DaveG -
Drarok Ithaqua -
Marcelo Salhab Brogliato -
Michael Baierl -
till