Heya,
I am writing a plugin that would filter out some folders from UW-IMAP folder list and I came across a bug (or a feature) for list_mailboxes plugin hook.
If you use list_mailboxes plugin hook, it only gets called when list_mailboxes function is called, but not when list_unsubscribed() function is called (which is quite similar function).
So, would it be better to add plugin hook to list_unsubscribed(() function as well, or leave the functionality as is.
In my case: listing mailboxes in settings view works fine, but it is not working fine in the settings.folder tab.
I have made a patch, which is working in my case, but I dont know, whether this is a totally working solution or not :)
regards, Jernej
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/3W/9jIZFQof/rc-imap.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Damn, reverse patch was sent before...
now, the right one is attached...
regards, Jernej
Jernej Porenta wrote:
Heya,
I am writing a plugin that would filter out some folders from UW-IMAP folder list and I came across a bug (or a feature) for list_mailboxes plugin hook.
If you use list_mailboxes plugin hook, it only gets called when list_mailboxes function is called, but not when list_unsubscribed() function is called (which is quite similar function).
So, would it be better to add plugin hook to list_unsubscribed(() function as well, or leave the functionality as is.
In my case: listing mailboxes in settings view works fine, but it is not working fine in the settings.folder tab.
I have made a patch, which is working in my case, but I dont know, whether this is a totally working solution or not :)
regards, Jernej
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/3W/9jIZFQof/rc-imap.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/jm/me84Vbwj/rc-imap.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Heya,
I found out that this approach, has some disadvantages like not working IMAP subscriptions :)
So, is there a way to make folder list in settings.folder tab editable in plugins or no?
regards, Jernej
Jernej Porenta wrote:
Damn, reverse patch was sent before...
now, the right one is attached...
regards, Jernej
Jernej Porenta wrote:
Heya,
I am writing a plugin that would filter out some folders from UW-IMAP folder list and I came across a bug (or a feature) for list_mailboxes plugin hook.
If you use list_mailboxes plugin hook, it only gets called when list_mailboxes function is called, but not when list_unsubscribed() function is called (which is quite similar function).
So, would it be better to add plugin hook to list_unsubscribed(() function as well, or leave the functionality as is.
In my case: listing mailboxes in settings view works fine, but it is not working fine in the settings.folder tab.
I have made a patch, which is working in my case, but I dont know, whether this is a totally working solution or not :)
regards, Jernej
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/3W/9jIZFQof/rc-imap.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/jm/me84Vbwj/rc-imap.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
-
Jernej Porenta