Here's the patch that was submitted on July 31st and added to 667. :)

-------- Original Message -------- Subject: [RCD] Attachment locking interface bug-patch (#1484496) I just submitted a bug to trac about downloading attachments that aren't of a correct mime type to spawn the window, ie the direct download, that causes the ui to lock up. (#1484496) Here is my patch to the solution from the latest svn checkout. It retains the original behavior of the redirect() function but adds in the lock that is sent to goto_url(). New to patches, so forgive if I did this improperly :) Patrick Date: Tue, 31 Jul 2007 15:30:12 -0600 From: Patrick Milvich patrick@milvich.com To: dev@lists.roundcube.net

I just submitted a bug to trac about downloading attachments that aren't of a correct mime type to spawn the window, ie the direct download, that causes the ui to lock up. (#1484496)

Here is my patch to the solution from the latest svn checkout. It retains the original behavior of the redirect() function but adds in the lock that is sent to goto_url().

New to patches, so please forgive if I did this improperly.

Patrick

Index: program/js/app.js

--- program/js/app.js (revision 657) +++ program/js/app.js (working copy) @@ -694,7 +694,7 @@ } }

•    this.goto_url('get', qstring+'&_download=1');
  

•    this.goto_url('get', qstring+'&_download=1', false);
      break;
  
    case 'select-all':
  

@@ -3187,9 +3187,10 @@ /********* remote request methods *********/ /********************************************************/

• this.redirect = function(url)

• this.redirect = function(url, lock) {

• this.set_busy(true);

• if (lock || lock == null)

•  this.set_busy(true);
  if (this.env.framed && window.parent)
    parent.location.href = url;
  else
  

@@ -3198,11 +3199,8 @@ this.goto_url = function(action, query, lock) {

• if (lock)
• this.set_busy(true);

• var querystring = query ? '&'+query : '';
  

• this.redirect(this.env.comm_path+'&_action='+action+querystring);

• this.redirect(this.env.comm_path+'&_action='+action+querystring,

lock); };

List info: http://lists.roundcube.net/dev/