On Mon, 23 Aug 2010 19:04:41 -0300, Carlos Pasqualini charly@setionline.com.ar wrote:

Hi!

i'm working on implementing the Last Password Change in the LDAP driver of the Password plugin

ho is working con this plugin?

do you recommend me to make some changes or to make a patch for ldap_simple.php too?

i've attached a patch to the ticket but have no answer yet. http://trac.roundcube.net/ticket/1486927

it would be great to have some guide

regards

Hello,

The difference between ldap driver and ldap_simple driver is the PEAR Net_LDAP2 class, which is require in the first one and not in the second.

I initialy coded the ldap driver and as i'm lazy i prefered use the pear class to handle multiple ldap server. Honnestly, i don't like the pear PEAR Net_LDAP2 class that much and i can understand that admins do not want to bother with it, specialy in large setups.

I think that having two pieces of code doing the same thing could be harder to maintain as any feature added in one need to be also done in the other. I was planning for recoding the original ldap driver to get rid of Net_LDAP2 but i can't find the time to do it properly (and add another feature that i need, multiple ldap password fields with different encodings). But Wout Decre was faster =)

Perhaps should we merge the two drivers in one, without the PEAR class, adding to ldap simple multiple LDAP servers support for those who need it (as it's the only feature that is not in ldap_simple driver).

Regards,

Edouard Moreau

List info: http://lists.roundcube.net/dev/ BT/aba52c80