Re: [RCD] [Svn] [roundcube/roundcubemail] 0f4c9b: check if the new password matched the requirements
Just wanted to confirm that the commit below appears to work (see screenshot attached). :)
Just one thing: Is there any way to keep those AJAX messages (or however they are called) on the screen until they have been "clicked away" (or confirmed with the Enter key) by the user? Especially in this case that would make most sense as it takes some time to read (and understand) the message, but it does appear on the screen for just 7 seconds or so.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 04.11.2013 17:53, schrieb GitHub:
Branch: refs/heads/master Home: https://github.com/roundcube/roundcubemail Commit: 0f4c9b850f665f0fdafb00809b4b9f100c59f331
https://github.com/roundcube/roundcubemail/commit/0f4c9b850f665f0fdafb00809b... Author: Till Krüss me@tillkruess.com Date: 2013-10-15 (Tue, 15 Oct 2013)
Changed paths: M plugins/password/drivers/domainfactory.php
Log Message:
check if the new password matched the requirements; code cleanup
Commit: 910a3581be47da1d19eb15a68ea6b51c2c31ef67
https://github.com/roundcube/roundcubemail/commit/910a3581be47da1d19eb15a68e... Author: Till Krüss me@tillkruess.com Date: 2013-10-15 (Tue, 15 Oct 2013)
Changed paths: M plugins/password/drivers/domainfactory.php
Log Message:
check if password was changed successfully, before looking for error messages
Commit: d4f27d90d57b62a833e643fa9e823d4a8aaa1dcf
https://github.com/roundcube/roundcubemail/commit/d4f27d90d57b62a833e643fa9e... Author: Aleksander Machniak alec@alec.pl Date: 2013-11-04 (Mon, 04 Nov 2013)
Changed paths: M plugins/password/drivers/domainfactory.php
Log Message:
Merge pull request #136 from tillkruess/extend-df-password-driver
Extend domainfactory password driver
Compare: https://github.com/roundcube/roundcubemail/compare/a8b004e8d8f0...d4f27d90d5...
Roundcube SVN commits mailing list svn@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/svn
On 11/07/2013 08:07 PM, Michael Heydekamp wrote:
Just one thing: Is there any way to keep those AJAX messages (or however they are called) on the screen until they have been "clicked away" (or confirmed with the Enter key) by the user? Especially in this case that would make most sense as it takes some time to read (and understand) the message, but it does appear on the screen for just 7 seconds or so.
Yes, default is 8 seconds. A solution maybe would be to calculate display time according to the message length. How about
display time = 8 + 4 * LENGTH/200
This however might not work for all languages, but should work for most of them.
Am 07.11.2013 20:21, schrieb A.L.E.C:
On 11/07/2013 08:07 PM, Michael Heydekamp wrote:
Just one thing: Is there any way to keep those AJAX messages (or however they are called) on the screen until they have been "clicked away" (or confirmed with the Enter key) by the user? Especially in this case that would make most sense as it takes some time to read (and understand) the message, but it does appear on the screen for just 7 seconds or so.
Yes, default is 8 seconds. A solution maybe would be to calculate display time according to the message length. How about
display time = 8 + 4 * LENGTH/200
Where LENGTH is what? Number of bytes, number of words (the latter would make more sense, IMO)...?
Anyway, would be an approach, sure.
But there is no chance to get a sort of message box with an OK button in cases like this?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 11/07/2013 08:29 PM, Michael Heydekamp wrote:
But there is no chance to get a sort of message box with an OK button in cases like this?
We have popup dialogs in Roundcube, but I think that's not the case to use it.
-
A.L.E.C -
Michael Heydekamp