oops, Sorry guys noticed a mistake in there, this has been updated in the newly attached patch

Cheers

Brendan Beveridge wrote:

Hi all,

attached is a patch to extend the address book fields

The patch works against stable and i ported it to svn Revision: 2754

There are 2 parts missing to finalise this patch which is: SQL/sqlite-upgrade.sql has not been modified to add the new columns localization/en_US/labels.inc was the only one updated with the new field names

Any questions let me know

Cheers Brendan

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/VS/ApNtuEI7/add_extended_address.diff Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/

Just as a devils advocate. What do things like home address fields do
for Roundcube? How will they be used? Just informational?

Also, one im really missing is a 'comment' type field. Something that
people can add that says something about this contact. Many of our
customers use that field in squirrelmail, and are missing this in RC.

Also, im still confused as to what 'Display Name' is supposed to be,
as opposed to First and Last name. Display name is a mandatory field
in the addressbook, which makes RC add this display name to all email
recipients if you use the addressbook. Why arent First/Last used there
instead?

To: Display Name user@domain.com

Cor

List info: http://lists.roundcube.net/dev/

On Jul 15, 2009, at 3:48 PM, A.L.E.C wrote:

Cor Bosman wrote:

...

Also, im still confused as to what 'Display Name' is supposed to be, as opposed to First and Last name. Display name is a mandatory field in the addressbook, which makes RC add this display name to all email recipients if you use the addressbook. Why arent First/Last used
there instead?

I know what it does :) But what are First/Last for? Just
informational? Also, why cant Display Name be empty? If you use the
addressbook to send email, it now always adds DN, while it shouldnt be
forced. You'd have to manually delete it if you dont want it. Only
email address should be mandatory right?

Regards,

Cor

List info: http://lists.roundcube.net/dev/

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi,

On 2009-07-15 21:40, Cor Bosman wrote:

Also, im still confused as to what 'Display Name' is supposed to be,
as opposed to First and Last name.

Automatically composing names is not trivial, once you take into account Chinese, for example. There, the family name comes first, and there is no separator (space) between Chinese characters. So while you would need something like "GivenNames FamilyName" for western names, you would need "FamilyNameGivenNames" for Chinese names, and who knows what other conventions there are in other languages...

So as long as you don't have flags like "reversed" and "no separator" or something like that next to each set of "Given name(s)" and "Family name", you need a "free text" field to enter the names as they should be displayed.

Patrick.

Key ID: 0x86E346D4 http://patrick-nagel.net/key.asc Fingerprint: 7745 E1BE FA8B FBAD 76AB 2BFC C981 E686 86E3 46D4

List info: http://lists.roundcube.net/dev/

Hey all,

attached is a new patch revision of the extended addressbook

This includes the following fields: 'work_number', 'home_number', 'fax_number', 'mobile_number', 'title', 'company', 'work_address', 'home_address', 'note'

As stated before the only things missing now is an sqlite-update script modification for adding the extra columns. Also the labels need to be added for all other languages except en_US

Cheers Brendan

Brendan Beveridge wrote:

I'm just about finished updating this patch to include "note" and "title" which should make the address book pretty complete for standard fields, i also noticed a couple of sql updates etc that were incorrect so those will be fixed in an updated patch as well

Cheers Brendan

Cor Bosman wrote:

...

Just as a devils advocate. What do things like home address fields do for Roundcube? How will they be used? Just informational?

Also, one im really missing is a 'comment' type field. Something that people can add that says something about this contact. Many of our customers use that field in squirrelmail, and are missing this in RC.

Also, im still confused as to what 'Display Name' is supposed to be, as opposed to First and Last name. Display name is a mandatory field in the addressbook, which makes RC add this display name to all email recipients if you use the addressbook. Why arent First/Last used there instead?

To: Display Name user@domain.com

Cor

---

List info: http://lists.roundcube.net/dev/

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/FS/3KD9wAEf/add_extended_address.diff Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/