Relative to the threading patches, a small bug was discovered as a result of the differences in the way a given message list <tr> was constructed in a message list. This difference was causing the subjects of selected and dragged messages to not display in the generated <div> that follows the mouse pointer while the messages are being dragged.
Upon inspection, I found that the code for making this happen wasn't very robust in terms of even very slight changes to the structure of a given
<td> within each message row. Here is a proposed patch that I believe rather simplifies it and should also make it tolerant of changes to the structure of reach <tr> and <td> in a message list, for example, as occurred with the threading patches. If follows this basic logic, which I believe should be fairly safe (unless some browser doesn't support node.textContent):
- Is obj.childNodes[i].nodeName = 'TD'
- AND is obj.childNodes[i].className = 'subject'
- At this point I'm satisfied we're looking at the subject <td>, so just
grab every bit of text contained within it.
http://code.nkinka.de/gitweb?p=roundcube.git;a=commitdiff;h=89320766d84786de...
Nathan _______________________________________________ List info: http://lists.roundcube.net/dev/
Nathan Kinkade wrote:
- Is obj.childNodes[i].nodeName = 'TD'
- AND is obj.childNodes[i].className = 'subject'
List widget is used in other places (e.g.addressbook) where subject column (class) not exists, so it will not work there, I think.
On Thu, 26 Mar 2009 07:59:51 +0100, "A.L.E.C" alec@alec.pl wrote:
Nathan Kinkade wrote:
- Is obj.childNodes[i].nodeName = 'TD'
- AND is obj.childNodes[i].className = 'subject'
List widget is used in other places (e.g.addressbook) where subject column (class) not exists, so it will not work there, I think.
This is part of the function drag_mouse_move in list.js. And there is a comment before the code in question that says "// get subjects of selectedd [sic] messages." That in combination with variables names like subject and subject_col gave me the impression that this code was only for selecting the subject names.
However, the following makes it work with selected address book names as well, though it's not clear to me what can be accomplished by dragging address book names anywhere. Best I could tell, dragging address book names is a no-op. Is there some functionality I'm missing?
http://code.nkinka.de/gitweb?p=roundcube.git;a=commitdiff;h=d2dae464e27d9bd4...
Nathan
List info: http://lists.roundcube.net/dev/
-
A.L.E.C -
Nathan Kinkade