In rcmail_print_body() we have:
if ($part->ctype_parameters['format'] != 'flowed') $body = wordwrap(trim($body), 80);
I'm not shure that we should wrap lines for displaying messages, maybe do this only when sending (composing) them?
I have a mail without format definition in header and Thunderbird didn't wrap the lines. Roundcube do wrapping and output is broken.
I think, when displaying a message we should have something like that
if( format == flowed) rewrap lines according to rfc2646 or do nothing elseif (wrap_new_mail_on_display_option == true) wrap lines else do nothing
On Apr 9, 2008, at 3:05 PM, Aleksander Machniak wrote:
I'm not shure that we should wrap lines for displaying messages, maybe do this only when sending (composing) them?
I agree. Wrapping to 8 columns was needed when the world was
monospaced displays and fixed width windows. With today's systems, it
often gets in the way, particularly with long URL's.
Scott Houchin
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/QK/D3HB3uzn/smime.p7s Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Aleksander Machniak wrote:
In rcmail_print_body() we have:
if ($part->ctype_parameters['format'] != 'flowed') $body = wordwrap(trim($body), 80);
I'm not shure that we should wrap lines for displaying messages, maybe do this only when sending (composing) them?
I have a mail without format definition in header and Thunderbird didn't wrap the lines. Roundcube do wrapping and output is broken.
I think, when displaying a message we should have something like that
if( format == flowed) rewrap lines according to rfc2646 or do nothing elseif (wrap_new_mail_on_display_option == true) wrap lines else do nothing
Ah, sorry for wrong subject. Format=flowed isn't a problem, problem is "to wrap or not to wrap". I think not to wrap in that case.
-
A.L.E.C -
Aleksander Machniak
-
Scott Houchin