Hi all, I've been getting this error (only on my inbox - apparently somebody sent me a message with a bad time parameter (empty))
Warning: strtotime() [function.strtotime]: Called with an empty time parameter. in /opt/web/devmail/roundcubemail/program/include/main.inc on line 896
the fix is really simple, but I don't have CVS commit access, so...
<originalCode lines 893-896> if (is_numeric($date)) $ts = $date; else $ts = strtotime($date);
</originalCode>
<replacementCode> if (is_numeric($date)) $ts = $date; else if (strlen($date)) $ts = strtotime($date); else $ts = ''; </replacementCode>
There are probably more elegant ways to do this, but it works.
HTH, j.
joshua wrote:
Hi all, I've been getting this error (only on my inbox - apparently somebody sent me a message with a bad time parameter (empty))
According to RFC 822 (http://www.faqs.org/rfcs/rfc822.html) paragraph A.3.1. states that the minimum required headers should provide a Date: header. If I telnet to an SMTP-server and talk SMTP to it, the SMTP-server will add the missing Date: header. So I don't think we should workaround these extremely rare cases caused by a really broken SMTP-server somewhere. But this is up to Thomas..
And please try to test something first with the latest CVS snapshot before spamming the mailinglist :)
Jasper
Warning: strtotime() [function.strtotime]: Called with an empty time parameter. in /opt/web/devmail/roundcubemail/program/include/main.inc on line 896
the fix is really simple, but I don't have CVS commit access, so...
<originalCode lines 893-896> if (is_numeric($date)) $ts = $date; else $ts = strtotime($date);
</originalCode>
<replacementCode> if (is_numeric($date)) $ts = $date; else if (strlen($date)) $ts = strtotime($date); else $ts = ''; </replacementCode>
There are probably more elegant ways to do this, but it works.
HTH, j.