Hi Raoul,
Thanks for the feedback. At least in svn, rcmail::get_instance()->config->get('imap_root') will return null if there is no imap_root configuration variable. So roundcube keeps on ticking.
I'm also uncomfortable using globals the way iloha uses $my_prefs. However, from what I could see, that's just how iloha works. It looks like a choice between using some undesirable global variable "action at a distance" or modifying the iloha's imap library. Modifying iloha wouldn't be hard, but it looks like developers have avoided putting roundcube configuration specific code into iloha so far.
Cheers, Ziba
ziba wrote:
I'm also uncomfortable using globals the way iloha uses $my_prefs. However, from what I could see, that's just how iloha works. It looks like a choice between using some undesirable global variable "action at a distance" or modifying the iloha's imap library. Modifying iloha wouldn't be hard, but it looks like developers have avoided putting roundcube configuration specific code into iloha so far.
for patching vendor branches, i can recommend svnbranch from clifford wolf. see [1] and [2]
i am using them and they are very handy to maintain a patchset as a seperate branch in svn :)
[1] http://www.clifford.at/papers/2008/advsvn/ [2] http://svn.clifford.at/tools/trunk/
ziba wrote:
Hi Raoul,
Thanks for the feedback. At least in svn, rcmail::get_instance()->config->get('imap_root') will return null if there is no imap_root configuration variable. So roundcube keeps on ticking.
so, as stated, this is because of roundcube 0.1.1 using a global $CONFIG array.
as far as i can tell, this patch works with courier-imap 3.0.8-4sarge5
cheers, raoul