Hi,
(cvs-20060205)
when using roundcube to reply to mailinglists etc. it mangles the msgid string. Roundcube removes the '<>' that are required for some mail clients. Example:
Message-ID: <43E71908.8000501@cornell.edu>
becomes included in the reply as:
In-Reply-To: 43E71908.8000501@cornell.edu
Taken from a real conversation.
Another thing that bugs me is that I can't do "select all" "delete" multiple times in the same folder - it seems to bring up the second page/50 items again over and over again. But this I already reported to the bugtracker ;^)
Cheers.
Auke
I hope this is correct now There was no header 'References', I fixed it too.
(http://www.ietf.org/rfc/rfc2822.txt)
The "In-Reply-To:" and "References:" fields are used when creating a reply to a message. They hold the message identifier of the original message and the message identifiers of other messages (for example, in the case of a reply to a message which was itself a reply). The "In-Reply-To:" field may be used to identify the message (or messages) to which the new message is a reply, while the "References:" field may be used to identify a "thread" of conversation.
When creating a reply to a message, the "In-Reply-To:" and "References:" fields of the resultant message are constructed as follows:
The "In-Reply-To:" field will contain the contents of the "Message- ID:" field of the message to which this one is a reply (the "parent message").
????????????????????????????????????????????????????????????????????????????
If there is more than one parent message, then the "In- Reply-To:" field will contain the contents of all of the parents' "Message-ID:" fields.
?????????????? I don't understand this part ????????????????????????????????
If there is no "Message-ID:" field in any of
the parent messages, then the new message will have no "In-Reply-To:" field.
sofar a écrit :
Hi,
(cvs-20060205)
when using roundcube to reply to mailinglists etc. it mangles the msgid string. Roundcube removes the '<>' that are required for some mail clients. Example:
Message-ID: <43E71908.8000501@cornell.edu>becomes included in the reply as:
In-Reply-To: 43E71908.8000501@cornell.eduTaken from a real conversation.
Another thing that bugs me is that I can't do "select all" "delete" multiple times in the same folder - it seems to bring up the second page/50 items again over and over again. But this I already reported to the bugtracker ;^)
Cheers.
Auke
diff -Naur roundcubemail/program/lib/imap.inc roundcubemail-ok/program/lib/imap.inc --- roundcubemail/program/lib/imap.inc 2006-02-05 17:14:36.000000000 +0100 +++ roundcubemail-ok/program/lib/imap.inc 2006-02-06 18:38:31.000000000 +0100 @@ -1208,7 +1208,7 @@
/* FETCH date,from,subject headers */
$key="fh".($c++);
$request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID)])\r\n";
$request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE)])\r\n"; if (!fputs($fp, $request)) return false; do{
@@ -1255,6 +1255,7 @@ $result[$id]->date = $headers["date"]; $result[$id]->timestamp = iil_StrToTime($headers["date"]); $result[$id]->from = $headers["from"];
$result[$id]->reference = $headers["reference"]; $result[$id]->to = str_replace("\n", " ", $headers["to"]); $result[$id]->subject = str_replace("\n", "", $headers["subject"]); $result[$id]->replyto = str_replace("\n", " ", $headers["reply-to"]);
@@ -1270,8 +1271,7 @@ $result[$id]->charset = $regs[1];
$messageID = $headers["message-id"];
if ($messageID) $messageID = substr(substr($messageID, 1), 0, strlen($messageID)-2);else $messageID = "mid:".$id;
if (!$messageID) "mid:".$id; $result[$id]->messageID = $messageID; } else {
diff -Naur roundcubemail/program/steps/mail/compose.inc roundcubemail-ok/program/steps/mail/compose.inc --- roundcubemail/program/steps/mail/compose.inc 2006-02-04 20:08:10.000000000 +0100 +++ roundcubemail-ok/program/steps/mail/compose.inc 2006-02-06 18:47:21.000000000 +0100 @@ -59,6 +59,9 @@ $REPLY_MESSAGE = &$MESSAGE; $_SESSION['compose']['reply_uid'] = $_GET['_reply_uid']; $_SESSION['compose']['reply_msgid'] = $REPLY_MESSAGE['headers']->messageID;
$_SESSION['compose']['reference'] = $REPLY_MESSAGE['headers']->reference;
$_SESSION['compose']['references'] .= ($REPLY_MESSAGE['headers']->reference!='')?' ':'';
$_SESSION['compose']['references'] .= $REPLY_MESSAGE['headers']->messageID;
if ($_GET['_all']) $REPLY_MESSAGE['reply_all'] = 1;
@@ -617,4 +620,4 @@
parse_template('compose'); -?> \ Pas de fin de ligne à la fin du fichier. +?> diff -Naur roundcubemail/program/steps/mail/sendmail.inc roundcubemail-ok/program/steps/mail/sendmail.inc --- roundcubemail/program/steps/mail/sendmail.inc 2006-02-05 17:14:56.000000000 +0100 +++ roundcubemail-ok/program/steps/mail/sendmail.inc 2006-02-06 18:47:09.000000000 +0100 @@ -126,6 +126,8 @@ if ($_SESSION['compose']['reply_msgid']) $headers['In-Reply-To'] = $_SESSION['compose']['reply_msgid'];
+if ($_SESSION['compose']['references'])
- $headers['References'] = $_SESSION['compose']['references'];
if ($_POST['_priority']) {
Hello everyone,
I've made some changes with the address book. I can now add how many phone numbers I want, add a picture of a contact and a small note about him. I'm cleaning the code atm to get it work better with Roundcube. I'm also planing to add some group sorting to contacts.
I'll give some code as soon as it's clean.
Here is a screenshot of what I have: http://www.teliance.net/addressbook.jpg
not sure why this is said but it suggests to me that you must combine all 'message-ID: ' fields into a single 'In-Reply-To: ' field as such:
message-ID: a@b.c message-ID: b@b.c
becomes:
In-Reply-To: a@b.c, b@b.c
the RFC leaves out whether it should be a comma-separated list or not.
Ok but :
Field Min number Max number Notes
message-id 0* 1 SHOULD be present - see 3.6.4
So I still dont understand...
Message sent to my personal address :
On Mon, 06 Feb 2006 19:09:28 +0100, "dc.ml@oxys.net" dc.ml@oxys.net wrote:
????????????????????????????????????????????????????????????????????????????
If there is more than one parent message, then the "In- Reply-To:" field will contain the contents of all of the parents' "Message-ID:" fields.
?????????????? I don't understand this part
????????????????????????????????
not sure why this is said but it suggests to me that you must combine all 'message-ID: ' fields into a single 'In-Reply-To: ' field as such:
If there is more than one parent message,
meaning, if the user selected -multiple- e-mail messages and then clicked the 'reply' button, all Message-ID's should be included in the (multi-message) reply
hth.
Auke
Hi,
Maybe you're right but with thunderbird for example, I can't answer more then 1 message at the same time. Same thing for roundcube, so it's not a problem at the moment.
PS: Next time can you answer at the mailing list and not to my personal address please, like that people can give opinions. Thank you.
sofar a écrit :
On Mon, 06 Feb 2006 19:35:49 +0100, "dc.ml@oxys.net" dc.ml@oxys.net wrote:
not sure why this is said but it suggests to me that you must combine all 'message-ID: ' fields into a single 'In-Reply-To: ' field as such:
message-ID: a@b.c message-ID: b@b.c
becomes:
In-Reply-To: a@b.c, b@b.c
the RFC leaves out whether it should be a comma-separated list or not.
Ok but :
Field Min number Max number Notes
message-id 0* 1 SHOULD be present - see 3.6.4
So I still dont understand...
ahh wait, I understand now:
it reads:
If there is more than one parent message,
meaning, if the user selected -multiple- e-mail messages and then clicked the 'reply' button, all Message-ID's should be included in the (multi-message) reply
hth.
Auke
On Mon, 06 Feb 2006 23:23:06 +0100, "dc.ml@oxys.net" dc.ml@oxys.net wrote:
PS: Next time can you answer at the mailing list and not to my personal address please, like that people can give opinions. Thank you.
No, I refuse to do this - and here is why:
The mailinglist administrator has set the list to _NOT_ set the reply-to header to the list address itself. This means that when I click on 'reply' I will assume that the list administrator doesn't want the reply to go to the list, but only the person who sent the e-mail address originally.
I run about 20 mailinglists in total and all of them are set to set the 'reply-to' header to the list address.
Obviously the mailinglist admin made a well-based decision when he set up the lists, so I respect that decision. I don't think it should be up to me as a poster to decide where and how replies are sent.
Auke
On 6 Feb 2006, at 22:32, sofar wrote:
Obviously the mailinglist admin made a well-based decision when he
set up the lists, so I respect that decision. I don't think it should be
up to me as a poster to decide where and how replies are sent.
That's the point of not setting the Reply-To: header to the list; the
poster has the option to either reply to the poster or reply to all.
Check out http://www.unicom.com/pw/reply-to-harmful.html for more
information.
Cheers, Craig -- Craig Webster | t: +44 (0)131 516 8595 | e: craig@xeriom.net Xeriom.NET | f: +44 (0)131 661 0689 | w: http://xeriom.net
On Mon, 6 Feb 2006 22:47:53 +0000, Craig Webster craig@xeriom.net wrote:
On 6 Feb 2006, at 22:32, sofar wrote:
Obviously the mailinglist admin made a well-based decision when he set up the lists, so I respect that decision. I don\'t think it should be up to me as a poster to decide where and how replies are sent.
That's the point of not setting the Reply-To: header to the list; the poster has the option to either reply to the poster or reply to all.
Check out http://www.unicom.com/pw/reply-to-harmful.html for more information.
well here's another thing that bothers me then:
in roundcube when I reply to a mailinglist post, I HAVE to remember to click 'reply-to-all'. (We can go into a discussion that this is silly as I don't want to reply to multiple people, because the mail came only from one address and was forwarded, hence it should go to either one of them, not just a random one)
If I don't clik 'reply-to-all' then I have no way to find out what the original mailinglist address was, because it's no longer displayed in one of the fields above the text you just typed. If I want to go back to the original mail, I have to close (save a draft - otherwise my text I typed is gone completely!) and retreive the mail address first. Then I can compose again, or hit reply-to-all, but like I said this is something that I don't do for any other mailinglist.
Oh yeah, BTW, the reply-er still has a choice of changing the addressees when the mailinglist sets the 'reply-to' header. It's called the "To:" field ("Recipient" in roundcube) and anyone can modify it.
Auke
but I'll skip that -
On 6 Feb 2006, at 23:02, sofar wrote:
well here's another thing that bothers me then:
in roundcube when I reply to a mailinglist post, I HAVE to remember to click 'reply-to-all'. (We can go into a discussion that this is
silly as I don't want to reply to multiple people, because the mail came
only from one address and was forwarded, hence it should go to either one of them, not just a random one)
The mail came from a user on a mailing list -- you're either replying
to all the people on that list or the sender of the mail to which you
are replying.
If I don't clik 'reply-to-all' then I have no way to find out
what the original mailinglist address was, because it's no longer displayed
in one of the fields above the text you just typed. If I want to go back
to the original mail, I have to close (save a draft - otherwise my text I
typed is gone completely!) and retreive the mail address first. Then I can compose again, or hit reply-to-all, but like I said this is something that I don't do for any other mailinglist.
Perhaps you could rephrase this as a feature request? Most mailing
lists should add a List-Post header which tells you where to send
addresses; it should be fairly trivial to add the code to look for
this and add a caution message for those users who are used to their
list admin munging reply-to headers.
Oh yeah, BTW, the reply-er still has a choice of changing the
addressees when the mailinglist sets the 'reply-to' header. It's called the
"To:" field ("Recipient" in roundcube) and anyone can modify it.
Hmm... So, if someone hits reply and gets the list as their To:
address then what? They have to save as draft, get the original
message, check the sender, then restore the draft and change the
address. This problem exists both ways and experienced list users are
used to it behaving the way it does. Note that this doesn't
necessarily make it any better, just more widely accepted as The
Right Thing.
Why not write a patch which makes RoundCube behave in your preferred
way, offer it for public download, and see how popular it is? Fame
and fortune no doubt await the author of this patch.
Good luck, Craig
ps you seem to be having no problem replying to the list now --
perhaps this problem has fixed itself?
--
Craig Webster | t: +44 (0)131 516 8595 | e: craig@xeriom.net
Xeriom.NET | f: +44 (0)131 661 0689 | w: http://xeriom.net
sofar wrote:
The mailinglist administrator has set the list to _NOT_ set the reply-to header to the list address itself.
Actually the list administrator has set the list to respect the authors wishes as to where replies should be directed. Not only that, he has arranged it so that when the author does not express a preference, the individual subscribers have the option of having a Reply-To: header field added.
I run about 20 mailinglists in total and all of them are set to set the 'reply-to' header to the list address.
As a mailing list administrator I would have hoped that you actually took the time to read the list welcome message. Quoting:
- To change your subscription preferences: Send a message with 'options'
in both subject and body to: dev+options@lists.roundcube.net and follow the link in the reply message. Available subscription options are:
- Set Reply-To: This will add a Reply-To: header field to the messages
you receive from the list, directing replies back to the list instead of the message originator. Messages with a Reply-To: header field already present will not have it replaced.
- Tag Subject: Add a [RoundCube Dev] tag to all Subject: header fields.
Some people find this useful to (automatically of visually) sort mailing list messages.
- Suspend Mailing: Stop sending list messages to this address. Use this
if you want to temporarily halt your subscription (like when going on holiday) or if you want to be able to post from several addresses without having list messages sent to all of them.
Bob (list administrator)
On Mon, 6 Feb 2006 23:27:02 +0000, Craig Webster craig@xeriom.net wrote:
Why not write a patch which makes RoundCube behave in your preferred way, offer it for public download, and see how popular it is? Fame and fortune no doubt await the author of this patch.
Thanks, but I already run a linux distribution - I have a huge stack of fame waiting to be processed on my desk ;^)
ps you seem to be having no problem replying to the list now -- perhaps this problem has fixed itself?
After having lost my drafts a few times my brain is now trained to hit 'reply-to-all' in roundcube threads. That and I managed to get my preferences changed for the list (which mailinglist manager is this anyway?)
Auke
Given the starred portion below, should I assume that people who
are explicitly setting the reply-to field (particularly when they set it to the content of the from field, rather than something else) actually want to get direct mail? I turned on the reply-to option, since most of the time I want to do reply to the list, and Pine does not offer a good method of only replying to the list. But, the message I just sent a minute ago, I still had the same problem, because phil set the reply-to header explicitly.
On Tue, 7 Feb 2006, B. Johannessen wrote:
Actually the list administrator has set the list to respect the authors wishes as to where replies should be directed. Not only that, he has arranged it so that when the author does not express a preference, the individual subscribers have the option of having a Reply-To: header field added. ...
- Set Reply-To: This will add a Reply-To: header field to the messages
you receive from the list, directing replies back to the list instead of the message originator.
Messages with a Reply-To: header field already present will not have it replaced.
Jon Daley wrote:
On Tue, 7 Feb 2006, B. Johannessen wrote:
Messages with a Reply-To: header field already present will not have it replaced.
Given the starred portion below, should I assume that people who are explicitly setting the reply-to field (particularly when they set it to the content of the from field, rather than something else) actually want to get direct mail?
Yes! Reply-To is optional and controlled by the author. In essence it's the author saying "If you reply to this message, please send your reply to this address". This is one reason I think it's a bad idea to add a Reply-To header fields to list messages, and a *REALLY* bad idea to replace Reply-To in such messages.
As en example, I've set Reply-To: bob@db.org for this message, as this has nothing to do with RoundCube development, and if I am to continue this discussion I'd rather do it off list.
Bob
Matthieu BONETTI wrote:
Hello everyone,
I've made some changes with the address book. I can now add how many phone numbers I want, add a picture of a contact and a small note about him. I'm cleaning the code atm to get it work better with Roundcube. I'm also planing to add some group sorting to contacts.
I'll give some code as soon as it's clean.
Here is a screenshot of what I have: http://www.teliance.net/addressbook.jpg
There's just one thing you forgot to blur on on that picture. :)
Cheers, Gavin
-
B. Johannessen -
Craig Webster -
dc.ml＠oxys.net -
Gavin Conway -
Jon Daley -
Matthieu BONETTI -
sofar