Hi,
I saw this ticket on trac, I know its assigned but I thought I would give a patch a shot, hope that's ok. If any one has done any work on it I would be happy to compare ideas.
http://trac.roundcube.net/ticket/1484272
The patch adds a number of different options: "top_posting": adds some new lines and puts the cursor above the original message when replying. "show_sig": 4 different options about when to automatically add a signature to a message: never, always, only new messages, only replies/forwards "sig_above": when replying or forwarding put the signature about the existing message "strip_existing_sig": this option was suggested on the ticket, don’t remove existing sig from the message when replying.
I have also added a new button on the compose screen toolbar, "Insert Signature" - does what it says on the tin.
The addition of these new options does not change the current behaviour of RC.
The signature above message stuff in the plain text editor is not prefect, may be some one has some ideas how to improve it. Also when inserting sig above message it will not add the "-- " i'm not sure if people want it there or not but I thought leaving it in might cause content to be lost when clients strip sigs.
Phil
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/PQ/bc4Poey3/signature.png http://detached.gigo.com/rc/PQ/bc4Poey3/rc_sig_above.r3030.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Phil Weir wrote:
The patch adds a number of different options: "top_posting": adds some new lines and puts the cursor above the original message when replying. "show_sig": 4 different options about when to automatically add a signature to a message: never, always, only new messages, only replies/forwards "sig_above": when replying or forwarding put the signature about the existing message "strip_existing_sig": this option was suggested on the ticket, don’t remove existing sig from the message when replying.
I have also added a new button on the compose screen toolbar, "Insert Signature" - does what it says on the tin.
So many options looks too complicated now. Can't we have just a "top posting mode" or sth? Let's see...
- "strip_existing_sig" was my suggestion, but now I think it is not
needed, we should just remove sigs only when "top postiong mode" is disabled. Top-posters are probably not interested in replied message content.
- "top_posting" behavior is related with "sig above", we don't need two
options.
"show_sig" option with "Insert signature" button is ok.
ps. I didn't seen the patch, so I'm talking only about the idea.
On Sat, 10 Oct 2009 18:11:29 +0200, "A.L.E.C" alec@alec.pl wrote:
So many options looks too complicated now. Can't we have just a "top posting mode" or sth? Let's see...
- "strip_existing_sig" was my suggestion, but now I think it is not
needed, we should just remove sigs only when "top postiong mode" is disabled. Top-posters are probably not interested in replied message content.
- "top_posting" behavior is related with "sig above", we don't need two
options.
"show_sig" option with "Insert signature" button is ok.
Yes there are alot of options. There seem to be a lot of ideas around about which options should be available. I think it would be good to keep the sig insertion options and also the button on the compose screen. I agree we could drop the "strip sig" option, and do it based on "top posting". I haven't seen that suggested anywhere accept on the ticket.
This is a topic which comes up a bit on the forum so I posted a link to the patch there and hopefully the people who use the function will give some feedback. _______________________________________________ List info: http://lists.roundcube.net/dev/
On Sat, 10 Oct 2009 17:42:13 +0100, Phil Weir roundcube@tehinterweb.co.uk wrote:
On Sat, 10 Oct 2009 18:11:29 +0200, "A.L.E.C" alec@alec.pl wrote:
So many options looks too complicated now. Can't we have just a "top posting mode" or sth? Let's see...
- "strip_existing_sig" was my suggestion, but now I think it is not
needed, we should just remove sigs only when "top postiong mode" is disabled. Top-posters are probably not interested in replied message content.
- "top_posting" behavior is related with "sig above", we don't need two
options.
"show_sig" option with "Insert signature" button is ok.
Attached is another version of the patch, this adds fewer new options, just 2: top_posting and show_sig. There are also a number of improvements and bug fixes for the "insert sig" button.
Phil
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/qP/tuHXQkQr/rc_sig_above2.r3030.patch http://detached.gigo.com/rc/qP/tuHXQkQr/signature.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Phil Weir wrote:
Attached is another version of the patch, this adds fewer new options, just 2: top_posting and show_sig. There are also a number of improvements and bug fixes for the "insert sig" button.
Here's my modification. It requires current trunk (there's a new signature icon). Few bugfixes, some code rewrite. If you guys want it in 0.3.1, please test it more.
A.L.E.C wrote:
Phil Weir wrote:
Attached is another version of the patch, this adds fewer new options, just 2: top_posting and show_sig. There are also a number of improvements and bug fixes for the "insert sig" button.
Here's my modification. It requires current trunk (there's a new signature icon). Few bugfixes, some code rewrite. If you guys want it in 0.3.1, please test it more.
Patch applied cleanly and seems to hold up OK under some light testing. Looks like you left a few debug alert() calls in there though.
Anything specifically you're looking for in terms of testing?
List info: http://lists.roundcube.net/dev/
Jim Pingle wrote:
Patch applied cleanly and seems to hold up OK under some light testing. Looks like you left a few debug alert() calls in there though.
Ah, yes. Remove them.
Anything specifically you're looking for in terms of testing?
Nothing special, just test and get me to know if something's not working as expected.
This patch (for cursor at top on reply) seems to work good, but can't apply it anymore to the latest svn...
can you merge it in now for everyone to test?
Thanks
On Mon, 19 Oct 2009 18:21:56 +0200, "A.L.E.C" alec@alec.pl wrote:
Jim Pingle wrote:
Patch applied cleanly and seems to hold up OK under some light testing. Looks like you left a few debug alert() calls in there though.
Ah, yes. Remove them.
Anything specifically you're looking for in terms of testing?
Nothing special, just test and get me to know if something's not working
as expected.
List info: http://lists.roundcube.net/dev/
S c o t t K r a m e r wrote:
This patch (for cursor at top on reply) seems to work good, but can't apply it anymore to the latest svn...
It has been working great for me on my test setup. I have tried several different combinations of settings and they all work as expected.
List info: http://lists.roundcube.net/dev/
Thanks for working on this and committing the patch. There are some people on the forum testing it and everything seems to be ok. One little thing though, when top posting is enabled and the sig is placed above the quoted text the -- seperator is still added. May be it should not be added with the sig_above option or a different seperator used instead.
Phil _______________________________________________ List info: http://lists.roundcube.net/dev/
-
A.L.E.C -
Jim Pingle -
Phil Weir -
S c o t t K r a m e r