Hi,
SVN 440 introduced a bug that prevents me from clicking the 'Save' button on the settings page. I found that on my system rc_substr uses mb_substr now, and somehow that causes following change in output of the HTML:
==================================== --- substr.html 2007-01-03 15:59:19.582425500 +0100 +++ mb_substr.html 2007-01-03 15:59:02.676391900 +0100 @@ -173,7 +173,8 @@
</script>
-<script type="text/javascript"> +</body> +</<script type="text/javascript"> <!--
if (window.call_init)
Now I have absolutely no experience with multibyte strings, so somebody else will have to figure out why mb_substr() causes to add '</body>' and one too many '</' to the HTML output.
Robin
Good job on figuring that out! I thought I was going crazy. It seemed to be interrupting more than just the save button. I'll update tonight and see if I can find any other issues.
On Wed, 03 Jan 2007 16:04:18 +0100, Robin Elfrink elfrink@introweb.nl wrote:
Hi,
SVN 440 introduced a bug that prevents me from clicking the 'Save' button on the settings page. I found that on my system rc_substr uses mb_substr now, and somehow that causes following change in output of the HTML:
==================================== --- substr.html 2007-01-03 15:59:19.582425500 +0100 +++ mb_substr.html 2007-01-03 15:59:02.676391900 +0100 @@ -173,7 +173,8 @@
</script>
-<script type="text/javascript"> +</body> +</<script type="text/javascript"> <!--
if (window.call_init)
Now I have absolutely no experience with multibyte strings, so somebody else will have to figure out why mb_substr() causes to add '</body>' and one too many '</' to the HTML output.
Robin
My fault. Mixed up multibyte substring functions with non-multibyte strrpos calls.
Fixed in rev. 445
~Thomas
Robin Elfrink wrote:
Hi,
SVN 440 introduced a bug that prevents me from clicking the 'Save' button on the settings page. I found that on my system rc_substr uses mb_substr now, and somehow that causes following change in output of the HTML:
==================================== --- substr.html 2007-01-03 15:59:19.582425500 +0100 +++ mb_substr.html 2007-01-03 15:59:02.676391900 +0100 @@ -173,7 +173,8 @@
</script>
-<script type="text/javascript"> +</body> +</<script type="text/javascript"> <!--
if (window.call_init)
Now I have absolutely no experience with multibyte strings, so somebody else will have to figure out why mb_substr() causes to add '</body>' and one too many '</' to the HTML output.
Robin
Thomas Bruederli wrote:
My fault. Mixed up multibyte substring functions with non-multibyte strrpos calls.
Fixed in rev. 445
Thank you.
I'll try to learn multibyte as well as locale thingies in the near future.
I'm from NL and have almost no need for umlauts and such, and always have my machines talk english to me, so this whole language stuff on computers went right past me :)
Robin
-
Matt Kaatman -
Robin Elfrink -
Thomas Bruederli