emi@algorismia.com wrote:

I've seen some discussion on why not to do it, if doing internally or with sieve or with .forward or so. Look, I've done this, then we can update to permit select the filtering system from configuration. From now, we have internal filters.

Emi, I don't want to put you down, but I don't think this makes sense. If Roundcube now implements client side filters this feature has to be supported 'til the end of days. And this means that they have to support a feature that does not work as expected, as it only filters on the client side....

Instead of spending time on implementing something that does not make sense nor is scaleable with a large amount of messages you should focus on -) Implementing the best filter UI ever -) Storing filter rules implementation independent in the database -) Writing scripts that transform the data into a filter language (i.e. Sieve, Maildrop, Procmail...)

That way the users can configure their scripts and the admin can setup a cron to pick them up and store them in the appropriate format in the appropriate place on the server. And if ever a new filter language comes out you can easily adopt Roundcube to use that system.

Please don't waste time on incomplete features!

My 2 cents,

Mike

Hi Michael!! Thanks for your comment!!! That's just my idea, but we should begin from somewhere 8^). I didn't know that you HAVE TO mantain all the beta-states of the program. If this is the case, well, I'll continue working on it until some improvements are done.

The UI is now in a good place. May be it'd be cool to do it with a drag'n'drop list for changing the order of filters. But I need some help here: I've spent some time discovering on how to do the other part, that's suposed to be easier.

I also think that'd be very good to use some kind of regexp instead of just strpos when looking for filter matches. Now, you pick messages fields like "Subject" or "From" from a select box, and then you insert the text that have to be searched on the selected field:

New filter

Field : [Subject | From | To | Header | ...] Contains: [****SPAM**** ] Move to : [Mailboxes select Box]

May be it can be a regular expression editor, as the one found on kwrite for searching with regular expressions. Or just let the user add different kind of searching widgets. Note: When I say a regular expression I mean something like "if subject contains '[RCD]' and from contains 'enemy_name'".

There are some other improvements I want to implement on the search engine: look for special features of the message, as seen/unseen, date/age, message-contains-images, size, etc.

And then, there is the 'Move To:' field. I thought that it can be great to let the user do thatever he wants:

• Move to a specific folder

• Copy to a specific folder

• Send a mail to some other email acount

• Reply some special answer

• More than one in a single filter

• ...

  Ok, it will be hard to implement it, and also to implement the Sieve or

Procmail part. I think that, depending on the server configuration, some of theme will be available and some not. But all of them are ideas that will made RoundCube really great!

And, for sure, if somebody wants to colaborate implementing it... hahahaha! what can I say? :^)

Well, comments are still welcome!

emi

El Mar, 13 de Noviembre de 2007, 18:33, Michael Baierl escribió:

emi@algorismia.com wrote:

...

I've seen some discussion on why not to do it, if doing internally or with sieve or with .forward or so. Look, I've done this, then we can update to permit select the filtering system from configuration. From now, we have internal filters.

Emi, I don't want to put you down, but I don't think this makes sense. If Roundcube now implements client side filters this feature has to be supported 'til the end of days. And this means that they have to support a feature that does not work as expected, as it only filters on the client side....

Instead of spending time on implementing something that does not make sense nor is scaleable with a large amount of messages you should focus on -) Implementing the best filter UI ever -) Storing filter rules implementation independent in the database -) Writing scripts that transform the data into a filter language (i.e. Sieve, Maildrop, Procmail...)

That way the users can configure their scripts and the admin can setup a cron to pick them up and store them in the appropriate format in the appropriate place on the server. And if ever a new filter language comes out you can easily adopt Roundcube to use that system.

Please don't waste time on incomplete features!

My 2 cents,

Mike

-- Michael Baierl mbaierl.com http://mbaierl.com/ - - - - - - - - - - - - - - - - - If you can dream it, you can do it! (Walt Disney) _______________________________________________ List info: http://lists.roundcube.net/dev/

List info: http://lists.roundcube.net/dev/

On Nov 13, 2007 5:07 PM, emi@algorismia.com wrote:

I think that this is a very earlier version and that can be much more developed. But it runs ok!

I don't want to comment the filter feature again. Let's see what you have done so far.

Well, my problem is that I don't know so much on using svn. If some one can tell me how can I 'upload' the work without disturbing anybody...

You can't upload anything to the SVN repository until we set the right privileges for you. But first we'd like to get a patch and see your code for reviewing it. Just type "svn diff" within the directory you checked out via SVN and where you have made the changes. Then save the diff and post it here or open a "patch" ticket at http://trac.roundcube.net

This is how it works. BTW I assume that you have read the http://trac.roundcube.net/wiki/Dev_Guidelines

Regards, Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/