Ralf Scholle wrote:
Brett Patterson schrieb:
Ralf Scholle wrote:
Hello,
i found 2 "problems" on the template:
first in main.inc.php i have this variables $rcmail_config['skin_path'] = ''; and $rcmail_config['product_name'] = '';
why didn't we use this at the templates??
for example in /templates/login.html the information is "Hardcoded" <img src="skins/default/images/roundcube_logo.png" id="rcmbtn104" width="165" height="55" border="0" alt="RoundCube Webmail" hspace="10" />
or in /includes/header.html <roundcube:button command="mail" image="/images/roundcube_logo.png" alt="RoundCube Webmail" width="165" height="55" />
i think id would be better when we could use the variables?!! What do you think??
cu Ralf
-- Sorry for my English :-/
___________________________________________________________ Der frühe Vogel fängt den Wurm. Hier gelangen Sie zum neuen Yahoo! Mail: http://mail.yahoo.de
The skin path just tells RC which skin to use. Within each subdirectory of the themes folder are self-contained themes. They're self contained meaning that they use their own images / layouts.
I personally like how it's done now. I don't see a reason for changing the theming system.
~Brett
Hey Brett,
sorry i write to you and not to the list but let me explain what i mean ...
my Question was why the variables from the config file are not in the theme?? I thought it could be better for example this way: <img src="<?php $rcmail_config['skin_path'] ?>/images/roundcube_logo.png" id="rcmbtn104" width="165" height="55" border="0" alt="<?php $rcmail_config['product_name'] ?>" hspace="10" />
instead of this way?? <img src="skins/default/images/roundcube_logo.png" id="rcmbtn104" width="165" height="55" border="0" alt="RoundCube Webmail" hspace="10" />
so everybody can change the variables in the config file and in the themes automaticaly changes the path ...
you understood??
cu Ralf
___________________________________________________________ Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de
I understand what you mean. But it's trivial the change you want to
do. Plus, on top of that, the themes are strict HTML. So there should
be no PHP code inside of it. If you look at every theme, it uses
Roundcube's Theme Engine (brilliant I might add) to properly parse
messages, folders, actions and such. No PHP code is to be contained in
the themes. What you're suggesting is the complete opposite of
abstraction. You want to put PHP code directly into the theme which.
The whole point of the template parser is to get the PHP out of the
theme so that non-PHP web designers can create a slick GUI for Roundcube.
So that being said, I understand what you're saying, but it goes against the whole point of abstraction and the MVC. I still am totally against making the change(s) you suggest about this.
~Brett
-
Brett Patterson