Hi!
There's a ticket http://trac.roundcube.net/ticket/1487001 So, when user uses empty password error to the log is printed.
I was thinking... Is any reason to do login when password is empty? In my opinion, we should just skip (IMAP) login process when password is not provided and return false from rcube_imap::connect() without printing an error to the log.
On Fri, Sep 17, 2010 at 11:43 AM, A.L.E.C alec@alec.pl wrote:
Hi!
There's a ticket http://trac.roundcube.net/ticket/1487001 So, when user uses empty password error to the log is printed.
I was thinking... Is any reason to do login when password is empty? In my opinion, we should just skip (IMAP) login process when password is not provided and return false from rcube_imap::connect() without printing an error to the log.
I agree, I see no real use case. However, a password could be spaces? :D
That would be funky.
Till _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80
On 17.09.2010 11:47, till wrote:
I was thinking... Is any reason to do login when password is empty? In my opinion, we should just skip (IMAP) login process when password is not provided and return false from rcube_imap::connect() without printing an error to the log.
I agree, I see no real use case. However, a password could be spaces? :D
Forget. Currently rcube_imap_generic doesn't connect to IMAP host when password is empty, so we just need to skip the logging of such errors. Fixed in r3972.
-
A.L.E.C -
till