Mark Little wrote:

...

...

I have a test RC folder that I updated to 3022 and then applied your patch cleanly [1]. However it doesn't appear to be working for me..

Did you try to enable per-folder threading in a Folders tab of a settings?

Ah - I didn't even realize it was an option under Folders. Very cool.

Not as cool as it is intended to be... It should be easily locateable. I think it should be in some place in a messagelist widget. And this would be more natural too, because one may want to switch between threaded and plain views in a one click, just because fresh reply to an old thread could appear somewhere where nobody can find it (on a third page f.e.)...

This is still to be discussed with devs. So I'm CC'ing to dev list just not to repeat myself.

...

They should be visible only if threading is supported and enabled for folder. But subject in a message-list should be moved a bit to right in this case to leave a space for expand/collapse icons... It isn't in your

case...

In my root inbox I don't have threading enabled because generally thats for individual emails, and any mailing lists I am on have their own folder.

I enabled the threading for some mailing lists and it looks to be working

That's OK.

great on all the threaded folders, however I am still experiencing problems on non-threaded folders.

Hmm, everything works for me on such folders... Would you please describe problems a bit more detailed? If you simply mean that two states of a three-state switch look identically while third shown things in reverse, then it is OK.

And, I seen thread controls on your previous screenshots. Are they still there for a non-threaded view? They should be hidden for thread-unaware folders...

From what I can tell - the new sort option doesn't appear to have any effect? Also, no matter what I do, the sorting doesn't change when threading is disabled for a folder.

It's original function was to present 'unsorted' view. It seems to be superseded by last changes in trunk. I didn't realized that while porting to the newest version. This issue is being discussed at dev list right now by the original patch author (Chris January) and RC core devs (I'm only porting it to current SVN from time to time and adding some fixes, bells and whistles ;) , changes set is available in my posts to dev list). And I hope this issue will be resolved before merging to trunk which I in turn hope will occur soon.

Do you still want me to do the debug? Do you want me to do it a couple of times or just ones? Let me know what options/sorting mode you want.

No, if it all works except for what I wrote above. Thank you.

Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/