Hello devs and early adopters
We're proud to announce that a frequently requested feature finally has been implemented: cross-folder searching as requested in http://trac.roundcube.net/ticket/1485234
The basic functionality is now available in git master and you're all invited to test it. The search "scope" can be changed in the options menu that resides in the search box. Please report issues to our bug tracker or provide pull requests if you're eager to fix things yourself.
After all it was quite a huge change in Roundcube's core because the way messages are referenced had to be refactored. Thus it likely breaks plugins which operate on message list selections. The Roundcube codebase offers a utility function to process a set of messages residing in multiple folders. Please use the following loop where you initially use _mbox and _uid request parameters:
foreach (rcmail::get_uids() as $mbox => $uids) { // do stuff here }
Thanks for testing!
~Thomas
Besides this particular feature, which is most appreciated, I realized some other changes in the search function which I wanted to discuss already days/weeks ago, but I didn't find the time yet to do so. So I take this opportunity:
- When I do a search in the INBOX for the "From:" header and afterwards
select the Sent folder, the same search will be applied to this Sent folder. Of course, no (or almost no) messages will be displayed.
Is this intentional? At least it doesn't make much sense to me, can this behaviour be disabled...?
- The same applies to a text search in the body, which takes a long time
here anyway. Also this doesn't make too much sense to me, that the body search in one folder will be applied again after selecting another folder. And, BTW: How can I cancel a text search at all (except reloading the web page by pressing F5)?
- Is there any hope to initiate a search in the header of the messages
only...?
Sorry if I should have missed a discussion about this new design.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 18.04.2014 17:05, schrieb Thomas Bruederli:
Hello devs and early adopters
We're proud to announce that a frequently requested feature finally has been implemented: cross-folder searching as requested in http://trac.roundcube.net/ticket/1485234
The basic functionality is now available in git master and you're all invited to test it. The search "scope" can be changed in the options menu that resides in the search box. Please report issues to our bug tracker or provide pull requests if you're eager to fix things yourself.
After all it was quite a huge change in Roundcube's core because the way messages are referenced had to be refactored. Thus it likely breaks plugins which operate on message list selections. The Roundcube codebase offers a utility function to process a set of messages residing in multiple folders. Please use the following loop where you initially use _mbox and _uid request parameters:
foreach (rcmail::get_uids() as $mbox => $uids) { // do stuff here }
Thanks for testing!
~Thomas _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On Sun, Apr 20, 2014 at 12:10 AM, Michael Heydekamp listuser@freexp.de wrote:
Besides this particular feature, which is most appreciated, I realized some other changes in the search function which I wanted to discuss already days/weeks ago, but I didn't find the time yet to do so. So I take this opportunity:
- When I do a search in the INBOX for the "From:" header and afterwards
select the Sent folder, the same search will be applied to this Sent folder. Of course, no (or almost no) messages will be displayed.
Is this intentional? At least it doesn't make much sense to me, can this behaviour be disabled...?
Yes, this is intentional. Beside that many other mail clients re-initiate the search when changing the folder instead of resetting it, the main reason for the change in Roundcube is to create the ability to refine your results (from a multi-folder search) to a certain folder and its subfolders.
I agree that for certain searches (like your example wit From:) it doesn't make too much sense but still I believe it's a useful change. Currently you can't disable it and I don't think a permanent setting would satisfy the different uses cases anyway. Sometimes you want it and sometime you don't. But maybe we can find a better way to make this "re-search in another folder" function more explicit. Suggestions?
- The same applies to a text search in the body, which takes a long time
here anyway. Also this doesn't make too much sense to me, that the body search in one folder will be applied again after selecting another folder.
For body text searches this makes even more sense to me.
And, BTW: How can I cancel a text search at all (except reloading the web page by pressing F5)?
You're right, there's currently no way to abort ongoing searches. We'll figure something our here.
- Is there any hope to initiate a search in the header of the messages
only...?
Maybe there is. But I guess there are some more details to be taken into account and I'd like to keep that out of this particular thread in order to remain on the cross-folder topic.
Thanks for your feedback!
~Thomas
On Mon, Apr 21, 2014 at 4:25 PM, Thomas Bruederli thomas@roundcube.net wrote:
And, BTW: How can I cancel a text search at all (except reloading the web page by pressing F5)?
You're right, there's currently no way to abort ongoing searches.
Small correction about this: you can cancel a running search query by resetting the search (click the x icon on the right side in the search box). This will properly abort the HTTP request and restore the previous listing.
~Thomas
On 04/23/2014 01:30 PM, Thomas Bruederli wrote:
Small correction about this: you can cancel a running search query by resetting the search (click the x icon on the right side in the search box). This will properly abort the HTTP request and restore the previous listing.
This however does not abort the searching on server. I'm not sure we could use connection_aborted() to at least break the loop over folders.
http://php.net/manual/en/function.connection-aborted.php
On Wed, Apr 23, 2014 at 1:44 PM, A.L.E.C alec@alec.pl wrote:
On 04/23/2014 01:30 PM, Thomas Bruederli wrote:
Small correction about this: you can cancel a running search query by resetting the search (click the x icon on the right side in the search box). This will properly abort the HTTP request and restore the previous listing.
This however does not abort the searching on server. I'm not sure we could use connection_aborted() to at least break the loop over folders.
Interesting point. Actually PHP should already abort the process unless ignore_user_abort is set. Strangely, when an XMLHTTPRequest is aborted, connection_aborted() still returns false. Either the browser doesn't actually close the connection or the disconnect is not forwarded to PHP. This needs further investigation... but it seems like we're not the only ones experiencing this: http://stackoverflow.com/questions/16785472/php-apache-doesnt-stop-on-xhr-ab...
~Thomas
Am 23.04.2014 13:30, schrieb Thomas Bruederli:
On Mon, Apr 21, 2014 at 4:25 PM, Thomas Bruederli thomas@roundcube.net wrote:
And, BTW: How can I cancel a text search at all (except reloading the web page by pressing F5)?
You're right, there's currently no way to abort ongoing searches.
Small correction about this: you can cancel a running search query by resetting the search (click the x icon on the right side in the search box). This will properly abort the HTTP request and restore the previous listing.
Thanks, but I beg to differ - just had this daily-life situation again:
- Did a search in the Sent folder for messages that I had sent to one of my
friends (looking for the To: header, of course).
- A while later, I saw that new messages have arrived in the Roundcube SVN
list, so I clicked on that particular folder.
- That's what I don't like: The same search is applied to that folder,
although there can't be any messages in this folder that I have sent to this (or any other) friend of mine.
- I can click on the "x" icon as many times I want, but nothing happens,
the search is continuing. Have to press the <F5> key to stop it.
Replicable...?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
OSX Mail does not seem to work this way. If I switch folders, the search gets reset. What mail clients work this way?
Im not sure it really makes sense to me. If im in a specific folder to search for something, i would probably not want to search for the same thing in another folder.
Cor
The best behaviour, imo, is having the search query bound to a folder. So, if I leave focus on another folder, the search is not applied. If I return to the original folder, the search & results are restored.
Another way to handle search is how Thunderbird does it. Each search/results opens in it's own tab. From there you can drill down on a timeline to pinpoints the email you're looking for, like such (note, the time-line is above a paged list of email below it that correspond to the time-frame of the search):
[image: Inline image 1]
On Wed, Apr 23, 2014 at 3:53 PM, Cor Bosman cor@xs4all.nl wrote:
OSX Mail does not seem to work this way. If I switch folders, the search gets reset. What mail clients work this way?
Im not sure it really makes sense to me. If im in a specific folder to search for something, i would probably not want to search for the same thing in another folder.
Cor
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On Wed, Apr 23, 2014 at 9:53 PM, Cor Bosman cor@xs4all.nl wrote:
OSX Mail does not seem to work this way. If I switch folders, the search gets reset. What mail clients work this way?
Postbox, a Thunderbird clone, does and I remember Thunderbird itself behaving this way in earlier versions. But I admit that's a minority and somehow fooled my perception.
Im not sure it really makes sense to me. If im in a specific folder to search for something, i would probably not want to search for the same thing in another folder.
Although I could come up with some other real-life scenarios that would support my opinion as opposed to the one Michael described, I agree to revert that behavioral change if you guys think this is wrong.
~Thomas
Hi,
maybe i could be configurable, if and with which objects (to, from, subject, body, complete massage) the search should start after changing to folder ... only an idea.
cu Claus
Am 23.04.2014 um 23:02 schrieb Thomas Bruederli thomas@roundcube.net:
On Wed, Apr 23, 2014 at 9:53 PM, Cor Bosman cor@xs4all.nl wrote: OSX Mail does not seem to work this way. If I switch folders, the search gets reset. What mail clients work this way?
Postbox, a Thunderbird clone, does and I remember Thunderbird itself behaving this way in earlier versions. But I admit that's a minority and somehow fooled my perception.
Im not sure it really makes sense to me. If im in a specific folder to search for something, i would probably not want to search for the same thing in another folder.
Although I could come up with some other real-life scenarios that would support my opinion as opposed to the one Michael described, I agree to revert that behavioral change if you guys think this is wrong.
~Thomas _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
Am 23.04.2014 23:02, schrieb Thomas Bruederli:
Although I could come up with some other real-life scenarios that would support my opinion as opposed to the one Michael described, I agree to revert that behavioral change if you guys think this is wrong.
I'd like to stress that the main issue of my latest message was that the search can't be stopped by clicking on the "x" icon right next to the input field after selecting another folder.
As to the cross-folder searching feature itself, it does make sense e.g. to search all subfolders, so I'm not saying that the cross-folder search options (and their functionality) should be dropped.
But when clicking on a different folder after having accomplished a search, the search scope should be reset to nil.
We need to make sure that we don't mix up the cross-folder functionality with the current behaviour that a search in a specific folder (or in its subfolders or even in all folders) gets applied to the folder that has been selected afterwards.
And as John Manko said: Presenting the search result in a new window would be just great. I just have no idea if that is possible at all, may be too much to ask for...
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 04/24/2014 12:29 AM, Michael Heydekamp wrote:
I'd like to stress that the main issue of my latest message was that the search can't be stopped by clicking on the "x" icon right next to the input field after selecting another folder.
Works for me. What browser? Did you try with different?
On 04/24/2014 08:27 AM, A.L.E.C wrote:
On 04/24/2014 12:29 AM, Michael Heydekamp wrote:
I'd like to stress that the main issue of my latest message was that the search can't be stopped by clicking on the "x" icon right next to the input field after selecting another folder.
Works for me. What browser? Did you try with different?
Ah, and make sure you are on recent git-master. The possibility to reset search was enabled by this commit https://github.com/roundcube/roundcubemail/commit/d2e3a22d24190c02741e8a67ff...
Am 24.04.2014 08:29, schrieb A.L.E.C:
On 04/24/2014 08:27 AM, A.L.E.C wrote:
On 04/24/2014 12:29 AM, Michael Heydekamp wrote:
I'd like to stress that the main issue of my latest message was that the search can't be stopped by clicking on the "x" icon right next to the input field after selecting another folder.
Works for me. What browser? Did you try with different?
FF 27.0 with Win7/64. Tried with that one only.
Ah, and make sure you are on recent git-master. The possibility to reset search was enabled by this commit https://github.com/roundcube/roundcubemail/commit/d2e3a22d24190c02741e8a67ff...
We're doing a git-pull every night at 21h10, and as this commit was five days ago, that shouldn't be an issue at all.
But yesterday and today we realized some issues with the contextmenu plugin which I'll describe later in another message, most likely there are some javascript interferences.
Now, with contextmenu of 21.04.2014 in git-master, the result of a search for the To: header after selecting a different folder (= no messages found) comes that quick that I don't even have the chance anymore to test the click on the "x" button.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 23-04-14 23:02, Thomas Bruederli wrote:
On Wed, Apr 23, 2014 at 9:53 PM, Cor Bosman cor@xs4all.nl wrote:
OSX Mail does not seem to work this way. If I switch folders, the search gets reset. What mail clients work this way?
Postbox, a Thunderbird clone, does and I remember Thunderbird itself behaving this way in earlier versions. But I admit that's a minority and somehow fooled my perception.
The Windows client of Novell GroupWise behaves the same. When you switch to another folder and your search filter yields no results, it asks you whether you want to clear the filter.
In practice, when I use this function in GroupWise, I reset the search filter >99% of the time.
Geert
On 04/23/2014 11:02 PM, Thomas Bruederli wrote:
Although I could come up with some other real-life scenarios that would support my opinion as opposed to the one Michael described, I agree to revert that behavioral change if you guys think this is wrong.
Yeah. Let's revert that. In recent version of Thunderbird search filter is reset when switching folders.
However in Thunderbird we have two methods of searching.
- Search filter which is folder-based (works on single folder and is
reset when switching folders) 2. Global search, which is open in a new tab and searches in all folders.
Maybe some day we will implement global search in new window/tab, but today we should just reset search when switching folders.
-
A.L.E.C -
Claus Wanner -
Cor Bosman -
Geert Wirken -
John Manko -
Michael Heydekamp -
Thomas Bruederli