Hi,
Attached patch saves search_mods checkbox settings in the preferences database.
Since this changes UI behaviour, I won't commit without feedback. So, please, shoot.
Robin
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Ys/1v66zSLU/save_search_mods.200.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Robin Elfrink wrote:
Attached patch saves search_mods checkbox settings in the preferences database.
Since this changes UI behaviour, I won't commit without feedback. So, please, shoot.
preg_split('/,/', $RCMAIL->config->get('search_mods'), -1, PREG_SPLIT_NO_EMPTY)
Why not just explode()?
A.L.E.C wrote:
preg_split('/,/', $RCMAIL->config->get('search_mods'), -1, PREG_SPLIT_NO_EMPTY)
Why not just explode()?
Because I need PREG_SPLIT_NO_EMPTY.
That may be a result of the search_mods value in the database containing a comma at the end, but an empty value causes JS errors so I'd rather make sure it doesn't happen. Think of it as a sort of value-validation :)
Robin
List info: http://lists.roundcube.net/dev/
-
A.L.E.C -
Robin Elfrink