Hello to all, I found many bugs in the gpg encryption module. The only working thing was with a plain mail. Attachments would block the parsing and display of the email.
I modified many points in enigma_engine.php and now everything works as expected (tested with text plain, text plain + attachments, html, html with attachments email). I even added self-signing and private key export, but I don't advise to use them, as they should be further refined. The only thing I did not implement is about signature for non text plain emails (but the signature needs to be removed for non text plain emails to be decrypted correctly).
I would like to contribute my fixes. Can somebody check them, or tell me how to do?
Thanks
On 01/14/2016 08:17 PM, Devoted Mystic wrote:
I modified many points in enigma_engine.php and now everything works as expected (tested with text plain, text plain + attachments, html, html with attachments email).
Last time I checked all of this worked ;)
I even added self-signing and private key export, but I don't advise to use them, as they should be further refined. The only thing I did not implement is about signature for non text plain emails (but the signature needs to be removed for non text plain emails to be decrypted correctly).
I would like to contribute my fixes. Can somebody check them, or tell me how to do?
Best way is to create a pull request(s) on github. Would be nice to have a separate PR for every issue/feature separately to make the review/acceptance process simpler.
https://help.github.com/articles/using-pull-requests/ https://github.com/roundcube/roundcubemail
I did 1 pull request with 3 commits. I don't know how to split the 3 commits into 3 pull requests. Not sure if I did it right. Can you see it?
On Thu, Jan 14, 2016 at 8:32 PM, A.L.E.C alec@alec.pl wrote:
On 01/14/2016 08:17 PM, Devoted Mystic wrote:
I modified many points in enigma_engine.php and now everything works as expected (tested with text plain, text plain + attachments, html, html with attachments email).
Last time I checked all of this worked ;)
I even added self-signing and private key export, but I don't advise to use them, as they should be further refined. The only thing I did not implement is about signature for non text plain emails (but the signature needs to be removed for non text plain emails to be decrypted correctly).
I would like to contribute my fixes. Can somebody check them, or tell me how to do?
Best way is to create a pull request(s) on github. Would be nice to have a separate PR for every issue/feature separately to make the review/acceptance process simpler.
https://help.github.com/articles/using-pull-requests/ https://github.com/roundcube/roundcubemail
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On 01/17/2016 12:53 PM, devotedmystic . wrote:
I did 1 pull request with 3 commits. I don't know how to split the 3 commits into 3 pull requests. Not sure if I did it right. Can you see it?
You have to create a separate branch for each change in your repository to do separate PRs.
I see your PR. I don't fully understand it. Could you provide sample messages (or their structure) that do not work with current code?
I need some time to build all the tests again.
Anyway, if you send an encrypted message to yourself, you will see that only a plain text message without attachments works (do the test with signature included). You see the green squared message that it was decrypted, and the decrypted text.
Any other combination (html, attachments) fails to decrypt and you get a blank page.
The main issue with parsing the correct content type is the "^" character, which failed on my system. Maybe, Debian systems expect just a "\n" and instead the files also contain "\r". There is no issue removing the "^" and all works.
The issue with attachments is that the wrong (incomplete) mime_id was passed. Thus, decryption hung and you saw again the blank page. That's why I updated with the "1.2" value, which is the usual position of the text when there are attachments, and all worked. I saw this printing the structure of the message and comparing it to a text plain email without attachment.
Last, if the message contained a signature, it displayed the usual blank page again, because Roundcube parser does not take into account signatures. So you need to remove it from the body before passing it to Roundcube functions.
That's it.
Further issues that I did not fix:
-When you send something different from a non text plain message without attachments, but with a signature, even before you are asked to enter the password you get a yellow message of failed signature because of wrong password. Obviously, the call to the signature function is done before asking for the password, in the wrong place. -The signature is not verified/managed in case of html messages or messages without attachments (must be implemented). -As it happens in mailvelope, I would expect to see a downloadable signature as an attachment in Roundcube display. Currently, aside saying that the signature was verified in text plain messages without attachments, it is not possible to see/download the signature.
On Mon, Jan 18, 2016 at 9:14 AM, A.L.E.C alec@alec.pl wrote:
On 01/17/2016 12:53 PM, devotedmystic . wrote:
I did 1 pull request with 3 commits. I don't know how to split the 3 commits into 3 pull requests. Not sure if I did it right. Can you see it?
You have to create a separate branch for each change in your repository to do separate PRs.
I see your PR. I don't fully understand it. Could you provide sample messages (or their structure) that do not work with current code?
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On 01/18/2016 10:18 AM, devotedmystic . wrote:
Anyway, if you send an encrypted message to yourself, you will see that only a plain text message without attachments works (do the test with signature included). You see the green squared message that it was decrypted, and the decrypted text.
Any other combination (html, attachments) fails to decrypt and you get a blank page.
The main issue with parsing the correct content type is the "^" character, which failed on my system. Maybe, Debian systems expect just a "\n" and instead the files also contain "\r". There is no issue removing the "^" and all works.
The issue with attachments is that the wrong (incomplete) mime_id was passed. Thus, decryption hung and you saw again the blank page. That's why I updated with the "1.2" value, which is the usual position of the text when there are attachments, and all worked. I saw this printing the structure of the message and comparing it to a text plain email without attachment.
Last, if the message contained a signature, it displayed the usual blank page again, because Roundcube parser does not take into account signatures. So you need to remove it from the body before passing it to Roundcube functions.
As I've said before, all of this works for me. That why I need message samples.
Ok. Here are some examples.
- Html message without attachments, with signature
[image: Inline image 1]
After my signature fix (removing the signature from the body):
[image: Inline image 2] Decrypted message:
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=_0c385807db1dba6581d6bbd4722d8e94"--=_0c385807db1dba6581d6bbd4722d8e94Content-Type: multipart/alternative; boundary="=_0c385807db1dba6581d6bbd4722d8e94"--=_0c385807db1dba6581d6bbd4722d8e94Content-Transfer-Encoding: 7bitContent-Type: text/plain; charset=US-ASCIIasd asd asd asasd--=_0c385807db1dba6581d6bbd4722d8e94Content-Transfer-Encoding: quoted-printableContent-Type: text/html; charset=UTF-8<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset==3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen=eva,sans-serif'><p>asd</p><p>asd</p><p>asd</p><p>asasd</p></body></html>--=_0c385807db1dba6581d6bbd4722d8e94----=_0c385807db1dba6581d6bbd4722d8e94Content-Type: application/pgp-signature; name=signature.ascContent-Disposition: attachment; filename=signature.asc; size=819Content-Description: OpenPGP digital signature-----BEGIN PGP SIGNATURE-----Version: GnuPG v1iQIcBAEBAgAGBQJWl6xjAAoJEKs78blfWHHjIPYP/2eR0BKXEQzAFrQy8mdutIYS/Pa5NqUDFgGaUFfGiBSBCAAfNSbaLnTtdIzSRHttuu8X8vF+J/b5CdAJsvMAuZg4sXHgqCX4oRhDoVCxEV3PMCfWyEjD6+Yr6T8mKjkwI7CRE2osMrfWlnROH4rWsk2akOQyCh3olqw++f5DfJSh9o86bzqD/OmY6Hb0g4NNxybFXZYSDWJIYLoD4v1PIyxrjmnGCzYK1C2gKZVGgLN+W4vBdAARJR1iEHY6+oIZK8kUgeML+IUk5tL/Axc80av3RswHAOwaFQmpORBJMe592w9wX4d/6mbDfLYmfm9MSih2V9VscxYuPwiINtsUJTt/v07jqAszq4gAs9NZrJWTWxUaiXGxATWCOEl0TJyOO1mxj5H05rvLxsDBCpNc2d13BQu1YRlZP4HyliKD3AtFI8zFW5cyeOUoUp3YXQbFl2N8tEDsxAy58HOCQY3IFpOVMpHAPNrvgxdkdyW3nqWT3wW4MtGYL83HUtkjmM/3g1zIzqKPlhXSugoZLzNEMGHmqZoSqZz83dBm01KyDWEk55uhIkU6T9l7LEv8eAZEuTwEo+oIfY3cFPGW+2T6AWE1t9CPaeHAu8Ov8yvwOKqcwpx6xz9L6zjw7uX9i07kgpFQd57iclxqEMqQnMWyp/K7diMfjvwVRtgaFqafs4WZ=+wIM-----END PGP SIGNATURE-------=_0c385807db1dba6581d6bbd4722d8e94--
- HTML message + attachment + signature
[image: Inline image 5]
After my signature fix, still the green box with "Message decrypted" is not displayed, because of the incorrect mime_id.
[image: Inline image 3] After fixing the mime_id:
[image: Inline image 4]
Decrypted message:
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=_bfe7c275050be5c5d1053ae2d62df650"--=_bfe7c275050be5c5d1053ae2d62df650Content-Type: multipart/mixed; boundary="=_bfe7c275050be5c5d1053ae2d62df650"--=_bfe7c275050be5c5d1053ae2d62df650Content-Type: multipart/alternative; boundary="=_dd34536bafebf8a1aa2873136c89542f"--=_dd34536bafebf8a1aa2873136c89542fContent-Transfer-Encoding: 7bitContent-Type: text/plain; charset=US-ASCIIasda asd asdasd--=_dd34536bafebf8a1aa2873136c89542fContent-Transfer-Encoding: quoted-printableContent-Type: text/html; charset=UTF-8<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset==3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen=eva,sans-serif'><p>asda</p><p>asd</p><p>asdasd</p></body></html>--=_dd34536bafebf8a1aa2873136c89542f----=_bfe7c275050be5c5d1053ae2d62df650Content-Transfer-Encoding: base64Content-Type: text/plain; name=globdata.iniContent-Disposition: attachment; filename=globdata.ini; size=1110//5bAFAAcgBvAGQAdQBjAHQATgBhAG0AZQBzAF0ADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAAzADMAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAA0ADEAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAA0ADIAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAAyADgAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADIAMAA1ADIAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAAzADYAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAA0ADAAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAAzADEAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADMAMAA4ADIAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUA--=_bfe7c275050be5c5d1053ae2d62df650----=_bfe7c275050be5c5d1053ae2d62df650Content-Type: application/pgp-signature; name=signature.ascContent-Disposition: attachment; filename=signature.asc; size=819Content-Description: OpenPGP digital signature-----BEGIN PGP SIGNATURE-----Version: GnuPG v1iQIcBAEBAgAGBQJWl6y5AAoJEKs78blfWHHjebsP/iMnmeb2qkvwLRh98WB4LRflZSaYKiW6EP+JHHX0gNcqp/ofU9HwGWDHMuR7k5nhmVk9b/eD/MGFAlvjHQa47b44qUzUvjz46aajTyAgUkUmV44IFEHAasX09DkhL+MO8dYf0pDWbAru0RjVV89QOEUCsrLMQR3kNDHnf1A0KX9k2KDsF1x+kUo62ZEpCdVLKLErcDPuXb7mapx8eKjihXKoLG3beSIKVHKFz07ZZehtPG+Ed/9BnbgOAEqjDOe6w4L8isoR+KUXHJOtp5tCDUQK1eRIxAsLjsQsvOGxBiMsyo1opiok4JWj4Zqu8VPJZENCDbJ7jXQfPHtM57GZ0jXb219N80xT9jBOqtQWVKKM0BeqGf/kn8vRpUSJr5qervsO8JvRPkzduqZ9JXewQPhPFrSadPiyqd8kF4VGpULpvB7ckxETUJjadoKVheF44r+0oVoEqHCnkIQpFZuKkjpHJbvMrAqHJXMNmEd1W0e2B1b2FBe02iMJ1DzvP0Kj5PVgrjiqXF6mhwkCpO5xxiwfH8dE6cCW2ReGbF5NdrbmySPsEmKXnW4o4GGU8pSrs0W1xHyTk+JRjRlAhS7vK9+W5wjukEDE42tbBtycFn1AKZSKBsL9UVTXcXAqLkDANefQOkL5q9wGOxW77EGoZySEfsORbWccIz9TDbwxwFRH=Oa6W-----END PGP SIGNATURE-------=_bfe7c275050be5c5d1053ae2d62df650--
On Mon, Jan 18, 2016 at 10:36 AM, A.L.E.C alec@alec.pl wrote:
On 01/18/2016 10:18 AM, devotedmystic . wrote:
Anyway, if you send an encrypted message to yourself, you will see that only a plain text message without attachments works (do the test with signature included). You see the green squared message that it was decrypted, and the decrypted text.
Any other combination (html, attachments) fails to decrypt and you get a blank page.
The main issue with parsing the correct content type is the "^" character, which failed on my system. Maybe, Debian systems expect just a "\n" and instead the files also contain "\r". There is no issue removing the "^" and all works.
The issue with attachments is that the wrong (incomplete) mime_id was passed. Thus, decryption hung and you saw again the blank page. That's why I updated with the "1.2" value, which is the usual position of the text when there are attachments, and all worked. I saw this printing the structure of the message and comparing it to a text plain email without attachment.
Last, if the message contained a signature, it displayed the usual blank page again, because Roundcube parser does not take into account signatures. So you need to remove it from the body before passing it to Roundcube functions.
As I've said before, all of this works for me. That why I need message samples.
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On 01/18/2016 11:04 AM, devotedmystic . wrote:
Ok. Here are some examples.
--=_bfe7c275050be5c5d1053ae2d62df650-- --=_bfe7c275050be5c5d1053ae2d62df650 Content-Type: application/pgp-signature;
Thanks for the samples. I see now what's missing. I also see that the second example has wrong structure (the attachment is not signed), which means signed messages creation would need a fix too. I'll work on these to be fixed before 1.2-stable release.
Yes, except for text plain messages, when the other kinds of message are to be signed and encrypted, just before the encryption password is asked for, a yellow box appears saying that the signature failed because of wrong password. There is something wrong or not handled in the signature process. And of course, signature verification fails. I also tried various combinations manually with gpg on those messages to verify the signature and they all failed.
On Tue, Jan 19, 2016 at 11:00 AM, A.L.E.C alec@alec.pl wrote:
On 01/18/2016 11:04 AM, devotedmystic . wrote:
Ok. Here are some examples.
--=_bfe7c275050be5c5d1053ae2d62df650-- --=_bfe7c275050be5c5d1053ae2d62df650 Content-Type: application/pgp-signature;
Thanks for the samples. I see now what's missing. I also see that the second example has wrong structure (the attachment is not signed), which means signed messages creation would need a fix too. I'll work on these to be fixed before 1.2-stable release.
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
Today I cloned git to verify changes, but the enigma managesieve modules do not seem working.
Checking Settings->PGP Keys, I get the following error:
[image: Inline image 1]
Encrypted mail just displays blank (it stays with the message "Loading..."). I find nothing in the server log. My "home" is copied same as from my working roundcube install. Any idea?
On Tue, Jan 19, 2016 at 12:36 PM, devotedmystic . devotedmystic@gmail.com wrote:
Yes, except for text plain messages, when the other kinds of message are to be signed and encrypted, just before the encryption password is asked for, a yellow box appears saying that the signature failed because of wrong password. There is something wrong or not handled in the signature process. And of course, signature verification fails. I also tried various combinations manually with gpg on those messages to verify the signature and they all failed.
On Tue, Jan 19, 2016 at 11:00 AM, A.L.E.C alec@alec.pl wrote:
On 01/18/2016 11:04 AM, devotedmystic . wrote:
Ok. Here are some examples.
--=_bfe7c275050be5c5d1053ae2d62df650-- --=_bfe7c275050be5c5d1053ae2d62df650 Content-Type: application/pgp-signature;
Thanks for the samples. I see now what's missing. I also see that the second example has wrong structure (the attachment is not signed), which means signed messages creation would need a fix too. I'll work on these to be fixed before 1.2-stable release.
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On 01/25/2016 11:53 AM, devotedmystic . wrote:
Checking Settings->PGP Keys, I get the following error:
Works for me. In case of "Internal Server Error" there must be something in the error log.
I don't wonder that it works by you :)
I checked all logs, tweaked, reinstalled everything... same result.
As soos as this function is called, it does not get past that:
$this->pgp_driver = new $driver($username);
Something must have changed in the driver. I am on a Debian.
On Mon, Jan 25, 2016 at 12:06 PM, A.L.E.C alec@alec.pl wrote:
On 01/25/2016 11:53 AM, devotedmystic . wrote:
Checking Settings->PGP Keys, I get the following error:
Works for me. In case of "Internal Server Error" there must be something in the error log.
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
I found out that the issue is not related to enigma. I substituted the enigma folder with the old (working) one, and same error. I overwrote also the roundcube main files with the old version, and it worked again.
So, it's something in the main roundcube, but I could not find out where it happens.
It is fully reproducible if you start from a fresh git clone.
Also managesieve produces a blank page. Other plugins seem to work fine.
On Mon, Jan 25, 2016 at 1:03 PM, devotedmystic . devotedmystic@gmail.com wrote:
I don't wonder that it works by you :)
I checked all logs, tweaked, reinstalled everything... same result.
As soos as this function is called, it does not get past that:
$this->pgp_driver = new $driver($username);
Something must have changed in the driver. I am on a Debian.
On Mon, Jan 25, 2016 at 12:06 PM, A.L.E.C alec@alec.pl wrote:
On 01/25/2016 11:53 AM, devotedmystic . wrote:
Checking Settings->PGP Keys, I get the following error:
Works for me. In case of "Internal Server Error" there must be something in the error log.
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On 01/25/2016 03:38 PM, devotedmystic . wrote:
Also managesieve produces a blank page. Other plugins seem to work fine.
Maybe something with classes autoloader. Anyway, in such case (blank page) you'll see an error in log. So, take a look at your error logging configuration.
The latest error I have in the log dates back to 3 days ago. So... I have nothing in the log. Maybe I will open a bug, so we can see if others experience the same issue. I exhausted my ideas.
On January 25, 2016 3:49:49 PM CET, "A.L.E.C" alec@alec.pl wrote:
On 01/25/2016 03:38 PM, devotedmystic . wrote:
Also managesieve produces a blank page. Other plugins seem to work
fine.
Maybe something with classes autoloader. Anyway, in such case (blank page) you'll see an error in log. So, take a look at your error logging configuration.
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On 01/25/2016 08:53 PM, Devoted Mystic wrote:
The latest error I have in the log dates back to 3 days ago. So... I have nothing in the log. Maybe I will open a bug, so we can see if others experience the same issue. I exhausted my ideas.
Maybe check another log, i.e. don't depend on Roundcube log, check httpd server log. Are you using composer or system-packaged libraries? Check if they exist and are in include path (Crypt_GPG and Net_Sieve).
What PHP version?
Success, it was the "vendor" folder missing.
It works pretty well now. But I still found a bug in an HTML mail with attachment + signature. The body of the message is displayed twice.
[image: Inline image 1]
As an HTML email contains also the text version, I suspect that the text + the HTML version are displayed. So, it should just be a matter of removing the plain version when we have an HTML email.
Other things to tune up:
-plain text email with signature: the signature should be downloadable, as it happens with HTML and messages with attachments now. [image: Inline image 2] -HTML email, plain text or HTML + attachments (all with signature): it would be good to have the green message of "Verified signature from...", as it happens for the plain text email (no attachments) above. [image: Inline image 3]
On Tue, Jan 26, 2016 at 8:06 AM, A.L.E.C alec@alec.pl wrote:
On 01/25/2016 08:53 PM, Devoted Mystic wrote:
The latest error I have in the log dates back to 3 days ago. So... I have nothing in the log. Maybe I will open a bug, so we can see if others experience the same issue. I exhausted my ideas.
Maybe check another log, i.e. don't depend on Roundcube log, check httpd server log. Are you using composer or system-packaged libraries? Check if they exist and are in include path (Crypt_GPG and Net_Sieve).
What PHP version?
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On 01/26/2016 11:04 AM, devotedmystic . wrote:
It works pretty well now. But I still found a bug in an HTML mail with attachment + signature. The body of the message is displayed twice.
Provide a sample, please.
-plain text email with signature: the signature should be downloadable, as it happens with HTML and messages with attachments now.
More a feature than a bug. I don't see really a need for this though. Thunderbird+Enigmail also does not add inline signatures to the attachments list.
-HTML email, plain text or HTML + attachments (all with signature): it would be good to have the green message of "Verified signature from...", as it happens for the plain text email (no attachments) above.
Need a sample. Note: previously signed messages created by Enigma have had invalid structure. Test with newly created messages.
I did a mistake. I was using the old generated messages. I generated new messages now, and things changed.
The only message that does not work the right way is HTML + attachment + signature. The "decypted" message and "signature verified" message are missing. But decryption works fine.
[image: Inline image 1]
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=_dfa816b4e353745a697c0959358b80aa"This is an OpenPGP/MIME signed message (RFC 4880 and 3156)--=_dfa816b4e353745a697c0959358b80aaContent-Type: multipart/mixed; boundary="=_6add61e941ee3ae96dc0b235baf64610"--=_6add61e941ee3ae96dc0b235baf64610Content-Type: multipart/alternative; boundary="=_8dded80302f1837e475b3c8bd7a879c8"--=_8dded80302f1837e475b3c8bd7a879c8Content-Transfer-Encoding: 7bitContent-Type: text/plain; charset=US-ASCIIasdasd asdasd asdasa--=_8dded80302f1837e475b3c8bd7a879c8Content-Transfer-Encoding: quoted-printableContent-Type: text/html; charset=UTF-8<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset==3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen=eva,sans-serif'><p>asdasd</p><p>asdasd</p><p>asdasa</p></body></html>--=_8dded80302f1837e475b3c8bd7a879c8----=_6add61e941ee3ae96dc0b235baf64610Content-Transfer-Encoding: base64Content-Type: text/plain; name=globdata.iniContent-Disposition: attachment; filename=globdata.ini; size=1110//5bAFAAcgBvAGQAdQBjAHQATgBhAG0AZQBzAF0ADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAAzADMAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAA0ADEAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAA0ADIAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAAyADgAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADIAMAA1ADIAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAAzADYAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAA0ADAAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADEAMAAzADEAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUADQAKAFAAcgBvAGQAdQBjAHQATgBhAG0AZQAuADMAMAA4ADIAPQBNAGkAYwByAG8AcwBvAGYAdAAgAFYAaQBzAHUAYQBsACAAQwArACsAIAAyADAAMAA4ACAAUgBlAGQAaQBzAHQAcgBpAGIAdQB0AGEAYgBsAGUA--=_6add61e941ee3ae96dc0b235baf64610----=_dfa816b4e353745a697c0959358b80aaContent-Type: application/pgp-signature; name=signature.ascContent-Disposition: attachment; filename=signature.asc; size=819Content-Description: OpenPGP digital signature-----BEGIN PGP SIGNATURE-----Version: GnuPG v1iQIcBAEBAgAGBQJWp2BjAAoJEKs78blfWHHj9FgP/iEJLdcZYu6rET/jmBougSVeAvlaVN4HFBL53lKzgv7J0p5vNPWoA1cy7NdH9FkjC97znw+Qg9fuiwJSLAHy/AI0fM1QWToogiLu6tBJ5KkAQNh/dxGt5KDQos2xl0DLM2MlZ2TFy3n49yLeIZ2DCk4yIxadUe4fvTRvp24zqX8uz6zJBBBAkE+g3nhCD6skt5mnq82yfaTT4Yc6aSc1rfW2WlKH9uxvxzQH8MmXgjWx/oEEg7J/MWq/JrqsL0J8UjkLTMJbmfvTEtEEEf2tf7T7V//k5fTLTErd94poCu54qx02v+Jj75vll2A4qLidOpT9I/JJfIcqqzOFfxgxpPdYnKVM+MpnQEUQF2eCiLcEh23y3Tl3sngVzCPVmXHmrlMiniGZ8emHcH4QYwGVJPAKCYueMXFqPR5JvLqmYfrAqaz6OviXUQ7e+NldSYCmALXi1sW3KhMizr9CqOPykNvHdsJWTebwh9Yb2Xkh2ZTJ8FboRHPvq8Dc2NtrLSJ85bwZbj8cQxz+UIe1Thv/9UfcpvklXQZ5o2tMUUFK6EwtMrNh62GGPpHV1dkqpkgELIwqkKDYuDO3SnX4cK3eRajUCSbC6xc9GvlGbZEMClxaPXu3wlw59D4of4sCvv0oK0T3/m1mehvjJgxMI+/hsLl2ba4iz+FFJeW+j+NMuPp6=2UJ0-----END PGP SIGNATURE-------=_dfa816b4e353745a697c0959358b80aa--
About being able to download inline signature in a plain text email, I don't remember about Enigmail, but for the sake of consistency it would be good to be able to always download it.
On 01/26/2016 01:13 PM, devotedmystic . wrote:
I did a mistake. I was using the old generated messages. I generated new messages now, and things changed.
The only message that does not work the right way is HTML + attachment + signature. The "decypted" message and "signature verified" message are missing. But decryption works fine.
Fixed.
About being able to download inline signature in a plain text email, I don't remember about Enigmail, but for the sake of consistency it would be good to be able to always download it.
Well, technicly the inline signature is not an attachment, but I see your point. I'm not going to work on this now, though.
-
A.L.E.C -
Devoted Mystic -
devotedmystic .