I've corrected this bug and am copying the fix here as with the current changes I'm not sure where things should be submitted, so sorry for the duplication. Can somebody please confirm my fix (It's working for me, but as always YMMV) and close the bug if you find it appropriate?
In file program/steps/mail/compose.inc, replace lines 404-410, which are currently:
// create a reply-subject
else if (isset($REPLY_MESSAGE['subject']))
$subject = 'Re: '.$REPLY_MESSAGE['subject'];
// create a forward-subject
else if (isset($FORWARD_MESSAGE['subject']))
$subject = 'Fwd: '.$FORWARD_MESSAGE['subject'];
with the following:
// create a reply-subject
else if (isset($REPLY_MESSAGE['subject'])) {
if (eregi("^Re: ", $REPLY_MESSAGE['subject'])) {
$subject = $REPLY_MESSAGE['subject'];
} else {
$subject = 'Re: '.$REPLY_MESSAGE['subject'];
}
}
// create a forward-subject
else if (isset($FORWARD_MESSAGE['subject'])) {
if (eregi("^Fwd: ", $FORWARD_MESSAGE['subject'])) {
$subject = $FORWARD_MESSAGE['subject'];
} else {
$subject = 'Fwd: '.$FORWARD_MESSAGE['subject'];
}
}
This will only put a 'Re:' (or 'Fwd:' if it's a foward) if one doesn't already exist. It's case-insensitive, so if there is a RE:/Re:/re: at the start of the subject it won't add another one. It also checks for the colon character (':') so that if the subject is 'Rewards Program' the Re: will still be created.
Also can somebody clarify the correct procedure here - when fixing bugs from SF should I post the response on SF, here, or both?
Best Regards,
Ross Poulton
-
Ross Poulton