Hi!
My setup around RC is somewhat complicated. IMAP and managesieve protocols are behind proxy. To make matters worse, it seems that it is not the same software which is doing proxy and back end. And this breaks RC in weird ways.
For example, quota does not show, in sieve rules some actions are missing and so on.
I was able, finally, to track this down to difference in capability response, which of course, are different for proxy and back end. The fix is simple - after login, check again for capability response!
I did two patches, and would like to know did i made them at the right place? I do have some experience with PHP, but i'm not so familiar with RC and it's internal workings.
If this changes are ok, i guess it would be nice to make new config option, which will enable to re-read capability response _after_ login.
Keep up the good work! :-)
H.
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Gk/v1JX3xNJ/rc1.patch http://detached.gigo.com/rc/Gk/v1JX3xNJ/rc2.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
On 13.06.2010 09:39, Hrvoje Habjanić wrote:
Hi!
My setup around RC is somewhat complicated. IMAP and managesieve protocols are behind proxy. To make matters worse, it seems that it is not the same software which is doing proxy and back end. And this breaks RC in weird ways.
For example, quota does not show, in sieve rules some actions are missing and so on.
I was able, finally, to track this down to difference in capability response, which of course, are different for proxy and back end. The fix is simple - after login, check again for capability response!
I did two patches, and would like to know did i made them at the right place? I do have some experience with PHP, but i'm not so familiar with RC and it's internal workings.
If this changes are ok, i guess it would be nice to make new config option, which will enable to re-read capability response _after_ login.
Hi again!
Maybe i did not state clearly, but i would like to have some feedback about changes i made, and if they fit in the grand design, i will finish them (ie. make config option). I just need info - are changes in the "right" places, or this can be solved in some other way?
Thanks,
H.
Keep up the good work! :-)
H.
*Detachments* -The following attachments have been detached and are available for viewing.
* http://detached.gigo.com/rc/Gk/v1JX3xNJ/rc1.patch * http://detached.gigo.com/rc/Gk/v1JX3xNJ/rc2.patchOnly click these links if you trust the sender, as well as this message.
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
On 17.06.2010 11:30, Hrvoje Habjanić wrote:
I was able, finally, to track this down to difference in capability response, which of course, are different for proxy and back end. The fix is simple - after login, check again for capability response!
We've got imap_force_caps for IMAP capabilities. So, we only need such option for SIEVE, but if possible we shouldn't modify Net_Sieve package. If this will be not possible, then such change should be requested to Net_Sieve developers.
-
A.L.E.C -
Hrvoje Habjanić