Hello Justin,

I've applied your patches and copied images, but it is not working for me. I can see the arrows (even with mouse over description) but if I click on one of the arrows nothing is happening (this is with Firefox 1.0.7 Win32). With IE 6 it does work, but not the way it should be. If I click once on any of the sort buttons it will sort it, but then never ever do it again, until closing browser window and logging in again. So i suppose it might be something with session handling?!

/Rob

On Sun, 23 Oct 2005 17:07:53 +1000, Justin Randell justin@babel.com.au wrote:

howdy,

just implemented sorting by message list columns. link to patch tracker:

http://sourceforge.net/tracker/index.php?func=detail&aid=1335283&gro...

please test this. all comments/criticisms welcome.

cheers justin

Justin,

I sorted things out. It seems to be a problem with the UI language. When I switch back to "Englsih US" everything is working like you explained it should work, but if I change back to my native language (german) it will only sort things once (in a wrong way) and do nothing afterwards until you login again.

/Rob

On Sun, 23 Oct 2005 22:13:23 +1000, Justin Randell justin@babel.com.au wrote:

hi robert,

thanks for trying the patches out.

if you click on the sort descending by date button when you first look at a mailbox, then the sorting wont change, because that's the default setting? is that the button that doesn't work?

this needs to be fixed - the current sort button should be greyed or something like that.

the behaviour i was aiming for with the sorting was:

• the type of sort is remembered across pages in a particular mbox, and

remembered when sending mail, changing settings or using the addressbook. that is, after doing one of those things and being returned to the mail list, the sort is the same for a given mailbox

• the sort is reset to default whenever you change folders - date

descending

can you give me anymore debugging info? did you get any javascript errors?

i'm justin_randell on the roundcube irc channel (#roundcube irc.freenode.net) if you're ever there.

cheers justin

ICQ 244 909 636

Robert Landes wrote:

...

Hello Justin,

I've applied your patches and copied images, but it is not working for

me. I can see the arrows (even with mouse over description) but if I click on one of the arrows nothing is happening (this is with Firefox 1.0.7 Win32). With IE 6 it does work, but not the way it should be. If I click once on any of the sort buttons it will sort it, but then never ever do it again, until closing browser window and logging in again. So i suppose it might be something with session handling?!

...

/Rob

On Sun, 23 Oct 2005 17:07:53 +1000, Justin Randell justin@babel.com.au

wrote:

...

...

howdy,

just implemented sorting by message list columns. link to patch tracker:

http://sourceforge.net/tracker/index.php?func=detail&aid=1335283&gro...

please test this. all comments/criticisms welcome.

cheers justin

Thomas,

did you test it with other lanuages than en_US ? If I try to use it with german language, it doesn't work.

Please check on that issues.

/Rob

On Sun, 23 Oct 2005 15:57:26 +0200, Thomas Bruederli roundcube@gmail.com wrote:

Hi Justin,

I tried you sorting patch and it works perfect for me. Thanks! Will add it to the current development version and change it a bit to suit better with the skin concept (I don't like button file names within the PHP core) and I will also add some client side work to show which column is currently active and to prevent from reloading the list when hitting the same button twice.

Thanks again for this! Thomas

Justin Randell wrote:

...

howdy,

just implemented sorting by message list columns. link to patch tracker:

http://sourceforge.net/tracker/index.php?func=detail&aid=1335283&gro...

...

please test this. all comments/criticisms welcome.

cheers justin

howdy,

these patches are now in cvs.

cheers justin

David A. Davenport wrote:

Greetings,

Pardon my ignorance, if this was already discussed, but when you say you will add it to the current development version, do you mean CVS, or is there a so-called "nightly build?"

Dave

On Sun, 23 Oct 2005 15:57:26 +0200, Thomas Bruederli roundcube@gmail.com wrote:

...

Hi Justin,

I tried you sorting patch and it works perfect for me. Thanks! Will add it to the current development version and change it a bit to suit better with the skin concept (I don't like button file names within the PHP core) and I will also add some client side work to show which column is currently active and to prevent from reloading the list when hitting the same button twice.

Thanks again for this! Thomas

Justin Randell wrote:

...

howdy,

just implemented sorting by message list columns. link to patch tracker:

http://sourceforge.net/tracker/index.php?func=detail&aid=1335283&gro...

...

please test this. all comments/criticisms welcome.

cheers justin

justin randell wrote:

hi robert and thomas,

robert: sorry for my laziness on making it work for all supported languages!

For me it actually works with all languages (no program erros) except the title of the sort button is not translated.

thomas: are you working on making sorting work for all languages? do you want me to do it?

I will do it as soon as I find some time to work on RoundCube again.

another question about sorting: how to make it work in message view?

eg, when i go to a mailbox, sort it, then view a message, if i use the next or previous message button, then i lose the sorting. at the moment, the next and previous buttons only know about the uid of the message, not the sorting order.

You're right, I didn't think of that either. I will take care about it. I think that should not be very difficult since we're saving the sort order within the session.

squirrelmail handles this by storing an array in the session which maps message ids for a given mailbox with the sort ranking for a particular type of sort for each message.

any thoughts on how we should implement this? can anyone think of a better way than the one used by squirrelmail?

cheers justin

Regards, Thomas

howdy,

we just noticed that the sorting now works for all languages except for... dutch :-)

there are some garbage characters on the first line of the file:

program/localization/nl/messages.inc

could someone with commit access clean this up?

cheers justin

It's much faster to sort the cached message headers on the RoundCube server than get all the messages re-sorted from the IMAP server every time...

I would have chosen the same way to implement message sorting as Justin did.

Regards, Thomas

David Saez Padros wrote:

Hi !!

...

another question about sorting: how to make it work in message view?

maybe sorting should be better done at server side (almost all of them support it)

...

eg, when i go to a mailbox, sort it, then view a message, if i use the next or previous message button, then i lose the sorting. at the moment, the next and previous buttons only know about the uid of the message, not the sorting order.

squirrelmail handles this by storing an array in the session which maps message ids for a given mailbox with the sort ranking for a particular type of sort for each message. any thoughts on how we should implement this? can anyone think of a better way than the one used by squirrelmail?

if sorting is done at the server side, this problem and many others will go away, the problem is that if there is any server that does not support server sorting that feature will not be available for it. it's a risky decision.