Re: [RCD] [Roundcube Webmail] #1488925: Save mail content in local storage while composing
Am 20.01.2014 12:13, schrieb Roundcube Webmail:
#1488925: Save mail content in local storage while composing --------------------------------+------------------------- Reporter: thomasb | Owner: Type: Feature Requests | Status: closed Priority: 5 | Milestone: 1.0-stable Component: Core functionality | Version: git-master Severity: normal | Resolution: fixed Keywords: | --------------------------------+------------------------- Changes (by thomasb):
- status: new => closed
- resolution: => fixed
Comment:
The local storage copy is saved ever few seconds and isn't restricted by the draft-autosave interval. I consider this feature complete now.
Well, not sure...
But before digging deeper into any details, one question:
What should happen if in real life...
- I get a phone call during composing a message,
- walk away from the laptop and the call takes a while,
- the laptop goes into sleep mode during the call and loses connection,
- I wake up the laptop after finishing the phone call and continue
composing?
My experience is that...
the changed message is not being saved to the draft folder anymore (not even after a re-login to Roundcube), and
that I can't send the message.
But after cancelling it and hitting the "new message" button, I can restore this changed message perfectly and send it.
But I don't even know that I can continue composing and that the message will still be saved to the local storage while continuing composing in the scenario above. There is some lack of feedback.
And what is taking precedence - the copy in the draft folder, or the copy in the local storage, are time stamps being compared, etc. etc. ??
The design is still not clear to me. I also have often been surprised by the option to restore a message which has been saved to the local storage, although it had been sent successfully already.
But a great feature, anyway!
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On Tue, Jan 21, 2014 at 12:05 AM, Michael Heydekamp listuser@freexp.de wrote:
The local storage copy is saved ever few seconds and isn't restricted by the draft-autosave interval. I consider this feature complete now.
Well, not sure...
I closed it because there was no feedback, neither in the ticker nor on other channels. So if you find things that don't work as expected, please open new tickets for them.
But before digging deeper into any details, one question:
What should happen if in real life...
- I get a phone call during composing a message,
- walk away from the laptop and the call takes a while,
- the laptop goes into sleep mode during the call and loses connection,
- I wake up the laptop after finishing the phone call and continue
composing?
My experience is that...
the changed message is not being saved to the draft folder anymore (not even after a re-login to Roundcube), and
that I can't send the message.
But after cancelling it and hitting the "new message" button, I can restore this changed message perfectly and send it.
But I don't even know that I can continue composing and that the message will still be saved to the local storage while continuing composing in the scenario above. There is some lack of feedback.
Suggestions?
That's probably a matter of documentation, too.
And what is taking precedence - the copy in the draft folder, or the copy in the local storage, are time stamps being compared, etc. etc. ??
There's a dialog asking whether to use the local copy. Usually one can assume that the local copy is newer or the same as the draft. There's no scenario where the local copy lags behind the saved draft.
The design is still not clear to me. I also have often been surprised by the option to restore a message which has been saved to the local storage, although it had been sent successfully already.
Please describe this with steps to reproduce.
Kind regards, Thomas
Am 22.01.2014 08:39, schrieb Thomas Bruederli:
On Tue, Jan 21, 2014 at 12:05 AM, Michael Heydekamp listuser@freexp.de wrote:
The local storage copy is saved ever few seconds and isn't restricted by the draft-autosave interval. I consider this feature complete now.
Well, not sure...
I closed it because there was no feedback, neither in the ticker nor on other channels.
I know, it's also a lack of feedback on my part, as I have to admit. Have been too busy with other things.
So if you find things that don't work as expected, please open new tickets for them.
Will do.
But before digging deeper into any details, one question:
What should happen if in real life...
- I get a phone call during composing a message,
- walk away from the laptop and the call takes a while,
- the laptop goes into sleep mode during the call and loses connection,
- I wake up the laptop after finishing the phone call and continue
composing?
My experience is that...
the changed message is not being saved to the draft folder anymore (not even after a re-login to Roundcube), and
that I can't send the message.
But after cancelling it and hitting the "new message" button, I can restore this changed message perfectly and send it.
But I don't even know that I can continue composing and that the message will still be saved to the local storage while continuing composing in the scenario above. There is some lack of feedback.
Suggestions?
Well, difficult if I don't know what the design and the logic is (or what it should be).
The design is still not clear to me. I also have often been surprised by the option to restore a message which has been saved to the local storage, although it had been sent successfully already.
Please describe this with steps to reproduce.
I'll deliver it asap.
But as I said: Great feature anyway! Better to have a superfluos copy in the local storage rather than losing a lengthy message.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
But I don't even know that I can continue composing and that the message will still be saved to the local storage while continuing composing in the scenario above. There is some lack of feedback.
Suggestions?
Well, difficult if I don't know what the design and the logic is (or what it should be).
Doesn't matter. Just describe how you would imagine things to be presented and to behave.
Best, Thomas
Am 23.01.2014 08:50, schrieb Thomas Bruederli:
But I don't even know that I can continue composing and that the message will still be saved to the local storage while continuing composing in the scenario above. There is some lack of feedback.
Suggestions?
Well, difficult if I don't know what the design and the logic is (or what it should be).
Doesn't matter. Just describe how you would imagine things to be presented and to behave.
Funny: I just wanted to reply to a private message and have been presented three allegedly unsent messages in a row which had in fact been sent even a while ago. And which had no connection to the message at all that I wanted to reply to.
This for instance shouldn't happen: If I reply to a message being sent by person/address #1, I don't want to be reminded that there may (!) be an unsent message to a totally different person/address #2.
But I'll make up my mind and will revert with more specific issues.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On Thu, Jan 23, 2014 at 9:01 PM, Michael Heydekamp listuser@freexp.de wrote:
Am 23.01.2014 08:50, schrieb Thomas Bruederli:
But I don't even know that I can continue composing and that the message will still be saved to the local storage while continuing composing in the scenario above. There is some lack of feedback.
Suggestions?
Well, difficult if I don't know what the design and the logic is (or what it should be).
Doesn't matter. Just describe how you would imagine things to be presented and to behave.
Funny: I just wanted to reply to a private message and have been presented three allegedly unsent messages in a row which had in fact been sent even a while ago. And which had no connection to the message at all that I wanted to reply to.
This for instance shouldn't happen: If I reply to a message being sent by person/address #1, I don't want to be reminded that there may (!) be an unsent message to a totally different person/address #2.
I suppose a bug sneaked in with this commit: https://github.com/roundcube/roundcubemail/commit/10936fef We'll investigate that further...
~Thomas
Am 27.01.2014 17:10, schrieb Thomas Bruederli:
On Thu, Jan 23, 2014 at 9:01 PM, Michael Heydekamp listuser@freexp.de wrote:
Am 23.01.2014 08:50, schrieb Thomas Bruederli:
But I don't even know that I can continue composing and that the message will still be saved to the local storage while continuing composing in the scenario above. There is some lack of feedback.
Suggestions?
Well, difficult if I don't know what the design and the logic is (or what it should be).
Doesn't matter. Just describe how you would imagine things to be presented and to behave.
Funny: I just wanted to reply to a private message and have been presented three allegedly unsent messages in a row which had in fact been sent even a while ago. And which had no connection to the message at all that I wanted to reply to.
This for instance shouldn't happen: If I reply to a message being sent by person/address #1, I don't want to be reminded that there may (!) be an unsent message to a totally different person/address #2.
I suppose a bug sneaked in with this commit: https://github.com/roundcube/roundcubemail/commit/10936fef We'll investigate that further...
Ok. Damn, currently I simply don't find the time to test this intensively and to send a meaningful report.
What I'm still constantly encountering is that when I create a plain new message, RC does present me a number of allegedly unsent messages which in fact have been sent already.
Win7/64, FF26.0
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On Wed, Feb 12, 2014 at 12:07 AM, Michael Heydekamp listuser@freexp.de wrote:
I suppose a bug sneaked in with this commit: https://github.com/roundcube/roundcubemail/commit/10936fef We'll investigate that further...
Ok. Damn, currently I simply don't find the time to test this intensively and to send a meaningful report.
What I'm still constantly encountering is that when I create a plain new message, RC does present me a number of allegedly unsent messages which in fact have been sent already.
I tried for hours to reproduce this but I didn't manage to do so. Even with FF or IE on windows, all copies in local storage got removed after saving a draft or sending the message. I'd really be interested why this doesn't happen in your case.
FWIW: suggestions only appear for entries with other/old session IDs. And you can delete them from the popup dialog.
Regards, Thomas
Am 12.02.2014 08:52, schrieb Thomas Bruederli:
On Wed, Feb 12, 2014 at 12:07 AM, Michael Heydekamp listuser@freexp.de wrote:
I suppose a bug sneaked in with this commit: https://github.com/roundcube/roundcubemail/commit/10936fef We'll investigate that further...
Ok. Damn, currently I simply don't find the time to test this intensively and to send a meaningful report.
What I'm still constantly encountering is that when I create a plain new message, RC does present me a number of allegedly unsent messages which in fact have been sent already.
I tried for hours to reproduce this but I didn't manage to do so. Even with FF or IE on windows, all copies in local storage got removed after saving a draft or sending the message. I'd really be interested why this doesn't happen in your case.
You should try to avoid it - THEN it may happen. ;)
As soon as I find the time, I'll dig deeper into it.
FWIW: suggestions only appear for entries with other/old session IDs.
Ah, THAT may be an issue...
And you can delete them from the popup dialog.
Sure, I know.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
-
Michael Heydekamp -
Thomas Bruederli