Mark Mackay - Orcon wrote:

Hi Ivan -

I tried this new function, and I think there may be a problem with it (or my PHP installation, etc). Roundcube refused to present the login page with this pasted in:

Running "php4 rcube_imap.inc" produced:

Parse error: parse error, unexpected T_OBJECT_OPERATOR in /var/www/roundcube/program/include/rcube_imap.inc on line 321

The offending lines were:

//check for changes using the UID if ($hdr->uid === end($a_out)->uid) $revalidate = false;

It worked when I commented these out, but obviously this skipped the comparison of the last UID.

Thanks Mark for the bug report, I'm using PHP5 so I guess PHP4 is complaining about the "end($a_out)->uid" bit. Just replace that lines with this ones:

$lastCacheHdr = end($a_out); if ($hdr->uid === $lastCacheHdr->uid) $revalidate = false;

ciao, ivan