Hi all,
I just checked out Revision 766 and it looks like viewing binary attachments is broken. Clicking to open a JPEG attachment opens the new viewing window, and fills the iframe with with the decoded data, but in text form.
So far it looks as though the "Content-Type" is not being set correctly, and is defaulting to "text/html".
In-line viewing of images in the preview pane is still working though.
Anyone able to tackle this?
Rich _______________________________________________ List info: http://lists.roundcube.net/dev/
Strike that, had added a character after a ?> closing PHP tag. :)
Rich
Rich at Whidbey Telecom wrote:
Hi all,
I just checked out Revision 766 and it looks like viewing binary attachments is broken. Clicking to open a JPEG attachment opens the new viewing window, and fills the iframe with with the decoded data, but in text form.
So far it looks as though the "Content-Type" is not being set correctly, and is defaulting to "text/html".
In-line viewing of images in the preview pane is still working though.
Anyone able to tackle this?
Rich _______________________________________________ List info: http://lists.roundcube.net/dev/
I've started leaving the closing ?> tag out of my scripts.
That way there's no chance for me to accidently type an extra character or line break.
It's actually more efficient (albeit probably insignificantly) as PHP doesn't have to jump out of parse mode.
On Thu, 30 Aug 2007 15:10:04 -0700, Rich at Whidbey Telecom richs@whidbey.net wrote:
Strike that, had added a character after a ?> closing PHP tag. :)
Rich
Rich at Whidbey Telecom wrote:
Hi all,
I just checked out Revision 766 and it looks like viewing binary attachments is broken. Clicking to open a JPEG attachment opens the new viewing window, and fills the iframe with with the decoded data, but in text form.
So far it looks as though the "Content-Type" is not being set correctly, and is defaulting to "text/html".
In-line viewing of images in the preview pane is still working though.
Anyone able to tackle this?
Rich _______________________________________________ List info: http://lists.roundcube.net/dev/
--
Rich Sandberg richs@whidbey.net Whidbey Telecom Network Operations _______________________________________________ List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
Matt Kaatman wrote:
I've started leaving the closing ?> tag out of my scripts.
That way there's no chance for me to accidently type an extra character or line break.
It's actually more efficient (albeit probably insignificantly) as PHP doesn't have to jump out of parse mode.
Personally I think this is bad practice and if you start noticing this difference in speed you have too many files to parse anyways... and you are not using a opcode-cache.
My 2 cents, enjoy the weekend,
Mike
Michael Baierl mbaierl.com http://mbaierl.com/
"Just because it sounds like a great idea to put lots of XML into a db and let the front end parse it out, think again." _______________________________________________ List info: http://lists.roundcube.net/dev/
On 8/31/07, Michael Baierl mail@mbaierl.com wrote:
Matt Kaatman wrote:
I've started leaving the closing ?> tag out of my scripts.
That way there's no chance for me to accidently type an extra character or line break.
It's actually more efficient (albeit probably insignificantly) as PHP doesn't have to jump out of parse mode.
Personally I think this is bad practice and if you start noticing this difference in speed you have too many files to parse anyways... and you are not using a opcode-cache.
Personally, I started doing this as well. Especially since it's best practice/recommended by the Zend Framework people.
In regard to parsing files - I think the "setback" rather comes from how you are including (include, require, require_once) them. For those interested, there are a couple interesting threads over on pear-dev (search "allfiles" ;-)).
Cheers, Till _______________________________________________ List info: http://lists.roundcube.net/dev/
-
Matt Kaatman -
Michael Baierl -
Rich at Whidbey Telecom -
till