What is the current state of the unit tests? I am getting many failures
of both the PHP and Selenium tests, but I was running them off on
master, not a released version. Part of the problem was that I was
hitting the 120 second PHP timeout that's hardcoded into iniset.php.
When you run the tests do you manually change that or is there some
other way of running the tests that bypasses the execution timeout?
Are tests being added to and maintained? I've become used to test-driven development with jQuery, and it feels a little dirty to submit a bug or a pull request without a corresponding unit test.
-Charles
On 10/31/2013 07:30 PM, Charles McNulty wrote:
What is the current state of the unit tests? I am getting many failures of both the PHP and Selenium tests, but I was running them off on master, not a released version. Part of the problem was that I was hitting the 120 second PHP timeout that's hardcoded into iniset.php. When you run the tests do you manually change that or is there some other way of running the tests that bypasses the execution timeout?
Works for me.
Time: 1.19 seconds, Memory: 28.00Mb
OK (275 tests, 576 assertions)
Are tests being added to and maintained? I've become used to test-driven development with jQuery, and it feels a little dirty to submit a bug or a pull request without a corresponding unit test.
Yes. We maintain and add new tests. However, the Selenium based tests are just proof-of-concept. There are only few and writing them is harder than these PHP unit tests.
On 2013-10-31 14:13, A.L.E.C wrote:
On 10/31/2013 07:30 PM, Charles McNulty wrote:
What is the current state of the unit tests? I am getting many failures of both the PHP and Selenium tests, but I was running them off on master, not a released version. Part of the problem was that I was hitting the 120 second PHP timeout that's hardcoded into iniset.php. When you run the tests do you manually change that or is there some other way of running the tests that bypasses the execution timeout?
Works for me.
Time: 1.19 seconds, Memory: 28.00Mb
OK (275 tests, 576 assertions)
Interesting, I'll take a look at mine then and see what's actually failing.
Yes. We maintain and add new tests. However, the Selenium based tests are just proof-of-concept. There are only few and writing them is harder than these PHP unit tests.
OK, I'm going to look at writing a few Selenium tests for the list message select stuff. Currently I'm getting at least one failure because my IMAP Server doesn't advertise support for QUOTA, and the Selenium test is testing for the presence of a Quota section. I haven't looked at the other yet, because I didn't want to spend a lot of time on it only to find that no one used or maintained the tests.
-Charles
On 10/31/2013 08:43 PM, Charles McNulty wrote:
Interesting, I'll take a look at mine then and see what's actually failing.
Make sure you're using current git-master. There was an infinite loop in the code fixed a week ago maybe, that caused the tests to hang.
-
A.L.E.C -
Charles McNulty