Hi

Well I finaly did the update correctly, had this error, patched as you said and I gives another error when reading messages:

Parse error: parse error, unexpected T_OBJECT_OPERATOR in /home/www/roundcubemail/program/include/rcube_imap.inc on line 483

And I can't read any message..

I tried to correct, but I'm dreadful in php scripts.

Nicolas

-----Message d'origine----- De : Josh King [mailto:josh@dotmil.org] Envoyé : mardi 13 décembre 2005 06:57 À : dev@lists.roundcube.net Objet : [PATCH-CVS 20051212] rcube_imap.inc: fixes fatal error on line 483

Hi everyone,

First off let me just say that I am *amazed* and very excited to have an app such as RoundCube available. My congrats to the developers!

I was having an issue though. I'm running the latest CVS from tonight (12 Dec 2005) on Debian Sarge, Courier-IMAP 3.0.8, Postfix 2.1.5, Procmail 3.22, Apache 2.0.54, PHP 4.3.10, and MySQL 4.0.24 on a dedicated server.

Everything worked beautifully except for one intermittant problem. The error I received was this:

"Fatal error: Call to undefined function: get_message_cache_index() in /var/www/mail/program/include/rcube_imap.inc on line 483"

The error came mainly on deep subdirs when trying to open a message, but occasionally happened within the Inbox as well.

I have found a fix that works for me:

Original: // cache is OK if ($cache_status>0) { $a_index = get_message_cache_index($cache_key, FALSE, $this->sort_field); return array_values($a_index); }

Fix: // cache is OK if ($cache_status>0) { $a_index = this->get_message_cache_index($cache_key, FALSE, $this->sort_field); return array_values($a_index); }

I'm not sure yet how you usually accept patches or fixes, so please let me know if there is a format you prefer. I attached one in diff -uNr formatting, and should be applied with -p1 from toplevel directory. I make no guarantees on the quality of this though, as I have only tested on one server.

FWIW, is there somewhere I can read up on your procedures for submitting fixes?

Thanks again!

Josh King

http://dotmiltech.com

http://debianhomepage.org

http://debcentral.org