Hi,
Trying to fix #1485659, which hurts me too, I noticed a number of raise_error() calls missing required parameters.
Attached patch fixes three of those. Not sure though if type in utf8.class.php and spell_pspell.inc should be 'php', so I'm not committing this yet.
There are two other occurances in rcube_ldap.php, but I have no clue what error code to put there.
Robin
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Vp/NN6EXh1a/raise_error.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Robin Elfrink wrote:
Hi,
Trying to fix #1485659, which hurts me too,
About the issue, I think it's a session's race conditions problem.
I noticed a number of raise_error() calls missing required parameters.
Attached patch fixes three of those. Not sure though if type in utf8.class.php and spell_pspell.inc should be 'php', so I'm not committing this yet.
There are two other occurances in rcube_ldap.php, but I have no clue what error code to put there.
Type is used only in error message, so it's not very important what you set. If error is related to LDAP connection or comes from LDAP server you can use 'ldap' else use 'php'.
A.L.E.C wrote:
Trying to fix #1485659, which hurts me too,
About the issue, I think it's a session's race conditions problem.
Yeah, I guessed something with sessions, especially after raise_error() raised a more helpful error :)
Weird thing is, I have the problem on one machine, and not on another machine. Both are completely seperate environments.
Type is used only in error message, so it's not very important what you set. If error is related to LDAP connection or comes from LDAP server you can use 'ldap' else use 'php'.
OK, thanks. I committed with number '100' for the ldap errors. Anything other than zero, right? :)
Robin _______________________________________________ List info: http://lists.roundcube.net/dev/
Robin Elfrink wrote:
OK, thanks. I committed with number '100' for the ldap errors. Anything other than zero, right? :)
For 'code' meaning see steps/error.inc.
-
A.L.E.C -
Robin Elfrink