Hi,
Quoted text is not shown on a printed message, except for a bit of padding on the left. This small patch adds a grey border to the left. I'm not quite sure about the grey-levels, but if nobody objects I'll commit this today.
Robin
Index: skins/default/print.css
--- skins/default/print.css (revision 392) +++ skins/default/print.css (working copy) @@ -109,3 +109,23 @@ padding: 0; font-size: 9pt; }
+div.message-part blockquote +{
- color: #444;
- border-left: 2px solid #444;
- margin: 0.5em 0px 0.5em 0px;
- padding: 0px 0px 0px 1em;
+}
+div.message-part blockquote blockquote +{
- color: #666;
- border-left: 2px solid #666;
+}
+div.message-part blockquote blockquote blockquote +{
- color: #888;
- border-left: 2px solid #888;
+}
Robin Elfrink wrote:
Hi,
Quoted text is not shown on a printed message, except for a bit of padding on the left. This small patch adds a grey border to the left. I'm not quite sure about the grey-levels, but if nobody objects I'll commit this today.
I would say, we can use the colored borders for the print view as well. Then it's up to the printer driver to choose the according shades of gray. And some people even have a color printer nowadays...
~Thomas
Thomas Bruederli wrote:
I would say, we can use the colored borders for the print view as well. Then it's up to the printer driver to choose the according shades of gray. And some people even have a color printer nowadays...
In that case I'd say we should also use the coloured logo instead of the greyscale one.
Robin
Index: skins/default/print.css
--- skins/default/print.css (revision 392) +++ skins/default/print.css (working copy) @@ -109,3 +109,27 @@ padding: 0; font-size: 9pt; }
+div.message-part blockquote +{
- color: blue;
- border-left: 2px solid blue;
- border-right: 2px solid blue;
- background-color: #F6F6F6;
- margin: 2px 0px 2px 0px;
- padding: 1px 8px 1px 10px;
+}
+div.message-part blockquote blockquote +{
- color: green;
- border-left: 2px solid green;
- border-right: 2px solid green;
+}
+div.message-part blockquote blockquote blockquote +{
- color: #990000;
- border-left: 2px solid #bb0000;
- border-right: 2px solid #bb0000;
+} Index: skins/default/templates/printmessage.html =================================================================== --- skins/default/templates/printmessage.html (revision 392) +++ skins/default/templates/printmessage.html (working copy) @@ -6,7 +6,7 @@
</head> <body>
-<div id="header"><img src="/images/roundcube_logo_print.gif" width="182" height="50" alt="RoundCube Webmail" /></div> +<div id="header"><img src="/images/roundcube_logo.gif" width="165" height="55" alt="RoundCube Webmail" /></div>
<div id="messageframe"> <roundcube:object name="messageHeaders" class="headers-table" cellspacing="0" cellpadding="2" /> Index: skins/default/images/roundcube_logo_print.gif =================================================================== Cannot display: file marked as a binary type. svn:mime-type = application/octet-stream
Robin Elfrink wrote:
Thomas Bruederli wrote:
I would say, we can use the colored borders for the print view as well. Then it's up to the printer driver to choose the according shades of gray. And some people even have a color printer nowadays...
In that case I'd say we should also use the coloured logo instead of the greyscale one.
Right, I forgot about that. Well we could colorize the current print-logo because it differs from the regular logo. We have more horizontal space and there's no line below the logo. IMO we should keep the current print logo in the print view, even if it's b/w.
~Thomas
Thomas Bruederli wrote:
In that case I'd say we should also use the coloured logo instead of the greyscale one.
Right, I forgot about that. Well we could colorize the current print-logo because it differs from the regular logo. We have more horizontal space and there's no line below the logo. IMO we should keep the current print logo in the print view, even if it's b/w.
Ok, how about this then, with attached image?
I think on a printed we should not use px but em in css.
Robin
Index: skins/default/print.css
--- skins/default/print.css (revision 398) +++ skins/default/print.css (working copy) @@ -110,3 +110,27 @@ white-space: pre; font-size: 9pt; }
+div.message-part blockquote +{
color: blue;border-left: 2px solid blue;border-right: 2px solid blue;background-color: #F6F6F6;margin: 0.5em 0em 0.5em 0em;padding: 0.25em 1em 0.25em 1em;
+}
+div.message-part blockquote blockquote +{
color: green;border-left: 2px solid green;border-right: 2px solid green;
+}
+div.message-part blockquote blockquote blockquote +{
color: #990000;border-left: 2px solid #bb0000;border-right: 2px solid #bb0000;
+}
Thomas Bruederli wrote:
Ok, how about this then, with attached image?
Looks OK to me but I prefer the gray scale version... just a feeling, can't tell you a rational reason.
I like color better, escpecially since we're going to put colors in the css as well. But you're the boss. Grayscale or color?
Pick on and I'll commit, either the image and the css, or only the css.
Robin
Robin Elfrink wrote:
Thomas Bruederli wrote:
Ok, how about this then, with attached image?
Looks OK to me but I prefer the gray scale version... just a feeling, can't tell you a rational reason.
I like color better, escpecially since we're going to put colors in the css as well. But you're the boss. Grayscale or color?
OK then, I vote for grayscale.
Pick on and I'll commit, either the image and the css, or only the css.
Robin
~Thomas
-
Robin Elfrink -
Thomas Bruederli