Two patches:
- Russian localization.
- Fix to toolbar button title (http://trac.roundcube.net/ticket/1486092
that already fixed). I've changed plugin so it unsets "NonJunk" flag before set "Junk" flag (I think that flags are mutually exclusive).
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Gm/t54U4vG5/patch-plugins_markas.php http://detached.gigo.com/rc/Gm/t54U4vG5/patch-plugins_markas.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Anes Mukhametov wrote:
Two patches:
- Russian localization.
- Fix to toolbar button title (http://trac.roundcube.net/ticket/1486092
that already fixed). I've changed plugin so it unsets "NonJunk" flag before set "Junk" flag (I think that flags are mutually exclusive).
Applied with small modification. Thanks.
Thanks. But why "+ if ($rcmail->task == 'mail' && ($rcmail->action == '' || $rcmail->action == 'show') && $rcmail->config->get('junk_mbox')) {"
string not applied?
Is it wrong?
I thought that mbox have to exist to move messages into it:)
A.L.E.C пишет:
Anes Mukhametov wrote:
Two patches:
- Russian localization.
- Fix to toolbar button title (http://trac.roundcube.net/ticket/1486092
that already fixed). I've changed plugin so it unsets "NonJunk" flag before set "Junk" flag (I think that flags are mutually exclusive).
Applied with small modification. Thanks.
List info: http://lists.roundcube.net/dev/
Anes Mukhametov wrote:
Thanks. But why "+ if ($rcmail->task == 'mail' && ($rcmail->action == '' || $rcmail->action == 'show') && $rcmail->config->get('junk_mbox')) {"
string not applied? Is it wrong?
$rcmail->task == 'mail' this is not needed while we have markasjunk::task set.
I thought that mbox have to exist to move messages into it:)
There's a check in request_action(). Moving messages is only a part of plugin's job. I think some implementations doesn't require messages moving for learning, only setting a flag. Also why we couldn't set flag if junk folder not exists?
-
A.L.E.C -
Anes Mukhametov