Purpose of change_identity JavaScript event trigger? (was: [Svn] [roundcube/roundcubemail] af61b9: Adds change_identity JavaScript event trigger)
Hi there,
may I ask what the intention of the commit quoted below exactly is...?
Here it changed the behaviour of select_identity apparently in so far as the address in the From: header is now being selected as the identity, even if it does not match the full mailbox spec (name+address).
This is in contradiction to what Alec recently wrote:
Am 14.10.2013 11:03, schrieb A.L.E.C:
On 10/14/2013 10:47 AM, Michael Heydekamp wrote:
Thanks. But are you sure about "From"? During my tests I didn't manage to select the identity in the From: header at all. The default identity had been selected instead (unless From: and Return-path: were identical).
Well, From header check matches full mailbox spec., e.g. "Roundcube Users dev@lists.roundcube.net".
This is because we want to handle correctly situation when user has many identities with same address but different name. It's not perfect and I'm not saying we don't need an improvement here.
And an hour later, he wrote:
Am 14.10.2013 12:03, schrieb A.L.E.C:
For To/Cc the matching is different. We check addresses, but give bigger prio to identity where address+name matches. So, here we're safe. I suppose we could do the same for From with some more coding. Feel free to create a ticket.
So I created a ticket:
http://trac.roundcube.net/ticket/1489378
Is the commit below now the reaction to this ticket? Most likely not, as the ticket hasn't been closed yet. But the commit serves at least a part of the purpose of this ticket (= use From: header as identity even if it doesn't match full mailbox spec).
So I'm not sure what's this all about, and if the result that I'm seeing is indeed intentional. Or am I wrong and the behaviour described above is related to a totally different commit...?
Cheers, Michael (confused)
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 18.10.2013 21:40, schrieb GitHub:
Branch: refs/heads/master Home: https://github.com/roundcube/roundcubemail Commit: af61b9705e40efa938bd38d95173a41cf210e6dc
https://github.com/roundcube/roundcubemail/commit/af61b9705e40efa938bd38d951... Author: Niklas Femerstrand nik@qnrq.se Date: 2013-10-18 (Fri, 18 Oct 2013)
Changed paths: M program/js/app.js
Log Message:
Adds change_identity JavaScript event trigger
Commit: 771a82df9031485b3f9e7decf6b263c6847507b1
https://github.com/roundcube/roundcubemail/commit/771a82df9031485b3f9e7decf6... Author: Thomas B. thomas@roundcube.net Date: 2013-10-18 (Fri, 18 Oct 2013)
Changed paths: M program/js/app.js
Log Message:
Merge pull request #139 from qnrq/master
Adds change_identity JavaScript event trigger
Compare: https://github.com/roundcube/roundcubemail/compare/1498ac81c946...771a82df90...
Roundcube SVN commits mailing list svn@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/svn
Response requested. :)
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 19.10.2013 23:24, schrieb Michael Heydekamp:
Hi there,
may I ask what the intention of the commit quoted below exactly is...?
Here it changed the behaviour of select_identity apparently in so far as the address in the From: header is now being selected as the identity, even if it does not match the full mailbox spec (name+address).
This is in contradiction to what Alec recently wrote:
Am 14.10.2013 11:03, schrieb A.L.E.C:
On 10/14/2013 10:47 AM, Michael Heydekamp wrote:
Thanks. But are you sure about "From"? During my tests I didn't manage to select the identity in the From: header at all. The default identity had been selected instead (unless From: and Return-path: were identical).
Well, From header check matches full mailbox spec., e.g. "Roundcube Users dev@lists.roundcube.net".
This is because we want to handle correctly situation when user has many identities with same address but different name. It's not perfect and I'm not saying we don't need an improvement here.
And an hour later, he wrote:
Am 14.10.2013 12:03, schrieb A.L.E.C:
For To/Cc the matching is different. We check addresses, but give bigger prio to identity where address+name matches. So, here we're safe. I suppose we could do the same for From with some more coding. Feel free to create a ticket.
So I created a ticket:
http://trac.roundcube.net/ticket/1489378
Is the commit below now the reaction to this ticket? Most likely not, as the ticket hasn't been closed yet. But the commit serves at least a part of the purpose of this ticket (= use From: header as identity even if it doesn't match full mailbox spec).
So I'm not sure what's this all about, and if the result that I'm seeing is indeed intentional. Or am I wrong and the behaviour described above is related to a totally different commit...?
Cheers, Michael (confused)
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 18.10.2013 21:40, schrieb GitHub:
Branch: refs/heads/master Home: https://github.com/roundcube/roundcubemail Commit: af61b9705e40efa938bd38d95173a41cf210e6dc
https://github.com/roundcube/roundcubemail/commit/af61b9705e40efa938bd38d951... Author: Niklas Femerstrand nik@qnrq.se Date: 2013-10-18 (Fri, 18 Oct 2013)
Changed paths: M program/js/app.js
Log Message:
Adds change_identity JavaScript event trigger
Commit: 771a82df9031485b3f9e7decf6b263c6847507b1
https://github.com/roundcube/roundcubemail/commit/771a82df9031485b3f9e7decf6... Author: Thomas B. thomas@roundcube.net Date: 2013-10-18 (Fri, 18 Oct 2013)
Changed paths: M program/js/app.js
Log Message:
Merge pull request #139 from qnrq/master
Adds change_identity JavaScript event trigger
Compare: https://github.com/roundcube/roundcubemail/compare/1498ac81c946...771a82df90...
Roundcube SVN commits mailing list svn@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/svn
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
On 2013-11-04 15:53, Michael Heydekamp wrote:
Response requested. :)
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
See https://github.com/qnrq/rc_openpgpjs/issues/111#issuecomment-26589859
On 10/19/2013 11:24 PM, Michael Heydekamp wrote:
may I ask what the intention of the commit quoted below exactly is...?
Here it changed the behaviour of select_identity apparently in so far as the address in the From: header is now being selected as the identity, even if it does not match the full mailbox spec (name+address).
The commit you're asking has nothing to identity selection method we were discussing (and #1489378) and does not change anything. It only adds a possibility for plugin authors to bind to a new event (of identity selector change in compose screen).
-
A.L.E.C -
Lazlo Westerhof -
Michael Heydekamp