Hi,
I have improved my extended address book patch to include a "Groups" tab, this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it please let me know.
I have also extended the support for alternative email addresses to allow any number of email address to be added. This is only for the default SQL address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow different for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from this ticket http://trac.roundcube.net/ticket/1486851.
It's been tested with the default SQL address book, I'm not sure how well it will get on with LDAP as I don't have access to an LDAP address book at the moment, if any one would like to help me test it that would be appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Hi Phil
Great to see progress being made with the address book - in my opinion, this is by far the most important missing element of Roundcube.
Please can you confirm exactly which version of RC this patch is intended for, and whether it also extends the import/export functionality?
Thanks
Marcus
Marcus Don Applications Development Manager Namesco Limited
Hi,
I have improved my extended address book patch to include a "Groups" tab, this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it please let me know.
I have also extended the support for alternative email addresses to allow any number of email address to be added. This is only for the default SQL address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow different for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from this ticket http://trac.roundcube.net/ticket/1486851.
It's been tested with the default SQL address book, I'm not sure how well it will get on with LDAP as I don't have access to an LDAP address book at the moment, if any one would like to help me test it that would be appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
Hi Marcus,
The patch was created against SVN Trunk r3814. I haven't made any changes to the import/export but none should be required since they already use the vCard data.
Regards,
Phil
-----Original Message----- From: Marcus Don [mailto:mdon@names.co.uk] Sent: 19 July 2010 11:15 To: Phil Weir; dev@lists.roundcube.net Subject: Re: [RCD] improved extended address book patch with group management
Hi Phil
Great to see progress being made with the address book - in my opinion, this is by far the most important missing element of Roundcube.
Please can you confirm exactly which version of RC this patch is intended for, and whether it also extends the import/export functionality?
Thanks
Marcus
Marcus Don Applications Development Manager Namesco Limited
Hi,
I have improved my extended address book patch to include a "Groups" tab, this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it please let me know.
I have also extended the support for alternative email addresses to allow any number of email address to be added. This is only for the default SQL address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow different for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from this
ticket
http://trac.roundcube.net/ticket/1486851.
It's been tested with the default SQL address book, I'm not sure how well
it
will get on with LDAP as I don't have access to an LDAP address book at
the
moment, if any one would like to help me test it that would be
appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for
viewing.
http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
Is this patch an improvement of http://trac.roundcube.net/ticket/1486377 ?
Please attach the patch to the bug-report or create a new bug-report, so this wont be forgotten.
Unfortunately the extended adressbook feature has been postponed to roundcube 0.6.
I would really like to have a better adressbook already with roundcube 0.4-stable. At least the 0.4 addressbook should have the save fields as squirrelmail!
Best regards Johannes
Den -10-01--28163 20:59, Phil Weir skrev:
Hi,
I have improved my extended address book patch to include a "Groups" tab, this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it please let me know.
I have also extended the support for alternative email addresses to allow any number of email address to be added. This is only for the default SQL address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow different for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from this ticket http://trac.roundcube.net/ticket/1486851.
It's been tested with the default SQL address book, I'm not sure how well it will get on with LDAP as I don't have access to an LDAP address book at the moment, if any one would like to help me test it that would be appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Hi
I would really like to have a better adressbook already with roundcube 0.4-stable. At least the 0.4 addressbook should have the save fields as squirrelmail!
I strongly agree with this. Roundcube desperately needs a complete, flexible address book with full vcard compatibility. Only then will we be able to create plugins to integrate properly with external APIs, Google, Facebook, caldav and other groupware services. We get asked for these so much by our customers, we even considered switching our entire mail platform to Zimbra at one point!
Regards
Marcus
Is this patch an improvement of http://trac.roundcube.net/ticket/1486377 ?
Please attach the patch to the bug-report or create a new bug-report, so this wont be forgotten.
Unfortunately the extended adressbook feature has been postponed to roundcube 0.6.
I would really like to have a better adressbook already with roundcube 0.4-stable. At least the 0.4 addressbook should have the save fields as squirrelmail!
Best regards Johannes
Den -10-01--28163 20:59, Phil Weir skrev:
Hi,
I have improved my extended address book patch to include a "Groups" tab, this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it please let me know.
I have also extended the support for alternative email addresses to allow any number of email address to be added. This is only for the default SQL address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow different for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from this ticket http://trac.roundcube.net/ticket/1486851.
It's been tested with the default SQL address book, I'm not sure how well it will get on with LDAP as I don't have access to an LDAP address book at the moment, if any one would like to help me test it that would be appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
Hi Johannes,
This patch is my own creation, it's been around for some time, I just updated it. I could attach it to a ticket if you wanted but I'm sure just sending it to the dev list is fine. As you said the address book stuff its planned for some time and I am sure the devs will have a much better way of going about it than me. There are quite a few variations of the same thing around, on this list, trac and the forum. I wouldn't presume mine is the best. I know there are some which need SQL changes, which mine doesn't.
Regards,
Phil
-----Original Message----- From: Johannes Hessellund [mailto:johannes@shiningsun.dk] Sent: 20 July 2010 15:27 To: Phil Weir Cc: dev@lists.roundcube.net Subject: Re: [RCD] improved extended address book patch with group management
Is this patch an improvement of http://trac.roundcube.net/ticket/1486377 ?
Please attach the patch to the bug-report or create a new bug-report, so this wont be forgotten.
Unfortunately the extended adressbook feature has been postponed to roundcube 0.6.
I would really like to have a better adressbook already with roundcube 0.4-stable. At least the 0.4 addressbook should have the save fields as squirrelmail!
Best regards Johannes
Den -10-01--28163 20:59, Phil Weir skrev:
Hi,
I have improved my extended address book patch to include a "Groups" tab, this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it please let me know.
I have also extended the support for alternative email addresses to allow any number of email address to be added. This is only for the default SQL address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow different for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from this
ticket
http://trac.roundcube.net/ticket/1486851.
It's been tested with the default SQL address book, I'm not sure how well
it
will get on with LDAP as I don't have access to an LDAP address book at
the
moment, if any one would like to help me test it that would be
appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for
viewing.
http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
Hi Phil
I just did a dry run of your patch against version 0.4-stable and got the following results:
patch -b --dry-run -p0 < rc_addressbook.r3814.patch patching file skins/default/common.css Hunk #1 succeeded at 765 (offset 10 lines). patching file skins/default/functions.js patching file skins/default/addressbook.css Hunk #1 succeeded at 197 (offset -1 lines). Hunk #2 succeeded at 209 with fuzz 2 (offset -4 lines). patching file skins/default/settings.css patching file skins/default/iehacks.css patching file skins/default/templates/showcontact.html patching file skins/default/templates/addressbook.html patching file skins/default/templates/editcontact.html patching file skins/default/templates/blankcontact.html patching file skins/default/templates/addcontact.html patching file index.php patching file config/main.inc.php.dist patching file program/include/rcube_contacts.php patching file program/include/rcube_ldap.php patching file program/include/rcube_vcard.php Hunk #3 succeeded at 176 (offset 7 lines). Hunk #5 succeeded at 312 (offset 7 lines). patching file program/include/rcube_addressbook.php patching file program/localization/en_GB/labels.inc Hunk #1 succeeded at 197 (offset 1 line). patching file program/localization/en_US/labels.inc patching file program/js/app.js Hunk #1 FAILED at 299. Hunk #2 FAILED at 593. Hunk #3 FAILED at 605. Hunk #4 FAILED at 996. Hunk #5 FAILED at 3612. Hunk #6 FAILED at 3743. Hunk #7 FAILED at 3812. 7 out of 7 hunks FAILED -- saving rejects to file program/js/app.js.rej patching file program/steps/addressbook/func.inc patching file program/steps/addressbook/save.inc patching file program/steps/addressbook/show.inc patching file program/steps/addressbook/edit.inc patching file program/steps/mail/autocomplete.inc
Do you have an updated version by any chance?
Thanks
Marcus
Hi Marcus,
The patch was created against SVN Trunk r3814. I haven't made any changes to the import/export but none should be required since they already use the vCard data.
Regards,
Phil
-----Original Message----- From: Marcus Don [mailto:mdon@names.co.uk] Sent: 19 July 2010 11:15 To: Phil Weir; dev@lists.roundcube.net Subject: Re: [RCD] improved extended address book patch with group management
Hi Phil
Great to see progress being made with the address book - in my opinion, this is by far the most important missing element of Roundcube.
Please can you confirm exactly which version of RC this patch is intended for, and whether it also extends the import/export functionality?
Thanks
Marcus
Marcus Don Applications Development Manager Namesco Limited
Hi,
I have improved my extended address book patch to include a "Groups" tab, this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it please let me know.
I have also extended the support for alternative email addresses to allow any number of email address to be added. This is only for the default SQL address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow different for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from this
ticket
http://trac.roundcube.net/ticket/1486851.
It's been tested with the default SQL address book, I'm not sure how well
it
will get on with LDAP as I don't have access to an LDAP address book at
the
moment, if any one would like to help me test it that would be
appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for
viewing.
http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/ BT/aba52c80
See this is the magic of git, avoids a lot of this pain....
(or mercurial, bzr, etc)
On 12/08/2010 11:47, Marcus Don wrote:
Hi Phil
I just did a dry run of your patch against version 0.4-stable and got the following results:
patch -b --dry-run -p0 < rc_addressbook.r3814.patch patching file skins/default/common.css Hunk #1 succeeded at 765 (offset 10 lines). patching file skins/default/functions.js patching file skins/default/addressbook.css Hunk #1 succeeded at 197 (offset -1 lines). Hunk #2 succeeded at 209 with fuzz 2 (offset -4 lines). patching file skins/default/settings.css patching file skins/default/iehacks.css patching file skins/default/templates/showcontact.html patching file skins/default/templates/addressbook.html patching file skins/default/templates/editcontact.html patching file skins/default/templates/blankcontact.html patching file skins/default/templates/addcontact.html patching file index.php patching file config/main.inc.php.dist patching file program/include/rcube_contacts.php patching file program/include/rcube_ldap.php patching file program/include/rcube_vcard.php Hunk #3 succeeded at 176 (offset 7 lines). Hunk #5 succeeded at 312 (offset 7 lines). patching file program/include/rcube_addressbook.php patching file program/localization/en_GB/labels.inc Hunk #1 succeeded at 197 (offset 1 line). patching file program/localization/en_US/labels.inc patching file program/js/app.js Hunk #1 FAILED at 299. Hunk #2 FAILED at 593. Hunk #3 FAILED at 605. Hunk #4 FAILED at 996. Hunk #5 FAILED at 3612. Hunk #6 FAILED at 3743. Hunk #7 FAILED at 3812. 7 out of 7 hunks FAILED -- saving rejects to file program/js/app.js.rej patching file program/steps/addressbook/func.inc patching file program/steps/addressbook/save.inc patching file program/steps/addressbook/show.inc patching file program/steps/addressbook/edit.inc patching file program/steps/mail/autocomplete.inc
Do you have an updated version by any chance?
Thanks
Marcus
Hi Marcus,
The patch was created against SVN Trunk r3814. I haven't made any
changes to
the import/export but none should be required since they already use the vCard data.
Regards,
Phil
-----Original Message----- From: Marcus Don [mailto:mdon@names.co.uk] Sent: 19 July 2010 11:15 To: Phil Weir; dev@lists.roundcube.net Subject: Re: [RCD] improved extended address book patch with group management
Hi Phil
Great to see progress being made with the address book - in my
opinion, this
is by far the most important missing element of Roundcube.
Please can you confirm exactly which version of RC this patch is intended for, and whether it also extends the import/export functionality?
Thanks
Marcus
Marcus Don Applications Development Manager Namesco Limited
Hi,
I have improved my extended address book patch to include a "Groups"
tab,
this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it
please
let me know.
I have also extended the support for alternative email addresses to
allow
any number of email address to be added. This is only for the
default SQL
address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow
different
for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from this
ticket
http://trac.roundcube.net/ticket/1486851.
It's been tested with the default SQL address book, I'm not sure how
well
it
will get on with LDAP as I don't have access to an LDAP address book at
the
moment, if any one would like to help me test it that would be
appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for
viewing.
http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this
message.
--- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/ BT/443a308e
List info: http://lists.roundcube.net/dev/ BT/aba52c80
12.08.2010 13:47, Marcus Don wrote:
Hi Phil
...
patching file program/js/app.js Hunk #1 FAILED at 299. Hunk #2 FAILED at 593. Hunk #3 FAILED at 605. Hunk #4 FAILED at 996. Hunk #5 FAILED at 3612. Hunk #6 FAILED at 3743. Hunk #7 FAILED at 3812. 7 out of 7 hunks FAILED -- saving rejects to file program/js/app.js.rej
Try to apply that part of patch to app.src.js and move it to app.js then. _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80
On Thu, 12 Aug 2010 11:47:58 +0100, Marcus Don mdon@names.co.uk wrote:
Re: [RCD] improved extended address book patch with group management
Do you have an updated version by any chance?
The latest version is always here http://www.tehinterweb.co.uk/roundcube/ in the patches section, I don't want to spam the list with it everytime.
Thanks
Marcus
Hi Marcus,
The patch was created against SVN Trunk r3814. I haven't made any
changes to
the import/export but none should be required since they already
use the
vCard data.
Regards,
Phil
-----Original Message----- From: Marcus Don [mailto:mdon@names.co.uk [1]] Sent: 19 July 2010 11:15 To: Phil Weir; dev@lists.roundcube.net [2] Subject: Re: [RCD] improved extended address book patch with group management
Hi Phil
Great to see progress being made with the address book - in my
opinion, this
is by far the most important missing element of Roundcube.
Please can you confirm exactly which version of RC this patch is
intended
for, and whether it also extends the import/export functionality?
Thanks
Marcus
Marcus Don Applications Development Manager Namesco Limited
Hi,
I have improved my extended address book patch to include a
"Groups" tab,
this lists all the groups a contact is in (limited by address
book) and
allows users to add or remove the contact from a group by ticking
a box
(like the folder subscriptions). I'm not 100% sure about the
group
management stuff so if any one has any better ideas on how to do
it please
let me know.
I have also extended the support for alternative email addresses
to allow
any number of email address to be added. This is only for the
default SQL
address book.
Like before there is no need for any SQL changes.
Complete list of changes: *) Add "date_only" config option to specify the format when
displaying a
contacts birthday *) Add more fields based on vCard; alt email, address, telephone
etc
*) Move auto_complete function into address book class to allow
different
for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab
The extended address book patch also incorporates the patch from
this
ticket
http://trac.roundcube.net/ticket/1486851 [3].
It's been tested with the default SQL address book, I'm not sure
how well
it
will get on with LDAP as I don't have access to an LDAP address
book at
the
moment, if any one would like to help me test it that would be
appreciated.
Screenshot and patch attached.
Phil http://www.tehinterweb.co.uk/roundcube [4]
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available
for
viewing.
http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch [6]
Only click these links if you trust the sender, as well as this
message.
--- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/ [7]
Links:
[1] mailto:mdon@names.co.uk [2] http://mail.sitespider.co.uk/dev@lists.roundcube.net [3] http://trac.roundcube.net/ticket/1486851 [4] http://www.tehinterweb.co.uk/roundcube [5] http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg [6] http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch [7] http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/ BT/aba52c80
-
Ed W -
Johannes Hessellund -
Marcus Don -
Phil Weir -
Vladislav Bogdanov