Hi everyone,
I am rewriting my contextmenu plugin. The current version is suffering from being old code which has just been added too over and over.
The new version has a couple of big changes from the old one: firstly the new code is much more efficient - so it doesn't affect loading times so much. The other is that the context menu is generated from toolbars and links in the UI - everything is client side now.
I think this is good because it means the context menu uses the same functions as the core for popup menus and the folder selector, no code duplication. It also means that there is less styling and things like that for me to do and items added to the toolbar by other plugins will automatically show up in the context menu.
If you are interested please try out the new version (it requires Roundcube v1.0-RC or git-master) available here https://github.com/JohnDoh/Roundcube-Plugin-Context-Menu/archive/devel-v2.zi p and let me know what you think or if you find any problems. All feedback is welcome.
Thanks,
Phil
On 2014-02-23 05:35, Phil Weir wrote:
Hi everyone,
I am rewriting my contextmenu plugin. The current version is suffering from being old code which has just been added too over and over.
[snip]
If you are interested please try out the new version (it requires Roundcube v1.0-RC or git-master) available here https://github.com/JohnDoh/Roundcube-Plugin-Context-Menu/archive/devel-v2.zi p and let me know what you think or if you find any problems. All feedback is welcome.
Thanks,
Phil
Phil,
I've installed it in my test instance (git from a couple days ago). Seems to work fine so far. My only comment so far is that the option to mark all as read when right-clicking a folder is missing. Will it be possible to bring that back with the new code?
My only comment so far is that the option to mark all as read when right-clicking a folder is missing. Will it be possible to bring that back with the new code?
Extra functions which exist only in the contextmenu are not there, not yet anyway. First I am focusing on making sure this new approach "works" before adding extras. In general bringing them back should not be hard though.
There are a couple of options, like the one in the address book contacts menu where you could copy contacts between address books and groups from the context menu, that I am not planning on bringing back - at least not as part of the contextmenu plugin. I would like to keep it as not having any functionality of its own but just using what is already there (it can pick up functionality from other plugins).
Phil
-----Original Message----- From: dev-bounces@lists.roundcube.net [mailto:dev- bounces@lists.roundcube.net] On Behalf Of Arne Berglund Sent: 23 February 2014 23:15 To: Roundcube Development discussion mailing list Subject: Re: [RCD] contextmenu plugin new version - cal for testers and feedback
On 2014-02-23 05:35, Phil Weir wrote:
Hi everyone,
I am rewriting my contextmenu plugin. The current version is suffering from being old code which has just been added too over and over.
[snip]
If you are interested please try out the new version (it requires Roundcube v1.0-RC or git-master) available here https://github.com/JohnDoh/Roundcube-Plugin-Context-
Menu/archive/devel-v2.zi
p and let me know what you think or if you find any problems. All feedback is welcome.
Thanks,
Phil
Phil,
I've installed it in my test instance (git from a couple days ago). Seems to work fine so far. My only comment so far is that the option to mark all as read when right-clicking a folder is missing. Will it be possible to bring that back with the new code?
-- Arne Berglund System Administrator, Internet Services Lane Education Service District Eugene, OR ____________ _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
All feedback is welcome.
The mark as (not) junk button is missing the icon. This should be done by markasjunk2 plugin. The delete and archive buttons work only if a message row is selected. This is a little bit inconsistent because all other commands work for the message row from where the right click is triggered. Either the commands should be set as inactive when no row is selected or they should work without selection. Personally I'd prefer the second option.
Great job! Thank you.
The mark as (not) junk button is missing the icon. This should be done by markasjunk2 plugin.
With the current version yes, I have already altered the CSS in the git-master version so that the icons show up properly - before it had specific CSS for the contextmenu plugin and now that's not needed. I do not think there is any point in making changes to other plugins which use the contextmenu - not yet, not until this new version is a bit further along.
The delete and archive buttons work only if a message row is selected.
Could you tell me a bit more about this? It works fine for me; I tried with FF27 and IE11 too. Does anything at all happen when you try and use the delete option? Are there any JS errors or anything like that?
Either the commands should be set as inactive when no row is selected or they should work without selection.
Options which are not available should be greyed out in the menu, like the reply option when you have multiple messages selected. This works for me.
Thanks,
Phil
-----Original Message----- From: dev-bounces@lists.roundcube.net [mailto:dev- bounces@lists.roundcube.net] On Behalf Of Rosali Sent: 24 February 2014 05:10 To: Roundcube Development discussion mailing list Subject: Re: [RCD] contextmenu plugin new version - cal for testers and feedback
All feedback is welcome.
The mark as (not) junk button is missing the icon. This should be done by markasjunk2 plugin. The delete and archive buttons work only if a message row is selected. This is a little bit inconsistent because all other commands work for the message row from where the right click is triggered. Either the commands should be set as inactive when no row is selected or they should work without selection. Personally I'd prefer the second option.
Great job! Thank you.
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
The delete and archive buttons work only if a message row is selected.
Could you tell me a bit more about this? It works fine for me; I tried with FF27 and IE11 too. Does anything at all happen when you try and use the delete option? Are there any JS errors or anything like that?
Sorry for the noise. Your plugin works on a plain Roundcube installation. It must me one of the other plugins which prevents delete/archive commands from execution if no row is selected.
The delete and archive buttons work only if a message row is selected.
Could you tell me a bit more about this? It works fine for me; I tried with FF27 and IE11 too. Does anything at all happen when you try and use the delete option? Are there any JS errors or anything like that?
Sorry for the noise. Your plugin works on a plain Roundcube installation. It must me one of the other plugins which prevents delete/archive commands from execution if no row is selected.
It is my 'scheduled_sending' plugin which prevents both commands from execution if no row is selected. I'll see if I can fix it.
Regardless, I just encountered a bug. If ...
{{{ // If true, after message delete/move, the next message will be displayed $config['display_next'] = true; }}}
... is enabled then an error message ...
{{{ 'messageopenerror' }}}
... after deletion is thrown. Can you confirm this issue?
Messages drag drop does not seem to work when contextmenu plugin is enabled.
Testing environment:
Roundcube 1.0-rc Chrome 33.0.1750.117 m contextmenu from *.zip link (devs list) contextmenu is the *only* active plugin
Messages drag drop does not seem to work when contextmenu plugin is enabled.
Yep there was one bit of refactoring which didn't get moved correctly, I've fixed it now thanks.
Also I made sure display_next doesn't confuse it. I would be interested to hear what the issue is relating to your scheduled_sending plugin. I think contextmenu should be able to play nicely with other plugins!
Thanks very much for testing it so carefully.
Phil
Messages drag drop does not seem to work when contextmenu plugin is enabled.
Yep there was one bit of refactoring which didn't get moved correctly, I've fixed it now thanks.
Fixes confirmed.
Also I made sure display_next doesn't confuse it. I would be interested to hear what the issue is relating to your scheduled_sending plugin. I think contextmenu should be able to play nicely with other plugins!
The 'scheduled_sending' plugin needs specific commands to be executed when a message with a "schedule" flag is deleted. Therefore I have to cancel 'contextmenu'. I have to re-code this part of code and everything is fine again.
{{{ else{ // cancel contextmenu plugin rcube_event.cancel(e); } }}}
Thanks very much for testing it so carefully.
Thank you for the plugin! Please drop a note @ mailing list when you officially release the plugin.
On 2014-02-23 05:35, Phil Weir wrote:
Hi everyone,
I am rewriting my contextmenu plugin. The current version is suffering from being old code which has just been added too over and over.
The new version has a couple of big changes from the old one: firstly the new code is much more efficient - so it doesn't affect loading times so much. The other is that the context menu is generated from toolbars and links in the UI - everything is client side now.
I think this is good because it means the context menu uses the same functions as the core for popup menus and the folder selector, no code duplication. It also means that there is less styling and things like that for me to do and items added to the toolbar by other plugins will automatically show up in the context menu.
If you are interested please try out the new version (it requires Roundcube v1.0-RC or git-master) available here https://github.com/JohnDoh/Roundcube-Plugin-Context-Menu/archive/devel-v2.zi p and let me know what you think or if you find any problems. All feedback is welcome.
Phil, further testing seems to show that there are significant issues in Safari 7.0.x (Mac OS 10.9) with mouse-event detection and behavior, primarily in the messagelist. Folder list seems less problematic. Things like submenu requiring a second click (not expanding on mouseover), and orphaned menus hanging out after the action has taken place.
-- Arne Berglund System Administrator, Internet Services Lane Education Service District Eugene, OR ____________
Phil, further testing seems to show that there are significant issues in Safari 7.0.x (Mac OS 10.9) with mouse-event detection and behavior, primarily in the messagelist. Folder list seems less problematic. Things like submenu requiring a second click (not expanding on mouseover)
Clicking to get things like the mark sub menu or the more sub menu to show up is intentional. This is behaviour copied from the core.
orphaned menus hanging out after the action has taken place.
Confirmed in Safari, will fix.
Thanks
On 2014-02-25 23:19, Phil Weir wrote:
Clicking to get things like the mark sub menu or the more sub menu to show up is intentional. This is behaviour copied from the core.
Understood. I'm not sure I agree with the idea that contextual menu behavior needs to mimic the core, but if that's intended behavior, I can work with it.
orphaned menus hanging out after the action has taken place.
Confirmed in Safari, will fix.
Let us know when you have a new build ready to test.
-- Arne Berglund System Administrator, Internet Services Lane Education Service District Eugene, OR ____________
On 2014-02-26 08:24, Arne Berglund wrote:
On 2014-02-25 23:19, Phil Weir wrote:
Clicking to get things like the mark sub menu or the more sub menu to show up is intentional. This is behaviour copied from the core.
Understood. I'm not sure I agree with the idea that contextual menu behavior needs to mimic the core, but if that's intended behavior, I can work with it.
orphaned menus hanging out after the action has taken place.
Confirmed in Safari, will fix.
Let us know when you have a new build ready to test.
I saw the fix for the Safari issue yesterday, and applied it. It did fix the orphan menu issue.
Today I noticed that the Reply-all and Forward buttons no longer perform their default actions on a single click if contextmenu is loaded. Both menus now require the second click to select which action to perform.
-- Arne Berglund System Administrator, Internet Services Lane Education Service District Eugene, OR ____________
Today I noticed that the Reply-all and Forward buttons no longer perform their default actions on a single click if contextmenu is loaded. Both menus now require the second click to select which action to perform.
Well spotted, that was a stupid thing to do! I've fixed it now.
On 2014-02-27 22:50, Phil Weir wrote:
Today I noticed that the Reply-all and Forward buttons no longer perform their default actions on a single click if contextmenu is loaded. Both menus now require the second click to select which action to perform.
Well spotted, that was a stupid thing to do! I've fixed it now.
Confirmed, it's fixed.
We've got some issues with the contextmenu plugin, apparently there are severe compatibility problems. It's a bit difficult to explain, and it all started with a user compaint yesterday after we upgraded our production webmailer to RC 1.0. The symptom was that after login, only the very first mail was visible, and the "Loading..." message at the very top was being displayed forever (without actually loading any messages). So the user(s) did have no access to any message at all anymore.
At this time, the contextmenu plugin of 24.10.2012 was still installed with RC 1.0. After upgrading to the contextmenu version of 01.12.2013, the problem was solved. This was replicable with all browsers and their versions.
In the meantime we upgraded contextmenu in RC 1.0 to the version of 16.04.2014, and it's still working with all browsers - even under WinXP (BTW, apparently contextmenu does have no version numbering...?).
But there are more issues, even with Win7 and FF - these are the scenarios we tested, together with their results:
- WinXP / IE8 / RC 1.1 git-master / contextmenu of 16.04.14
All messages are being loaded, but right-click does not show a context menu
- the clicked message is just being highlighted in light blue instead (can
only be seen after selecting another message).
- WinXP / IE8 / RC 1.1 git-master / contextmenu of 21.04.14
Just the very first message is being loaded, the "Loading..." message at the very top is being displayed forever - no access to any message possible. So the same scenario as with RC 1.0 and contextmenu of 24.10.2012.
So there seems to be no working RC-beta/contextmenu combination for WinXP/IE8 users at all...?
- Win7/64 / FF 27.0 & IE10 / RC 1.0 & 1.1 / contextmenu of 01.12.2013
Same as 1): All messages are being loaded, but right-click does not show a context menu - the clicked message is just being highlighted in light blue instead (can only be seen after selecting another message).
- Win7/64 / FF 27.0 & IE10 / RC 1.0 & 1.1 / contextmenu of 16.04.2014
All OK.
I really hope that I didn't mix up anything in this description. Comments appreciated.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 28.02.2014 17:10, schrieb Arne Berglund:
On 2014-02-27 22:50, Phil Weir wrote:
Today I noticed that the Reply-all and Forward buttons no longer perform their default actions on a single click if contextmenu is loaded. Both menus now require the second click to select which action to perform.
Well spotted, that was a stupid thing to do! I've fixed it now.
Confirmed, it's fixed.
-- Arne Berglund System Administrator, Internet Services Lane Education Service District Eugene, OR ____________
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
Hi,
At this time, the contextmenu plugin of 24.10.2012 was still installed with RC 1.0. After upgrading to the contextmenu version of 01.12.2013, the problem was solved. This was replicable with all browsers and their versions.
You had a version of contextmenu that was from 2012?! I am not at all surprised it didn’t work. The core has changed a lot since then.
Points 1 and 2 from your email I'm going to simply ignore. Microsoft do not support Windows XP any more, there is no way I'm going to.
- Win7/64 / FF 27.0 & IE10 / RC 1.0 & 1.1 / contextmenu of 01.12.2013
Same as 1): All messages are being loaded, but right-click does not show a context menu - the clicked message is just being highlighted in light blue instead (can only be seen after selecting another message).
Are there any JS errors shown in the browser? The latest released version of the contextmenu plugin is 1.13 from 20140101. Hopefully in the next few days version 2 of the contextmenu plugin will be released which is very different to version 1 so it might be worth waiting and trying with that.
- Win7/64 / FF 27.0 & IE10 / RC 1.0 & 1.1 / contextmenu of 16.04.2014
All OK.
Assuming you mean you checked out git-master of the contextmenu plugin on 16 April, I don’t think that will work with RC 1.0, it works work RC 1.1-git but I don’t think it's backwards compatible, though I have not tried it myself.
The contextmenu plugin is available via Roundcube's plugin repository and I think that will make sure you get the most up to date version of the plugin for your version of Roundcube.
Phil
-----Original Message----- From: dev-bounces@lists.roundcube.net [mailto:dev- bounces@lists.roundcube.net] On Behalf Of Michael Heydekamp Sent: 24 April 2014 8:09 PM To: Roundcube Development discussion mailing list Subject: [RCD] Compatibility problems with contextmenu plugin (was: contextmenu plugin new version - cal for testers and feedback)
We've got some issues with the contextmenu plugin, apparently there are severe compatibility problems. It's a bit difficult to explain, and it all started with a user compaint yesterday after we upgraded our production webmailer to RC 1.0. The symptom was that after login, only the very first mail was visible, and the "Loading..." message at the very top was being displayed forever (without actually loading any messages). So the user(s) did have no access to any message at all anymore.
At this time, the contextmenu plugin of 24.10.2012 was still installed with RC 1.0. After upgrading to the contextmenu version of 01.12.2013, the problem was solved. This was replicable with all browsers and their versions.
In the meantime we upgraded contextmenu in RC 1.0 to the version of 16.04.2014, and it's still working with all browsers - even under WinXP (BTW, apparently contextmenu does have no version numbering...?).
But there are more issues, even with Win7 and FF - these are the scenarios we tested, together with their results:
- WinXP / IE8 / RC 1.1 git-master / contextmenu of 16.04.14
All messages are being loaded, but right-click does not show a context menu
- the clicked message is just being highlighted in light blue instead (can
only be seen after selecting another message).
- WinXP / IE8 / RC 1.1 git-master / contextmenu of 21.04.14
Just the very first message is being loaded, the "Loading..." message at the very top is being displayed forever - no access to any message possible. So the same scenario as with RC 1.0 and contextmenu of 24.10.2012.
So there seems to be no working RC-beta/contextmenu combination for WinXP/IE8 users at all...?
- Win7/64 / FF 27.0 & IE10 / RC 1.0 & 1.1 / contextmenu of 01.12.2013
Same as 1): All messages are being loaded, but right-click does not show a context menu - the clicked message is just being highlighted in light blue instead (can only be seen after selecting another message).
- Win7/64 / FF 27.0 & IE10 / RC 1.0 & 1.1 / contextmenu of 16.04.2014
All OK.
I really hope that I didn't mix up anything in this description. Comments appreciated.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 28.02.2014 17:10, schrieb Arne Berglund:
On 2014-02-27 22:50, Phil Weir wrote:
Today I noticed that the Reply-all and Forward buttons no longer
perform
their default actions on a single click if contextmenu is loaded. Both menus now require the second click to select which action to perform.
Well spotted, that was a stupid thing to do! I've fixed it now.
Confirmed, it's fixed.
-- Arne Berglund System Administrator, Internet Services Lane Education Service District Eugene, OR ____________
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev
Am 24.04.2014 23:57, schrieb Phil Weir:
Points 1 and 2 from your email I'm going to simply ignore. Microsoft do not support Windows XP any more, there is no way I'm going to.
:-(
BTW #1: MS does still support WinXP, you hast have to pay for it. Just like the British and the Dutch government for instance did: http://www.pcworld.com/article/2140840/windows-xp-chronicle-of-a-death-foret... http://www.zdnet.com/dutch-government-pays-millions-to-extend-microsoft-xp-s...
BTW #2: It's not about supporting WinXP anyway, but supporting IE<=10. We had a discussion about that here. It would be a bit of a strange situation if RC would still support it, but this or that plugin would not.
- Win7/64 / FF 27.0 & IE10 / RC 1.0 & 1.1 / contextmenu of 01.12.2013
Same as 1): All messages are being loaded, but right-click does not show a context menu - the clicked message is just being highlighted in light blue instead (can only be seen after selecting another message).
Are there any JS errors shown in the browser?
At least I didn't see any.
The latest released version of the contextmenu plugin is 1.13 from 20140101. Hopefully in the next few days version 2 of the contextmenu plugin will be released which is very different to version 1 so it might be worth waiting and trying with that.
Ok, we'll wait for that then.
The contextmenu plugin is available via Roundcube's plugin repository and I think that will make sure you get the most up to date version of the plugin for your version of Roundcube.
Ok, thanks.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 25.04.2014 00:38, schrieb Michael Heydekamp:
BTW #2: It's not about supporting WinXP anyway, but supporting IE<=10.
I meant IE<=8, of course.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 25.04.2014 00:38, schrieb Michael Heydekamp:
Am 24.04.2014 23:57, schrieb Phil Weir:
Points 1 and 2 from your email I'm going to simply ignore. Microsoft do not support Windows XP any more, there is no way I'm going to.
:-(
BTW #1: MS does still support WinXP, you hast have to pay for it.
That is for one or two years with a one or two years plan.
BTW #2: It's not about supporting WinXP anyway, but supporting IE<=10. We had a discussion about that here. It would be a bit of a strange situation if RC would still support it, but this or that plugin would not.
The Base-IE of Windows Vista (EOL in 2017) is IE7 and the Base-IE of Windows 7 (EOL in 2020) is IE8. So IE7 and IE8 issues are not only in the EOL-OS WinXP.
Cheers,
Martin Wodrich Admin freexp.de Waltrop/Germany
The Base-IE of Windows Vista (EOL in 2017) is IE7 and the Base-IE of Windows 7 (EOL in 2020) is IE8. So IE7 and IE8 issues are not only in the EOL-OS WinXP.
I do not have access to any IE7 so I cannot test the contextmenu with that.
I have just push up a commit that adds support for IE8 into the contextmenu (git-master of contextmenu needs RC 1.1-git). I will backport the change into the version 2 release I'm planning for RC 1.0.
Phil
On Fri, Apr 25, 2014 at 2:10 PM, Phil Weir roundcube@tehinterweb.co.uk wrote:
The Base-IE of Windows Vista (EOL in 2017) is IE7 and the Base-IE of Windows 7 (EOL in 2020) is IE8. So IE7 and IE8 issues are not only in the EOL-OS WinXP.
I do not have access to any IE7 so I cannot test the contextmenu with that.
FWIW: you can get pre-installed VMs with all IE versions for a variety of virtualization tools here: http://www.modern.ie/en-us/virtualization-tools
~Thomas
Am 25.04.2014 00:38, schrieb Michael Heydekamp:
Am 24.04.2014 23:57, schrieb Phil Weir:
Points 1 and 2 from your email I'm going to simply ignore. Microsoft do not support Windows XP any more, there is no way I'm going to.
:-(
BTW #1: MS does still support WinXP, you hast have to pay for it. Just like the British and the Dutch government for instance did: http://www.pcworld.com/article/2140840/windows-xp-chronicle-of-a-death-foret... http://www.zdnet.com/dutch-government-pays-millions-to-extend-microsoft-xp-s...
BTW #2: It's not about supporting WinXP anyway, but supporting IE<=10. We had a discussion about that here. It would be a bit of a strange situation if RC would still support it, but this or that plugin would not.
As I said already in a later message, the above should of course read "but supporting IE<=8".
This weekend, I again ran into the situation that I needed to get access to my e-mails on a "foreign" Win7 computer with IE8 (at the BMW branch in Düsseldorf, BTW), and couldn't load the messages due to the problem with contextmenu that I already described.
Is there really no chance to get a working combination of RC 1.0, Win7/IE8 and a recent contextmenu version...?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Is there really no chance to get a working combination of RC 1.0, Win7/IE8 and a recent contextmenu version...?
What version are you running? The 2.0 release works fine with IE8 for me.
Phil
Am 05.05.2014 19:01, schrieb Phil Weir:
Is there really no chance to get a working combination of RC 1.0, Win7/IE8 and a recent contextmenu version...?
What version are you running? The 2.0 release works fine with IE8 for me.
To be honest, I'm a bit confused and not quite sure anymore. It was one of the more recent versions, but it doesn't show a version number at all under Settings/About.
Probably it was the version of 21.04.14. For now, we have disabled it.
I wasn't aware that 2.0 has been released already - thanks for info, we'll try it with that one. Will revert asap.
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Am 05.05.2014 19:01, schrieb Phil Weir:
Is there really no chance to get a working combination of RC 1.0, Win7/IE8 and a recent contextmenu version...?
What version are you running? The 2.0 release works fine with IE8 for me.
We have used the version 1.33 for RC 1.0.
From now on we use the 2.0 release for both RC instances (RC 1.0 and
RC git-master).
Cheers,
Martin Wodrich Admin freexp.de Waltrop/Germany
Am 05.05.2014 19:01, schrieb Phil Weir:
Is there really no chance to get a working combination of RC 1.0, Win7/IE8 and a recent contextmenu version...?
What version are you running? The 2.0 release works fine with IE8 for me.
After we installed contextmenu 2.0 release, I can confirm that contextmenu works with RC 1.0, WinXP and E8.
BUT: It does NOT work with RC-beta, no matter which OS and which browser (so not even with Win7 and FF 27):
- Upon right click, the menu items on the top level are shown and
accessible, but a click doesn't do anything but reloading the body of the message.
- All menu items of submenus (e.g. "More...) are shown, but they're not
accessible at all (= greyed out).
Another issue: The version number of contexmenu isn't shown unter Settings/About - apparently because there's no package.xml which does contain the version number...? How to solve this?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
BUT: It does NOT work with RC-beta, no matter which OS and which browser (so not even with Win7 and FF 27):
Roundcube 1.1-git includes new multi-folder search functionality. To achieve this the way that they message list works was changed and so plugins which us it had to be changed to. There are new functions needed to find the message UID now. The git-master version of the contextmenu plugin uses these new functions, obviously the 2.0 release cannot since they do not exist in Roundcube 1.0. So for the two different versions of Roundcube you need different versions of the plugin.
Another issue: The version number of contexmenu isn't shown unter Settings/About - apparently because there's no package.xml which does contain the version number...? How to solve this?
At the moment the version information needed for the About screen is added when you download via the composer system (plugins.roundcube.net). The composer system has a few good advantages like making updates easier and making sure you get the right version of a plugin for your version of Roundcube ... ;). BTW it is my understanding that having both a composer.json file and a package.xml file is wrong. The package.xml file will never be used and plugin devs can add version information into their composer.json file if they want.
Am 10.05.2014 08:33, schrieb Phil Weir:
BUT: It does NOT work with RC-beta, no matter which OS and which browser (so not even with Win7 and FF 27):
Roundcube 1.1-git includes new multi-folder search functionality. To achieve this the way that they message list works was changed and so plugins which us it had to be changed to. There are new functions needed to find the message UID now. The git-master version of the contextmenu plugin uses these new functions, obviously the 2.0 release cannot since they do not exist in Roundcube 1.0. So for the two different versions of Roundcube you need different versions of the plugin.
Thanks for the input!
Another issue: The version number of contexmenu isn't shown unter Settings/About - apparently because there's no package.xml which does contain the version number...? How to solve this?
At the moment the version information needed for the About screen is added when you download via the composer system (plugins.roundcube.net). The composer system has a few good advantages like making updates easier and making sure you get the right version of a plugin for your version of Roundcube ... ;). BTW it is my understanding that having both a composer.json file and a package.xml file is wrong. The package.xml file will never be used and plugin devs can add version information into their composer.json file if they want.
Can the git-master version of contextmenu be installed via plugins.roundcube.net as well?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
Michael Heydekamp wrote:
In the meantime we upgraded contextmenu in RC 1.0 to the version of 16.04.2014, and it's still working with all browsers - even under WinXP (BTW, apparently contextmenu does have no version numbering...?).
I download the release-1.0 Branch from RC-Pluginrepository.
- Win7/64 / FF 27.0 & IE10 / RC 1.0 & 1.1 / contextmenu of 16.04.2014
All OK.
Wrong. The last Test was:
4a) Win7/64 / FF 27.0 & IE10 / RC 1.0 / contextmenu of 16.04.2014 (release-1.0)
All OK.
4b) Win7/64 / FF 27.0 & IE10 / RC 1.1 / contextmenu of 21.04.2014 (git-master)
All OK.
We have now different version of contextmenu in our production version of RC and the test version of RC.
Cheers,
Martin Wodrich Admin freexp.de Waltrop/Germany
-
Arne Berglund -
Martin Wodrich -
Michael Heydekamp
-
Phil Weir -
Rosali -
Thomas Bruederli