Hi RoundCube devs
(Please CC, not on the list)
I've discovered an error in the 0.2.2-stable release, which makes it impossible to use certain language files.
In the end of certain language files, there's a ^M (0x0D), which makes PHP output a newline on inclusion, which makes the whole app break, because there's a call to header() after the inclusion.
I've inlined the very simple patch to fix up the danish files:
{{{ Index: src/program/localization/da_DK/messages.inc =================================================================== --- src/program/localization/da_DK/messages.inc (revision 689) +++ src/program/localization/da_DK/messages.inc (working copy) @@ -97,4 +97,3 @@ $messages['editorwarning'] = 'Al formatering af teksten forsvinder, hvis der skiftes til ren tekst. Vil du fortsætte?';
?>
--- src/program/localization/da_DK/labels.inc (revision 689) +++ src/program/localization/da_DK/labels.inc (working copy) @@ -264,4 +264,3 @@ $labels['GB'] = 'GB';
?>
}}}
However, a few more files show symptoms of problems, but I haven't checked them out by hand:
$ grep -rl '^M' src/program/localization
src/program/localization/sr_CS/messages.inc src/program/localization/sr_CS/labels.inc src/program/localization/vi_VN/messages.inc src/program/localization/vi_VN/labels.inc src/program/localization/si_LK/messages.inc src/program/localization/si_LK/labels.inc src/program/localization/ne_NP/messages.inc src/program/localization/ne_NP/labels.inc
I hope this fix can be included in the next stable release. In the meantime, I'm making a private debian package with this patch in it.
P.S: Is there any plan to make an official Debian package -- or at least support for compiling a Debian package from source? I'd be happy to contribute the work I've done so far.
Christian Iversen wrote:
Hi RoundCube devs
[patch]
Has anyone had a chance to take a look at this? Is there someone in specific I might contact for fixes to the stable branch?
Christian Iversen wrote:
Has anyone had a chance to take a look at this? Is there someone in specific I might contact for fixes to the stable branch?
It has been fixed in svn. Currently, we do not plan to release 0.2.3, so you must wait for 0.3-stable.
On Wed, May 27, 2009 at 8:21 PM, A.L.E.C alec@alec.pl wrote:
Christian Iversen wrote:
Has anyone had a chance to take a look at this? Is there someone in specific I might contact for fixes to the stable branch?
It has been fixed in svn. Currently, we do not plan to release 0.2.3, so you must wait for 0.3-stable.
Should we remove ?> in the language files to not re-introduce these issues again?
I also don't see a reason not to do a service release. :-)
Till _______________________________________________ List info: http://lists.roundcube.net/dev/