hi
i noticed that (at least) Estonian translation in 0.5 beta tarball has extra newlines after php close tag.
what about dropping closing php tag all over roundcube code?
from the big makers, i know top off the head that ZendFramework and Horde do that already
running these three shell oneliners over the code (possibly repeating over a time) should fix the close php tag problem and also nukes trailing spaces/tabs which tend to slip in when you use misconfigured IDE to develop.
# here's shell oneliner to remove ?> from all files which have it on their last line: find -name '*.php' -o -name '*.inc' -print0 | xargs -0r sed -i -e '${/^?>$/d}' # sometimes if you are hit by this problem, you need to kill last empty line first: find -name '*.php' -o -name '*.inc' -print0 | xargs -0r sed -i -e '${/^$/d}' # and as well can remove trailing spaces/tabs: find -name '*.php' -o -name '*.inc' -print0 | xargs -0r sed -i -e 's/[\t ]+$//
On 12/08/2010 08:01 PM, Elan Ruusamäe wrote:
what about dropping closing php tag all over roundcube code?
i'm in favor of doing so.
cheers, raoul