Hi!
I have some suggestions and errors and I'd like someones advice for which of them I should create a ticket and which of them I should forget.
Points 1) - 9) I have all implemented/fixed in our local distribution (based on 0.4.2) and could provide source code for the fixes.
Here's the list:
it would be handy if function get_boolean() in rcube_shared.inc would also recognize "off" as false.
1 gigabyte is displayed as "1024MB" by function show_bytes() in rcube_shared.inc. I would prefer "1GB". Same is for "1024KB" and "1MB".
when the hook method "preferences_save" fails, saving should be aborted an error message should be displayed. Currently always success message is displayed.
Generally it is a problem to enter names containing '<' character, because this is treated as html-tag then. The list of places where '<' does not work:
a) Settings -> Folders: drag and drop a folder containing '<' and the name will change. b) Settings -> Identiies -> Settings: fields "Display name" and "Company" c) Settings -> Identiies -> Signature: when changing from non html to html signature, all '<' disappear d) all contacts fields e) all search fields f) searching in folders containing a '<' is not possible
Currently you can only export contacts one by one. It would be nice if the user could choose to export all contacts or the selected ones only. On our system I realized this with a small submenu at the export button.
the fileinfo php plugin is not very useful. E.g. pdf-files or jpeg-files are declared as octet-stream. mime_content_type() should be tried before fileinfo, not afterwards.
vcard makes sometimes problems with line folding. Multibyte UTF-8 charcters are folded in the middle and therefore cannot be inserted in database, when the DB has set the coding of the tables to UTF-8
At Settings -> Folders: you cannot drag&drop a subfolder back to top level. You could allow dropping it on INBOX and make it top level then.
I think there is an error in "./program/js/app.js.src", line 4625: $(current_li).removeClass('selected').removeClass('unfocused');
should be $(current_li).removeClass('selected').addClass('unfocused');
And 2 errors I found in the new contacts form:
When saving a contact without entering an email address, all manually added elements disappear (values are still there, but input fields are not visible)
you get an error message when you enter german character 'ß' in contacts data and save it
Kind regards, Erich. _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80
On 07.04.2011 13:14, Koessldorfer,Erich wrote:
Points 1) - 9) I have all implemented/fixed
I'm pretty sure most of them has been fixed in current version. It would be very nice if you could install svn-trunk version or at least 0.5.1 and check if these issues are still there. If they are, open tickets in bugtracker. If you'd like to provide patches, use svn-trunk as a base.
When saving a contact without entering an email address, all manually added elements disappear (values are still there, but input fields are not visible)
you get an error message when you enter german character 'ß' in contacts data and save it
I can confirm both. Please, open tickets in our bugtracker.
Hi!
Sorry, I forgot to put this, but all Points are checked against trunk version from 5th of April 2011. I already fixed them for version 0.4.2 and if would help you, I could adopt them to the most recent trunk version and send it to you.
Erich.
-----Original Message----- From: dev-bounces+erich.koessldorfer=drei.com@lists.roundcube.net [mailto:dev-bounces+erich.koessldorfer=drei.com@lists.roundcube.net] On Behalf Of A.L.E.C Sent: Donnerstag, 07. April 2011 13:28 To: dev@lists.roundcube.net Subject: Re: [RCD] some suggestions
On 07.04.2011 13:14, Koessldorfer,Erich wrote:
Points 1) - 9) I have all implemented/fixed
I'm pretty sure most of them has been fixed in current version. It would be very nice if you could install svn-trunk version or at least 0.5.1 and check if these issues are still there. If they are, open tickets in bugtracker. If you'd like to provide patches, use svn-trunk as a base.
- When saving a contact without entering an email address, all
manually added elements disappear (values are still there, but input fields are not visible)
- you get an error message when you enter german character 'ß' in
contacts data and save it
I can confirm both. Please, open tickets in our bugtracker.
-- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/f5d4f6e7 _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80
On 07.04.2011 13:14, Koessldorfer,Erich wrote:
- Generally it is a problem to enter names containing '<' character, because this is treated as html-tag then. The list of places where '<' does not work:
a) Settings -> Folders: drag and drop a folder containing '<' and the name will change. b) Settings -> Identiies -> Settings: fields "Display name" and "Company" c) Settings -> Identiies -> Signature: when changing from non html to html signature, all '<' disappear d) all contacts fields e) all search fields f) searching in folders containing a '<' is not possible
I was fixing some related issues, but it looks you're right about this.
- Currently you can only export contacts one by one. It would be nice if the user could choose to export all contacts or the selected ones only. On our system I realized this with a small submenu at the export button.
As I see Roundcube exports all contacts from selected address book and group.
- At Settings -> Folders: you cannot drag&drop a subfolder back to top level. You could allow dropping it on INBOX and make it top level then.
In new folder manager (0.5) you can move folder to root (not by drag&drop, but by setting parent folder to None).
- I think there is an error in "./program/js/app.js.src", line 4625: $(current_li).removeClass('selected').removeClass('unfocused');
should be $(current_li).removeClass('selected').addClass('unfocused');
Yes, probably. I see, we're not using unfocused class on folders list in default skin.
You're right about the others. Open tickets, please.