Hi,
I want to start develop for Roundcube. Just for training and my personal use, I make this changement: when you add a contact, the name to show is auto completed by the firstname and surname field.
If you think it could be usefull add it in the svn. I want to add some infos in address book like phone number, address .... Like in thunderbird.
Where is the better place to show the database changement? Or do i have to work on others things?
Fred
svn diff output
Index: roundcubemail/program/steps/addressbook/edit.inc
--- roundcubemail/program/steps/addressbook/edit.inc (revision 540) +++ roundcubemail/program/steps/addressbook/edit.inc (working copy) @@ -1,4 +1,4 @@ -<?php +<?php
/* +-----------------------------------------------------------------------+ @@ -65,17 +65,20 @@ // return the complete address edit form as table $out = "$form_start<table>\n\n";
- $a_show_cols = array('name', 'firstname', 'surname', 'email');
- $a_show_cols = array('firstname', 'surname', 'name', 'email'); foreach ($a_show_cols as $col) { $attrib['id'] = 'rcmfd_'.$col;
if($col == 'firstname' || $col == 'surname')$attrib['onkeyup'] = 'rcmfd_name.value=rcmfd_surname.value +
' ' +rcmfd_firstname.value;"'; $title = rcube_label($col); $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], $attrib); $out .= sprintf("<tr><td class="title"><label for="%s">%s</label></td><td>%s</td></tr>\n", $attrib['id'], $title, $value);
- }
unset($attrib['onkeyup']);
}$out .= "\n</table>$form_end";
Hi Frederic,
Thanks for your post. To implement this auto-fill I would suggest to write the code to app.js and add the event handler during task init rather than writing it directly to HTML. See how this is done for the login page near line 274 in app.js
About address book: I've already posted my ideas about the address book implementation in previous posts: http://lists.roundcube.net/mail-archive/roundcube.dev/2005/11/368/
Currently I'm re-writing the data back-end of the address book to integrate LDAP directories and enable top copy an address from one source to the other by simply drag & drop them. You can see it in the devel-addressbook branch. The structure of the address data still remains the same and there are no new fields available for now. The extension of the address book with extra fields as well as import/export functions are planned for 0.2-beta as stated in the road map.
There has been made an approach for a full featured address book which looks quite nice but has to be improved: http://lists.roundcube.net/mail-archive/roundcube.dev/2006/10/28/
Let's have a look at it once the 0.1-stable is released.
~Thomas
2007/4/8, Frederic Leroux leroux.frederic@gmail.com:
Hi,
I want to start develop for Roundcube. Just for training and my personal use, I make this changement: when you add a contact, the name to show is auto completed by the firstname and surname field.
If you think it could be usefull add it in the svn. I want to add some infos in address book like phone number, address .... Like in thunderbird.
Where is the better place to show the database changement? Or do i have to work on others things?
Fred
Hi,
Currently I'm re-writing the data back-end of the address book to integrate LDAP directories and enable top copy an address from one source to the other by simply drag & drop them. You can see it in the devel-addressbook branch. The structure of the address data still remains the same and there are no new fields available for now. The extension of the address book with extra fields as well as import/export functions are planned for 0.2-beta as stated in the road map.
Nice work !
Perhaps would it be interesting to print out when the addressbook is related to an LDAP server :
Index: func.inc
--- func.inc (révision 540) +++ func.inc (copie de travail) @@ -98,7 +98,7 @@ $js_id, JS_OBJECT_NAME, $js_id,
!empty($prop['name']) ? Q($prop['name']) : Q($id));
!empty($prop['name']) ? Q($prop['name']. " [LDAP]") : Q($id .
" [LDAP]"));
$js_list[$dom_id] = array('id' => $id, 'readonly' => !
$prop['writeable']); }
My 2 cents ;-)
2007/4/10, Pierre Mauduit pierre.mauduit@gmail.com:
Perhaps would it be interesting to print out when the addressbook is related to an LDAP server :
Good idea but I leave it up to the local installation. In config.inc.php you can specify a display name for each LDAP server. There you can name the directory as you like.
~Thomas
-
Frederic Leroux -
Pierre Mauduit -
Thomas Bruederli