This applies to beta 0.6
For the sake of the plugins that want to use as much of rcube core as possible and want to sync address books with other sources, this mod is really needed. I see that plaxo_contacts also uses this field.
Anyone syncing with an external source needs a way of keeping track of the id field on the other system. I realize that kolab_contacts has found a way around this but they also have heavily modified the way contacts works. We are trying to stay consistent with the core addressbook by keeping the format exactly the same. We store the contact data in a separate table which is exactly like the contacts table. And we let rc core do all the reading and writing to that table by simply changing the table name for the plugin.
Here is the problem and the proposed solution...
When using $CONTACTS->insert($a_record,false); where $a_record['edit'] contains a value, it works great. rcube core actually puts in X-AB-EDIT into the vcard and stores that value.
When using the hooks for contact_create and contact_update, then modifying the $a['record']['edit'] value, it does NOT work. This is easily fixed by adding one element to the fieldmap array in rcube_vcard.php
The requested change is to add 'edit' => 'X-AB-EDIT'
This change will not only make it simpler for the google_contacts plugin, but any future plugin that attempts to sync with an outside source.
I currently have this plugin working perfectly and finished, however it is based on the mod that I made in rcube_vcard.php and I am hoping that you will be willing to make this change so that everyone else can use this plugin without having to modify core to make it work.
List info: http://lists.roundcube.net/dev/ BT/aba52c80
rc wrote:
Here is the problem and the proposed solution...
When using $CONTACTS->insert($a_record,false); where $a_record['edit'] contains a value, it works great. rcube core actually puts in X-AB-EDIT into the vcard and stores that value.
When using the hooks for contact_create and contact_update, then modifying the $a['record']['edit'] value, it does NOT work. This is easily fixed by adding one element to the fieldmap array in rcube_vcard.php
The requested change is to add 'edit' => 'X-AB-EDIT'
Added in revision 4804
~Thomas
List info: http://lists.roundcube.net/dev/ BT/aba52c80