Hey Phil,

first off, apologies that we didn't address your ticket earlier - me personally, I wasn't aware of this and I don't see why this couldn't be added to RoundCube.

However, keep in mind, we get a lot of tickets/patches and requests and it's hard to address all of them and give equal attention to all. (With no offense meant, but) Of course the author of a patch always thinks their feature should be added to RoundCube right away. But keep in mind that RoundCube is still very young (0.2-alpha) and there is so much to work to be done that often we feel like new features have to wait until the base is solid.

Now back to your patch - what was the ticket where you added your patch to?

My suggestion would be to make this configurable per user (through the preferences). IMHO, this shouldn't be decided by the administrator if and when email is considered/marked read. Now I see that if I was using RoundCube just by myself that wouldn't make much of a difference, but in a lot of installations that is just not the case and if we want to add a feature for the benefit of many people this has to be addressed first.

Of course this is just my opinion. ;-)

All in all, the patch looks solid. Thanks for contributing to RoundCube.

Ole, ole, ole!

Till

On Thu, Jun 12, 2008 at 7:43 PM, Phil Weir roundcube@tehinterweb.co.uk wrote:

Hi All,

A while ago I submitted this patch to trac, it never got applied to trunk because it was decided it was unnecessary. That's fine; I thought I would just post it to the list to see what people thought. Both Outlook and Thunderbird have this option and personally I don't want mail marked as read until I say so.

Thanks,

Phil

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/g3/hAcc7iiM/rc_preview_not_read.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/

Hi,

thanks for the feedback. sorry if it seemed i was trying to jump the queue in any way. i know you guys are busy i just wanted to see what people thought of it.

till: the patch adds an option to the user prefs, the config variable is just for the default setting.

I attached a new version of the patch for r1556 and also added it to http://trac.roundcube.net/ticket/1485012 (the original ticket). I'll try and keep the version on the ticket upto date. that way any one who wants it can use it and it should be easy to apply to trunk if/when the time comes.

Thanks

Phil

On Tue, 17 Jun 2008 00:34:06 +0200, till klimpong@gmail.com wrote:

Hey Phil,

first off, apologies that we didn't address your ticket earlier - me personally, I wasn't aware of this and I don't see why this couldn't be added to RoundCube.

However, keep in mind, we get a lot of tickets/patches and requests and it's hard to address all of them and give equal attention to all. (With no offense meant, but) Of course the author of a patch always thinks their feature should be added to RoundCube right away. But keep in mind that RoundCube is still very young (0.2-alpha) and there is so much to work to be done that often we feel like new features have to wait until the base is solid.

Now back to your patch - what was the ticket where you added your patch to?

My suggestion would be to make this configurable per user (through the preferences). IMHO, this shouldn't be decided by the administrator if and when email is considered/marked read. Now I see that if I was using RoundCube just by myself that wouldn't make much of a difference, but in a lot of installations that is just not the case and if we want to add a feature for the benefit of many people this has to be addressed first.

Of course this is just my opinion. ;-)

All in all, the patch looks solid. Thanks for contributing to RoundCube.

Ole, ole, ole!

Till

On Thu, Jun 12, 2008 at 7:43 PM, Phil Weir roundcube@tehinterweb.co.uk wrote:

...

Hi All,

A while ago I submitted this patch to trac, it never got applied to

trunk

...

because it was decided it was unnecessary. That's fine; I thought I

would

...

just post it to the list to see what people thought. Both Outlook and Thunderbird have this option and personally I don't want mail marked as read until I say so.

Thanks,

Phil

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for

viewing.

...

http://detached.gigo.com/rc/g3/hAcc7iiM/rc_preview_not_read.patch Only click these links if you trust the sender, as well as this

message.

...

--- 8< --- detachments --- 8< ---

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/cP/vhtmPLxD/UTF-8_27_27rc_prev.pat Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

List info: http://lists.roundcube.net/dev/