S c o t t K r a m e r wrote:

Hello,

People are driving me crazy w/asking for contact groups... what do you guys think the timeframe for this is?

Please have a look at the current SVN trunk. A first version of this feature was just implemented. It'll be officially available with the next release (0.4).

~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

Thanks a lot, Thomas, for working on this !

On Mon, 29 Mar 2010 17:11:19 +0200, Thomas Bruederli roundcube@gmail.com wrote:

Hi devs and list lurkers

The contact groups feature in trunk is not yet finished and there remain

a

few questions I couldn't finally answer by myself. Any feedback and suggestions are welcome:

1. Should every address source provide it's own groups? This would mean

that the groups list will also be replaced when switching between

address

sources (i.e. SQL address book and LDAP). Currently the listed groups only belong to the local address book and therefore only contacts from this address source can be stored in

groups. I

assume that LDAP in general would support groups as well.

Why not importing LDAP contacts locally when adding somebody in a group ? I assume that if you want to create a group with specific contacts, then those contacts should be part of your local address book. Does anybody think this is a wrong assumption ?

2. When composing a message, groups are also included in the

find-as-you-type query and will be simply expanded when selecting them. This is the GMail way and has the advantage, that one can still remove

one

or the other recipient. The disadvantage of this behavior is that the recipients field will be cluttered with many addresses. Other mail

clients

such as Thunderbird resolve the group members when the message is sent.

I like the thunderbird behavior, much easier to send email to several groups. And if you want to double check the members of a group, you are free to do it outside of the compose window.

3. How to remove contacts from a group? The current implementation just

removes the contact when hitting "delete" and a contact group is

selected.

If no group is selected, the "delete" function will prompt the user

before

finally deleting the currently selected contact.

Where is that located ? Inside the group view or in each contact detail view ? Also, I would avoid the word 'delete' when removing a contact from a group, it gives the user the false impression that he's going to delete the contact completely. 'remove from group' would be more user-friendly I think.

Regards, Julien _______________________________________________ List info: http://lists.roundcube.net/dev/

Thomas Bruederli wrote:

1. Should every address source provide it's own groups? This would mean

that the groups list will also be replaced when switching between address sources (i.e. SQL address book and LDAP). Currently the listed groups only belong to the local address book and therefore only contacts from this address source can be stored in groups. I assume that LDAP in general would support groups as well.

I'm not sure if this will be possible, but would be definitelly better to have "shared groups", it means not assigned to books.

2. When composing a message, groups are also included in the

find-as-you-type query and will be simply expanded when selecting them. This is the GMail way and has the advantage, that one can still remove one or the other recipient. The disadvantage of this behavior is that the recipients field will be cluttered with many addresses. Other mail clients such as Thunderbird resolve the group members when the message is sent.

Personally, I like Thunderbird behavior.

3. How to remove contacts from a group? The current implementation just

I think we should add a list of assigned groups in contact's info. Also adding to/removing from groups should be done in contact's edit form.

Hi Thomas, it looks very cool!

2. When composing a message, groups are also included in the

find-as-you-type query and will be simply expanded when selecting them. This is the GMail way and has the advantage, that one can still remove one or the other recipient. The disadvantage of this behavior is that the recipients field will be cluttered with many addresses. Other mail clients such as Thunderbird resolve the group members when the message is sent.

How hard is it to make it configurable? I can see pros and cons for both. If id have to pick one id leave it as is. I like that you can remove some addresses afterwards.

3. How to remove contacts from a group? The current implementation just

removes the contact when hitting "delete" and a contact group is selected. If no group is selected, the "delete" function will prompt the user before finally deleting the currently selected contact.

I think your current implementation is fine. It's intuitive. Exactly what id expect it to do.

Some things for future work..

• obviously hooks so our plugins can get the info. My compose_addressbook plugin is dying for access :)
• maybe a site-wide setting on maximum number of entries in a group. Many SMTP servers will only allow so many recipients. I would not enjoy seeing people add 300 recipients to their groups and making them de facto mailinglists :)

Regards,

Cor

List info: http://lists.roundcube.net/dev/

2. Personally, I like the MS Outlook way (yeah, yeah, yeah...), which is to do both.

When you first add a group, in the address field it's shown only with the group name, and you can click the "+" icon next to the name to change it to show all addresses (for example, so you can remove certain addresses from the group). Or, leave it as is and outlook resolves who it needs to go to once you click "send".

Kind of the best of both worlds, if you ask me.

// Andrés

-----Original Message----- From: dev-bounces+andres.sulleiro=razorfish.com@lists.roundcube.net [mailto:dev-bounces+andres.sulleiro=razorfish.com@lists.roundcube.net] On Behalf Of Thomas Bruederli Sent: Monday, March 29, 2010 10:11 AM To: RoundCube Dev Subject: Re: [RCD] contact groups

Hi devs and list lurkers

The contact groups feature in trunk is not yet finished and there remain a few questions I couldn't finally answer by myself. Any feedback and suggestions are welcome:

1. Should every address source provide it's own groups? This would mean

that the groups list will also be replaced when switching between address sources (i.e. SQL address book and LDAP). Currently the listed groups only belong to the local address book and therefore only contacts from this address source can be stored in groups. I assume that LDAP in general would support groups as well.

2. When composing a message, groups are also included in the

find-as-you-type query and will be simply expanded when selecting them. This is the GMail way and has the advantage, that one can still remove one or the other recipient. The disadvantage of this behavior is that the recipients field will be cluttered with many addresses. Other mail clients such as Thunderbird resolve the group members when the message is sent.

3. How to remove contacts from a group? The current implementation just

removes the contact when hitting "delete" and a contact group is selected. If no group is selected, the "delete" function will prompt the user before finally deleting the currently selected contact.

Please let me know your opinions and ideas about the behavior of the contact groups in the address book and also in compose mode.

Regards, Thomas

List info: http://lists.roundcube.net/dev/ _______________________________________________ List info: http://lists.roundcube.net/dev/

I like this idea

On Tue, 30 Mar 2010 06:53:25 -0700, Andres Sulleiro Andres.Sulleiro@razorfish.com wrote:

2. Personally, I like the MS Outlook way (yeah, yeah, yeah...), which is

to do both.

When you first add a group, in the address field it's shown only with

the

group name, and you can click the "+" icon next to the name to change it

to

show all addresses (for example, so you can remove certain addresses

from

the group). Or, leave it as is and outlook resolves who it needs to go

to

once you click "send".

Kind of the best of both worlds, if you ask me.

// Andrés

-----Original Message----- From: dev-bounces+andres.sulleiro=razorfish.com@lists.roundcube.net [mailto:dev-bounces+andres.sulleiro=razorfish.com@lists.roundcube.net]

On

Behalf Of Thomas Bruederli Sent: Monday, March 29, 2010 10:11 AM To: RoundCube Dev Subject: Re: [RCD] contact groups

Hi devs and list lurkers

The contact groups feature in trunk is not yet finished and there remain

a

few questions I couldn't finally answer by myself. Any feedback and suggestions are welcome:

1. Should every address source provide it's own groups? This would mean

that the groups list will also be replaced when switching between

address

sources (i.e. SQL address book and LDAP). Currently the listed groups only belong to the local address book and therefore only contacts from this address source can be stored in

groups. I

assume that LDAP in general would support groups as well.

2. When composing a message, groups are also included in the

find-as-you-type query and will be simply expanded when selecting them. This is the GMail way and has the advantage, that one can still remove

one

or the other recipient. The disadvantage of this behavior is that the recipients field will be cluttered with many addresses. Other mail

clients

such as Thunderbird resolve the group members when the message is sent.

3. How to remove contacts from a group? The current implementation just

removes the contact when hitting "delete" and a contact group is

selected.

If no group is selected, the "delete" function will prompt the user

before

finally deleting the currently selected contact.

Please let me know your opinions and ideas about the behavior of the contact groups in the address book and also in compose mode.

Regards, Thomas

---

List info: http://lists.roundcube.net/dev/ _______________________________________________ List info: http://lists.roundcube.net/dev/

List info: http://lists.roundcube.net/dev/

On Tue, Mar 30, 2010 at 16:18, Vladislav Bogdanov bubble@hoster-ok.com wrote:

30.03.2010 16:53, Andres Sulleiro цкщеу:

...

2. Personally, I like the MS Outlook way (yeah, yeah, yeah...), which

is to do both.

When you first add a group, in the address field it's shown only with the group name, and you can click the "+" icon next to the name to change it to show all addresses (for example, so you can remove certain addresses from the group). Or, leave it as is and outlook resolves who it needs to go to once you click "send".

Kind of the best of both worlds, if you ask me.

Sounds good but is a pain to implement because we're currently working with regular textareas and it's rather complicated to add link elements there :-(

~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

Perhaps a lighter colored link below the "Recipient" heading (next to the textarea) that would say something like "expand groups". This would trigger a js call to refresh the textarea with the expanded addresses (the group name would no longer be listed so the email is not sent twice?).

However, would we allow collapsing groups? This would be difficult as you'd have to guess which group(s) to display in the textarea. (If creating a set of all groups from all expanded contacts, you might be sending to a lot more people than you initially wanted.)

-gnul

2010/3/30 Thomas Bruederli roundcube@gmail.com:

On Tue, Mar 30, 2010 at 16:18, Vladislav Bogdanov bubble@hoster-ok.com wrote:

...

30.03.2010 16:53, Andres Sulleiro цкщеу:

...

2. Personally, I like the MS Outlook way (yeah, yeah, yeah...), which

is to do both.

When you first add a group, in the address field it's shown only with the group name, and you can click the "+" icon next to the name to change it to show all addresses (for example, so you can remove certain addresses from the group). Or, leave it as is and outlook resolves who it needs to go to once you click "send".

Kind of the best of both worlds, if you ask me.

Sounds good but is a pain to implement because we're currently working with regular textareas and it's rather complicated to add link elements there :-(

~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

List info: http://lists.roundcube.net/dev/

I like this as well. Implementation should not be too difficult.

On Tue, 30 Mar 2010 17:18:49 +0300, Vladislav Bogdanov bubble@hoster-ok.com wrote:

30.03.2010 16:53, Andres Sulleiro цкщеу:

...

2. Personally, I like the MS Outlook way (yeah, yeah, yeah...), which

is to do both.

When you first add a group, in the address field it's shown only with the group name, and you can click the "+" icon next to the name to change it to show all addresses (for example, so you can remove certain addresses from the group). Or, leave it as is and outlook resolves who it needs to go to once you click "send".

Kind of the best of both worlds, if you ask me.

+1

---

List info: http://lists.roundcube.net/dev/

List info: http://lists.roundcube.net/dev/

On 3/30/10 6:53 AM, "Andres Sulleiro" Andres.Sulleiro@razorfish.com wrote:

2. Personally, I like the MS Outlook way (yeah, yeah, yeah...), which is to do

both.

When you first add a group, in the address field it's shown only with the group name, and you can click the "+" icon next to the name to change it to show all addresses (for example, so you can remove certain addresses from the group). Or, leave it as is and outlook resolves who it needs to go to once you click "send".

I like this as well. I believe the extended functionality is that you can re-collapse the list down to just the group name, unless you click again within the expanded group section and attempt to edit the list. In that case the group is permanently expanded into the appropriate recipient field, and individual contacts can be removed.

That's probably not terribly easy to do, but it's pretty handy.

-Brad

List info: http://lists.roundcube.net/dev/

Brandon Davidson wrote:

...

When you first add a group, in the address field it's shown only with the group name, and you can click the "+" icon next to the name to change it to show all addresses (for example, so you can remove certain addresses from the group). Or, leave it as is and outlook resolves who it needs to go to once you click "send".

I like this as well.

+1 from me too. See hotmail for idea how to redesign recipient fields. There you've got a box for each recipient, containing edit and delete icons. So, when editing such box with group we could display members list to select/unselect them. A lot of work, but looks nice.

31.03.2010 11:19, A.L.E.C wrote:

Vladislav Bogdanov wrote:

...

OK, my main idea - to introduce:

• 'groups' - which are supposed to send mail to whole 'group',

expandable in compose fields

• 'collections' - which are searchable for contacts but user can not

send to a whole collection.

Isn't collection == addressbook? Why? We don't need a new being.

Without automatic-addressbook plugin - yes. Here is only one SQL address book (singular case). With automatic address book plugin - yes. But having separate tables for different SQL address books is bad from the design point of view IMHO.

If we simply add 'addressbook_id' field to 'contacts' table (and one more table with names and flags of that address books) then we can have as many SQL address books as one may wish. Personal addresses (read/write/delete/search/group), collected addresses (read/move/delete), imported addresses (read-only), etc. etc. And all insert/delete operations whould be replaced with one SQL update operation if user wants to move address to different addressbook. Groups support would be limited to address books with 'groupable' flag set or whatever else.

Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/

Vladislav Bogdanov wrote:

If we simply add 'addressbook_id' field to 'contacts' table (and one more table with names and flags of that address books) then we can have as many SQL address books as one may wish. Personal addresses (read/write/delete/search/group), collected addresses (read/move/delete), imported addresses (read-only), etc. etc. And all insert/delete operations whould be replaced with one SQL update operation if user wants to move address to different addressbook. Groups support would be limited to address books with 'groupable' flag set or whatever else.

Now I understand. So, it's just the internal structure extension/optimization. There will be still two beings: addressbook and group.

Would it be an idea to start a separate thread for this idea? It has very little to do with contact groups and the discussion is now diverging a lot.
_______________________________________________ List info: http://lists.roundcube.net/dev/

But another use case is that also the public LDAP address books provide groups (e.g. all students of class X) and these groups will live in the LDAP directory and are read only.

However, the SQL address book could store group members from other sources but it'll probably not get notified if one of these foreign records is deleted in its original source. Another possibility is to implicitly copy the LDAP contact into the SQL address book when adding it to a group.

Both solutions seem a little ugly. I guess it's better not to mix ldap
and sql sources. And I guess thats where Vladislav's remarks come in.
If you want to mix SQL sources, it may be better to allow multiple
sources in the current 'contacts' table. Then mixing sql sources is
trivial. Wonder how mixing multiple LDAP sources would work :)

Cor

List info: http://lists.roundcube.net/dev/

Are there any plans to trigger JS events when an entry is add/deleted/edited on the groups list? kind of like the insertrow event availale on the contacts list? these events would be useful for plugins which want to work with the groups list and might also be useful if we want to list the groups on the contact information page as well as on the left hand side.

Thanks

Phil _______________________________________________ List info: http://lists.roundcube.net/dev/

Hi Thomas,

I've been working on adding contact groups support to my address book plugin and I'm running into a number of limitations in the existing code. It looks like it's currently set up to only allow contact groups from the default SQL backend.

After some minor tweaking in program/steps/addressbook/func.inc (changing rcmail_contact_groups to be called for each source, not just once for $CONTACTS) I can now see the groups from my plugin, but I'm having some real problems with the javascript. It seems to assume and in fact enforce the SQL-only limitation in a number of places.

Is it worth my time to work around this and contribute a patch that allows groups from more than one source, or is this something you're working on? If so, I'm happy to just wait and pick up development of my plugin again when the core code supports what I'm trying to do.

-Brad _______________________________________________ List info: http://lists.roundcube.net/dev/