Whoops, meant to send this to the list. Anyhow, here's the fixed version of my patch, if there's a better way for me to submit these please let me know.
Thanks,
Doug
Index: roundcubemail/config/main.inc.php.dist
--- roundcubemail/config/main.inc.php.dist (revision 400) +++ roundcubemail/config/main.inc.php.dist (working copy) @@ -107,6 +107,9 @@ // the default locale setting $rcmail_config['locale_string'] = 'en';
+// use this format for today's date display +$rcmail_config['date_today'] = 'H:i';
// use this format for short date display $rcmail_config['date_short'] = 'D H:i';
Index: roundcubemail/program/include/main.inc
--- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1687,7 +1687,7 @@
// define date format depending on current time if ($CONFIG['prettydate'] && !$format && $timestamp > $today_limit)
- return sprintf('%s %s', rcube_label('today'), date('H:i', $timestamp));
- return sprintf('%s %s', rcube_label('today'), date($CONFIG['date_today'] ?
$CONFIG['date_today'] : 'H:i', $timestamp)); else if ($CONFIG['prettydate'] && !$format && $timestamp > $week_limit) $format = $CONFIG['date_short'] ? $CONFIG['date_short'] : 'D H:i'; else if (!$format)
I had the same problem Dough has with the time in emails. I submited the patch I have been using in my server since beta1, and has been put in hold for a long time.
http://trac.roundcube.net/trac.cgi/ticket/1483879 If you see the date, it was posted 5 months ago.
I have the patch updated to the current post beta2 SVN tree, in case you need it.
Mario
On 12/11/06, Doug Mandell dmandell@gristle.org wrote:
Whoops, meant to send this to the list. Anyhow, here's the fixed version of my patch, if there's a better way for me to submit these please let me know.
Thanks,
Doug
Index: roundcubemail/config/main.inc.php.dist
--- roundcubemail/config/main.inc.php.dist (revision 400) +++ roundcubemail/config/main.inc.php.dist (working copy) @@ -107,6 +107,9 @@ // the default locale setting $rcmail_config['locale_string'] = 'en';
+// use this format for today's date display +$rcmail_config['date_today'] = 'H:i';
// use this format for short date display $rcmail_config['date_short'] = 'D H:i';
Index: roundcubemail/program/include/main.inc
--- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1687,7 +1687,7 @@
// define date format depending on current time if ($CONFIG['prettydate'] && !$format && $timestamp > $today_limit)
- return sprintf('%s %s', rcube_label('today'), date('H:i', $timestamp));
- return sprintf('%s %s', rcube_label('today'), date($CONFIG['date_today'] ?
$CONFIG['date_today'] : 'H:i', $timestamp)); else if ($CONFIG['prettydate'] && !$format && $timestamp > $week_limit) $format = $CONFIG['date_short'] ? $CONFIG['date_short'] : 'D H:i'; else if (!$format)
I had the same problem Dough has with the time in emails. I submited the patch I have been using in my server since beta1, and has been put in hold for a long time.
What needs to be done to get this patch applied to the trunk? Anybody who doesn't operate on military time is definitely going to want this preference in there.
I'm curious in general about what it takes to get a patch applied to trunk. I've submitted two to the dev mailing list (one that allows tabbing to the Send button when composing a message, the other this 12 hour clock patch) and neither has really been commented upon at all. If there's a way to expedite review and acceptance of the patch I'd love to know, if there's not then I'll continue to do what I'm doing (send the patch to the dev list, submit it on trac as well).
Thanks,
Doug
Would be better a user defined preference, so that people can bypass the default option.
On 12/14/06, Doug Mandell dmandell@gristle.org wrote:
I had the same problem Dough has with the time in emails. I submited the patch I have been using in my server since beta1, and has been put in hold for a long time.
What needs to be done to get this patch applied to the trunk? Anybody who doesn't operate on military time is definitely going to want this preference in there.
I'm curious in general about what it takes to get a patch applied to trunk. I've submitted two to the dev mailing list (one that allows tabbing to the Send button when composing a message, the other this 12 hour clock patch) and neither has really been commented upon at all. If there's a way to expedite review and acceptance of the patch I'd love to know, if there's not then I'll continue to do what I'm doing (send the patch to the dev list, submit it on trac as well).
Thanks,
Doug
Doug Mandell wrote:
Whoops, meant to send this to the list. Anyhow, here's the fixed version of my patch, if there's a better way for me to submit these please let me know.
Thanks, committed as SVN 423.
Robin
-
Doug Mandell -
Mario Vazquez -
Robin Elfrink