Re: [RCD] [Svn] [roundcube/roundcubemail] c3762a: Fix folder names truncation in Classic skin (#1489220)
Am 04.07.2013 11:20, schrieb GitHub:
Log Message:
Fix folder names truncation in Classic skin (#1489220)
Thanks! But well, they're shortened rather than trucated (at least in IE8), that's how it should be, right?
Fix bug where not all event handlers were executed (because body onload was executed after rcmail init function, sometimes)
Interesting... Which possible and visible bugs (could) have occurred due to this?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
On 07/05/2013 12:19 AM, Michael Heydekamp wrote:
Fix folder names truncation in Classic skin (#1489220)
Thanks! But well, they're shortened rather than trucated (at least in IE8), that's how it should be, right?
Yes. In classic skin we use "shortening", but in larry it's "truncating" (text-overflow:ellipsis). Larry's solution is simpler/faster and that's good. I suppose we could do the same in classic, but I don't want to spend more time on this.
Fix bug where not all event handlers were executed (because body onload was executed after rcmail init function, sometimes)
Interesting... Which possible and visible bugs (could) have occurred due to this?
Sometimes the shortening method wasn't executed on page load at all.
Am 05.07.2013 08:06, schrieb A.L.E.C:
On 07/05/2013 12:19 AM, Michael Heydekamp wrote:
Fix folder names truncation in Classic skin (#1489220)
Thanks! But well, they're shortened rather than trucated (at least in IE8), that's how it should be, right?
Yes. In classic skin we use "shortening", but in larry it's "truncating" (text-overflow:ellipsis). Larry's solution is simpler/faster and that's good.
I don't really care if it's shortened or truncated, but wait, thinking about it again, shortened may even be slightly better, as then folders such as...
roundcubemail-announce roundcubemail-dev roundcubemail-svn roundcubemail-users
... could probably look all the same if they would get truncated.
I suppose we could do the same in classic, but I don't want to spend more time on this.
Right, please don't do! ;-)
Just had a quick look into Larry again, and no, still don't like it. And not only because it still doesn't handle/display our custom logo correctly, but it's also still wasting way too much screen space for no real technical benefit...
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany
-
A.L.E.C -
Michael Heydekamp